Skip to contentSkip to conversation

ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX.

PATCH In review [email protected] 2 participants 3 messages Feb 18, 2014 – Feb 26, 2014 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX.

From: Ben Greear <[email protected]>

This appears to fix the problem of running out of keys in the firmware. Possibly it only hides the problem, however.

---
 drivers/net/wireless/ath/ath10k/hw.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath10k/hw.h +2 -2
index 89167d5..dede8e0 100644
@@ -83,7 +83,7 @@ enum ath10k_mcast2ucast_mode {
 #define TARGET_NUM_PEERS			16
 #define TARGET_NUM_OFFLOAD_PEERS		0
 #define TARGET_NUM_OFFLOAD_REORDER_BUFS         0
-#define TARGET_NUM_PEER_KEYS			2
+#define TARGET_NUM_PEER_KEYS			(WMI_MAX_KEY_INDEX + 1) /* 4 */
 #define TARGET_NUM_TIDS		(2 * ((TARGET_NUM_PEERS) + (TARGET_NUM_VDEVS)))
 #define TARGET_TX_CHAIN_MASK			(BIT(0) | BIT(1) | BIT(2))
 #define TARGET_RX_CHAIN_MASK			(BIT(0) | BIT(1) | BIT(2))
@@ -125,7 +125,7 @@ enum ath10k_mcast2ucast_mode {
 
 #define TARGET_10X_NUM_OFFLOAD_PEERS		0
 #define TARGET_10X_NUM_OFFLOAD_REORDER_BUFS	0
-#define TARGET_10X_NUM_PEER_KEYS		2
+#define TARGET_10X_NUM_PEER_KEYS		(WMI_MAX_KEY_INDEX + 1) /* 4 */
 #define TARGET_10X_NUM_TIDS			256
 #define TARGET_10X_TX_CHAIN_MASK		(BIT(0) | BIT(1) | BIT(2))
 #define TARGET_10X_RX_CHAIN_MASK		(BIT(0) | BIT(1) | BIT(2))
Signature · 7 lines
1.7.11.7


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
author
#2 lore raw
Quoted 4 lines · Kalle Valo
Quoted 2 lines · [email protected] writes:

From: Ben Greear <[email protected]>

Quoted 8 lines
Quoted 5 lines

This appears to fix the problem of running out of keys in the firmware. Possibly it only hides the problem, however.

IIRC you asked me to drop this patch in other thread. I have now done that.

Yes, it breaks upstream firmware (looks like it asserts, but not sure exactly why).

I still think it might be a problem, but it would take someone with newer firmware source and/or better understanding of how the keys are supposed to work to know for sure.

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k