Skip to contentSkip to conversation

ath9k: Enable U-APSD AP mode support

PATCH In review Jouni Malinen 3 participants 4 messages Feb 18, 2014 – Feb 19, 2014 Qualcomm Atheros ATH9K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath9k: Enable U-APSD AP mode support

mac80211 handles the actual operations, so ath9k can just indicate support for this. Based on initial tests, this combination seems to work fine.

---
 drivers/net/wireless/ath/ath9k/init.c |    1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath9k/init.c +1 -0
index 07a0315..4856a17 100644
@@ -949,6 +949,7 @@ static void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
 	hw->wiphy->flags |= WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL;
 	hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_5_10_MHZ;
 	hw->wiphy->flags |= WIPHY_FLAG_HAS_CHANNEL_SWITCH;
+	hw->wiphy->flags |= WIPHY_FLAG_AP_UAPSD;
 
 	hw->queues = 4;
 	hw->max_rates = 4;
Signature · 5 lines
1.7.9.5


-- 
Jouni Malinen                                            PGP id EFC895FA
#1 lore raw
Quoted 3 lines · Jouni Malinen

mac80211 handles the actual operations, so ath9k can just indicate support for this. Based on initial tests, this combination seems to work fine.

I believe this is not true with aggregation sessions.

johannes

#2 lore raw
Quoted 6 lines · Johannes Berg
Quoted 3 lines · Jouni Malinen

mac80211 handles the actual operations, so ath9k can just indicate support for this. Based on initial tests, this combination seems to work fine.

I believe this is not true with aggregation sessions.

Why not? Block Ack Window handling is handled by .release_buffered_frames just fine (and tested with PS-Poll).

- Felix

#3 lore raw
Quoted 9 lines · Felix Fietkau
Quoted 6 lines · Johannes Berg
Quoted 3 lines · Jouni Malinen

mac80211 handles the actual operations, so ath9k can just indicate support for this. Based on initial tests, this combination seems to work fine.

I believe this is not true with aggregation sessions.

Why not? Block Ack Window handling is handled by .release_buffered_frames just fine (and tested with PS-Poll).

Yeah, n/m, I missed that you implemented that.

johannes