Bluetooth: Use same LE min/max connection event length during update
Subsystems (2)
Marcel Holtmann
maintainerPATCH 1/1 Bluetooth: Use same LE min/max connection event length during update
During LE connection establishment the value 0x0000 is used for min/max connection event length. So use the same value when the peripheral is requesting an update of the the connection paramters.
For some reason the value 0x0001 got used in the connection update and 0x0000 in the connection creation. Using the same value for both just makes sense.
--- net/bluetooth/hci_conn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/bluetooth/hci_conn.c +2 -2
@@ -225,8 +225,8 @@ void hci_le_conn_update(struct hci_conn *conn, u16 min, u16 max, cp.conn_interval_max =cpu_to_le16 (max); cp.conn_latency =cpu_to_le16 (latency); cp.supervision_timeout =cpu_to_le16 (to_multiplier); - cp.min_ce_len =__constant_cpu_to_le16 (0x0001 ); - cp.max_ce_len =__constant_cpu_to_le16 (0x0001 ); + cp.min_ce_len =__constant_cpu_to_le16 (0x0000 ); + cp.max_ce_len =__constant_cpu_to_le16 (0x0000 );hci_send_cmd (hdev,HCI_OP_LE_CONN_UPDATE ,sizeof (cp), &cp); }
Signature · 1 line
1.8.5.3
Johan Hedberg
AppliedHi Marcel,
Quoted 4 lines · Marcel Holtmann
During LE connection establishment the value
0x0000is used for min/max connection event length. So use the same value when the peripheral is requesting an update of the the connection paramters.
Quoted 8 lines
For some reason the value
0x0001got used in the connection update and0x0000in the connection creation. Using the same value for both just makes sense.Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/hci_conn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to bluetooth-next. Thanks.
Johan