regulator: tps65218: Add terminate entry for of_device_id table
Subsystems (2)
PATCH v2 1/3 regulator: tps65218: Add terminate entry for of_device_id table
Fixes below build error:
FATAL: drivers/regulator/tps65218-regulator: struct of_device_id is not terminated with a NULL entry!
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/tps65218-regulator.c | 1 + 1 file changed, 1 insertion(+)
drivers/regulator/tps65218-regulator.c +1 -0
@@ -96,6 +96,7 @@ static const struct of_device_id tps65218_of_match[] = {TPS65218_OF_MATCH ("ti,tps65218-dcdc5" , tps65218_pmic_regs[DCDC5 ]),TPS65218_OF_MATCH ("ti,tps65218-dcdc6" , tps65218_pmic_regs[DCDC6 ]),TPS65218_OF_MATCH ("ti,tps65218-ldo1" , tps65218_pmic_regs[LDO1 ]), + { } };MODULE_DEVICE_TABLE (of, tps65218_of_match);
Signature · 1 line
1.8.1.2
PATCH v2 2/3 regulator: tps65218: Remove unnecessary regulator_unregister call
Current code uses devm_regulator_register() so the we don't need to explicitly call regulator_unregister() in .remove.
And then we don't need to save rdev pointer to tps->rdev[id].
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/tps65218-regulator.c | 18 ------------------ 1 file changed, 18 deletions(-)
drivers/regulator/tps65218-regulator.c +0 -18
@@ -267,23 +267,6 @@ static int tps65218_regulator_probe(struct platform_device *pdev)return PTR_ERR (rdev); } -/* Save regulator */ - tps->rdev[id] = rdev; - -return 0 ; -} - -static int tps65218_regulator_remove (struct platform_device *pdev) -{ -struct tps65218 *tps =platform_get_drvdata (pdev); -const struct of_device_id *match; -const struct tps_info *template; - - match =of_match_device (tps65218_of_match, &pdev->dev); - template = match->data; -regulator_unregister (tps->rdev[template->id]); -platform_set_drvdata (pdev,NULL ); -return 0 ; }
@@ -294,7 +277,6 @@ static struct platform_driver tps65218_regulator_driver = { .of_match_table = of_match_ptr(tps65218_of_match), }, .probe = tps65218_regulator_probe, - .remove = tps65218_regulator_remove, };module_platform_driver (tps65218_regulator_driver);
Signature · 1 line
1.8.1.2