Skip to contentSkip to conversation

mplayer autobuild fixes

PATCH New Fabio Porcedda 3 participants 9 messages Feb 19, 2014

lore
Share & tools
lore
#0 lore raw

cover mplayer autobuild fixes

Some mplayer autobuild fixes.

Best regards

Fabio Porcedda (3):
mplayer: not available on bfin
mplayer: remove sh2 support
mplayer: add missing reverse dependencies for bfin and sh2a

 package/libplayer/Config.in | 3 ++-
 package/mplayer/Config.in   | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)
Signature · 1 line
1.8.5.2
#1 lore raw

PATCH 1/3 mplayer: not available on bfin

Fixes:
http://autobuild.buildroot.net/results/109/109b7c9b575c7362c4982a908a1e3695e7590ebd/

---
 package/libplayer/Config.in | 3 ++-
 package/mplayer/Config.in   | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)
package/libplayer/Config.in +2 -1
index 113f650..84dad1d 100644
@@ -13,7 +13,8 @@ if BR2_PACKAGE_LIBPLAYER
 config BR2_PACKAGE_LIBPLAYER_MPLAYER
 	bool "mplayer backend"
 	# mplayer
-	depends on !BR2_sh4a && !BR2_sh4aeb && !BR2_microblaze && !BR2_aarch64
+	depends on !(BR2_bfin || BR2_sh4a || BR2_sh4aeb || BR2_microblaze || \
+		   BR2_aarch64)
 	# mplayer
 	depends on BR2_LARGEFILE
 	# mplayer
package/mplayer/Config.in +2 -2
index ae273e4..f2b3620 100644
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_MPLAYER
 	bool "mplayer"
 	# Those architectures are not supported by MPlayer
-	depends on !(BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
+	depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
 			|| BR2_microblaze || BR2_aarch64 || BR2_nios2)
 	# Broken support for <ARMv5
 	depends on !(BR2_arm7tdmi || BR2_arm720t || BR2_arm920t \
@@ -29,6 +29,6 @@ config BR2_PACKAGE_MPLAYER_MENCODER
 endif
 
 comment "mplayer needs a toolchain w/ largefile"
-	depends on !(BR2_sh2 || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
+	depends on !(BR2_bfin || BR2_sh2 || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
 			|| BR2_microblaze || BR2_aarch64)
 	depends on !BR2_LARGEFILE
Signature · 1 line
1.8.5.2
#2 lore raw

PATCH 1/3 mplayer: not available on bfin

Dear Fabio Porcedda,

Quoted 28 lines · Fabio Porcedda

Fixes:
http://autobuild.buildroot.net/results/109/109b7c9b575c7362c4982a908a1e3695e7590ebd/

---
 package/libplayer/Config.in | 3 ++-
 package/mplayer/Config.in   | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)
package/libplayer/Config.in +2 -1
index 113f650..84dad1d 100644
@@ -13,7 +13,8 @@ if BR2_PACKAGE_LIBPLAYER
 config BR2_PACKAGE_LIBPLAYER_MPLAYER
 	bool "mplayer backend"
 	# mplayer
-	depends on !BR2_sh4a && !BR2_sh4aeb && !BR2_microblaze && !BR2_aarch64
+	depends on !(BR2_bfin || BR2_sh4a || BR2_sh4aeb || BR2_microblaze || \
+		   BR2_aarch64)
 	# mplayer
 	depends on BR2_LARGEFILE
 	# mplayer
package/mplayer/Config.in +0 -0
index ae273e4..f2b3620 100644

package/mplayer/Config.in line 5

Quoted 6 lines
package/mplayer/Config.in +1 -1
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_MPLAYER
 	bool "mplayer"
 	# Those architectures are not supported by MPlayer
-	depends on !(BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
+	depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
 			|| BR2_microblaze || BR2_aarch64 || BR2_nios2)

I believe it's time to switch to a different logic. What about:

config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
bool
depends on <list of supported architectures>

and then use "depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS" / "depends on !BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS" all over the place instead of duplicating the list of architectures everywhere.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/3 mplayer: not available on bfin

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

I believe it's time to switch to a different logic. What about:

config BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
bool
depends on <list of supported architectures>

I agree this would be a nice cleanup, but I've applied this series for now for 2014.02.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 2/3 mplayer: remove sh2 support

In reply to Fabio Porcedda

Remove a leftover of the commit commit e543f5a10488b020bb4ccb03e6de0e455c64841a (arch: remove sh2, sh3 and sh3eb support).

---
 package/mplayer/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mplayer/Config.in +1 -1
index f2b3620..cfe824d 100644
@@ -29,6 +29,6 @@ config BR2_PACKAGE_MPLAYER_MENCODER
 endif
 
 comment "mplayer needs a toolchain w/ largefile"
-	depends on !(BR2_bfin || BR2_sh2 || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
+	depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
 			|| BR2_microblaze || BR2_aarch64)
 	depends on !BR2_LARGEFILE
Signature · 1 line
1.8.5.2
#6 lore raw

PATCH 2/3 mplayer: remove sh2 support

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabio" == Fabio Porcedda <[email protected]> writes:

Remove a leftover of the commit commit e543f5a10488b020bb4ccb03e6de0e455c64841a (arch: remove sh2, sh3 and sh3eb support).

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 3/3 mplayer: add missing reverse dependencies for bfin and sh2a

In reply to Fabio Porcedda

Propagate to comment and libplayer unsupported platforms bfin and sh2a.

Fixes:
http://autobuild.buildroot.net/results/5d8/5d80ade791319b6a66ac1c342f7b1d25c023f0af/

---
 package/libplayer/Config.in | 4 ++--
 package/mplayer/Config.in   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
package/libplayer/Config.in +2 -2
index 84dad1d..c8271a1 100644
@@ -13,8 +13,8 @@ if BR2_PACKAGE_LIBPLAYER
 config BR2_PACKAGE_LIBPLAYER_MPLAYER
 	bool "mplayer backend"
 	# mplayer
-	depends on !(BR2_bfin || BR2_sh4a || BR2_sh4aeb || BR2_microblaze || \
-		   BR2_aarch64)
+	depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb || \
+		   BR2_microblaze || BR2_aarch64 || BR2_nios)
 	# mplayer
 	depends on BR2_LARGEFILE
 	# mplayer
package/mplayer/Config.in +1 -1
index cfe824d..bacd744 100644
@@ -30,5 +30,5 @@ endif
 
 comment "mplayer needs a toolchain w/ largefile"
 	depends on !(BR2_bfin || BR2_sh2a || BR2_sh4a || BR2_sh4aeb \
-			|| BR2_microblaze || BR2_aarch64)
+			|| BR2_microblaze || BR2_aarch64 || BR2_nios2)
 	depends on !BR2_LARGEFILE
Signature · 1 line
1.8.5.2
#8 lore raw

PATCH 3/3 mplayer: add missing reverse dependencies for bfin and sh2a

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabio" == Fabio Porcedda <[email protected]> writes:

Propagate to comment and libplayer unsupported platforms bfin and sh2a. Fixes:
http://autobuild.buildroot.net/results/5d8/5d80ade791319b6a66ac1c342f7b1d25c023f0af/

s/bfin/nios2/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard