infiniband, ocrdma, Fix compiler warning [v2]
Subsystems (2)
PATCH 1/1 infiniband, ocrdma, Fix compiler warning [v2]
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function ‘_ocrdma_modify_qp’:drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1299:31: error: ‘old_qps’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps);
ocrdma_mbx_modify_qp() (and subsequent calls) doesn't appear to use old_qps so it doesn't need to be passed on. Removing the variable results in the warning going away.
[v2]: updated email addresses
Cc Roland Dreier <[email protected]>
Cc Sean Hefty <[email protected]>
Cc Hal Rosenstock <[email protected]>
Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>
Cc Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/[email protected]>
Cc Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Prarit Bhargava <[email protected]>
--- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 8 +++----- drivers/infiniband/hw/ocrdma/ocrdma_hw.h | 3 +-- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +- 3 files changed, 5 insertions(+), 8 deletions(-)
drivers/infiniband/hw/ocrdma/ocrdma_hw.c +3 -5
@@ -2127,8 +2127,7 @@ static int ocrdma_set_av_params(struct ocrdma_qp *qp,static int ocrdma_set_qp_params (struct ocrdma_qp *qp,struct ocrdma_modify_qp *cmd, -struct ib_qp_attr *attrs,int attr_mask, -enum ib_qp_state old_qps) +struct ib_qp_attr *attrs,int attr_mask) {int status =0 ;
@@ -2233,8 +2232,7 @@ pmtu_err: }int ocrdma_mbx_modify_qp (struct ocrdma_dev *dev,struct ocrdma_qp *qp, -struct ib_qp_attr *attrs,int attr_mask, -enum ib_qp_state old_qps) +struct ib_qp_attr *attrs,int attr_mask) {int status = -ENOMEM ;struct ocrdma_modify_qp *cmd;
@@ -2257,7 +2255,7 @@ int ocrdma_mbx_modify_qp(struct ocrdma_dev *dev, struct ocrdma_qp *qp,OCRDMA_QP_PARAMS_STATE_MASK ; } - status =ocrdma_set_qp_params (qp, cmd, attrs, attr_mask, old_qps); + status =ocrdma_set_qp_params (qp, cmd, attrs, attr_mask);if (status) goto mbx_err; status =ocrdma_mbx_cmd (dev, (struct ocrdma_mqe *)cmd);
drivers/infiniband/hw/ocrdma/ocrdma_hw.h +1 -2
@@ -112,8 +112,7 @@ int ocrdma_mbx_create_qp(struct ocrdma_qp *, struct ib_qp_init_attr *attrs, u8 enable_dpp_cq, u16 dpp_cq_id, u16 *dpp_offset, u16 *dpp_credit_lmt);int ocrdma_mbx_modify_qp (struct ocrdma_dev *,struct ocrdma_qp *, -struct ib_qp_attr *attrs,int attr_mask, -enum ib_qp_state old_qps); +struct ib_qp_attr *attrs,int attr_mask);int ocrdma_mbx_query_qp (struct ocrdma_dev *,struct ocrdma_qp *,struct ocrdma_qp_params *param);int ocrdma_mbx_destroy_qp (struct ocrdma_dev *,struct ocrdma_qp *);
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +1 -1
@@ -1296,7 +1296,7 @@ int _ocrdma_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,*/ if (status <0 )return status; - status =ocrdma_mbx_modify_qp (dev, qp, attr, attr_mask, old_qps); + status =ocrdma_mbx_modify_qp (dev, qp, attr, attr_mask);if (!status && attr_mask &IB_QP_STATE && attr->qp_state ==IB_QPS_RTR )ocrdma_flush_rq_db (qp);
Signature · 6 lines
1.7.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html