powerpc: select MEMORY for FSL_IFC to not break existing .config files
Subsystems (5)
PATCH 1/1 powerpc: select MEMORY for FSL_IFC to not break existing .config files
commit d2ae2e20fbdde5a65f3a5a153044ab1e5c53f7cc ("driver/memory:Move Freescale IFC driver to a common driver") introduces this build regression into the mpc85xx_defconfig:
drivers/built-in.o: In function `fsl_ifc_nand_remove':
drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference to fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference to fsl_ifc_ctrl_dev' drivers/built-in.o: In function `fsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference to fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference to fsl_ifc_ctrl_dev' drivers/built-in.o: In function `match_bank':
drivers/mtd/nand/fsl_ifc_nand.c:1013: undefined reference to convert_ifc_address' drivers/built-in.o: In function fsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1059: undefined reference to fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1080: undefined reference to fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference to fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference to fsl_ifc_ctrl_dev'
make: *** [vmlinux] Error 1
This happens because there is nothing to descend us into the drivers/memory directory in the mpc85xx_defconfig. It wasn't selecting CONFIG_MEMORY. So we never built drivers/memory/fsl_ifc.o even with CONFIG_FSL_IFC=y, and so we have nothing to link against.
In order to remain compatible with old config files and to avoid such build failures, make CONFIG_FSL_IFC select CONFIG_MEMORY. Also fix the whitespace issue (spaces vs. a tab) in the Kconfig.
---
[This probably makes sense to go in via Greg's char-misc/char-misc-next
(vs. powerpc-next) since that is where the regression was introduced.]
arch/powerpc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/powerpc/Kconfig +2 -1
@@ -738,7 +738,8 @@ config FSL_LBC config FSL_IFC bool - depends on FSL_SOC + depends on FSL_SOC + select MEMORY config FSL_GTM bool
Signature · 1 line
1.8.5.2
Quoted 45 lines · Paul Gortmaker
commit
d2ae2e20fbdde5a65f3a5a153044ab1e5c53f7cc("driver/memory:Move Freescale IFC driver to a common driver") introduces this build regression into thempc85xx_defconfig:
drivers/built-in.o: In function `fsl_ifc_nand_remove':
drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference tofsl_ifc_ctrl_dev'drivers/built-in.o: In function `fsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference tofsl_ifc_ctrl_dev'drivers/built-in.o: In function `match_bank':
drivers/mtd/nand/fsl_ifc_nand.c:1013: undefined reference toconvert_ifc_address' drivers/built-in.o: In functionfsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1059: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1080: undefined reference tofsl_ifc_ctrl_dev'drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference tofsl_ifc_ctrl_dev'
make: *** [vmlinux] Error 1This happens because there is nothing to descend us into the
drivers/memorydirectory in thempc85xx_defconfig. It wasn't selectingCONFIG_MEMORY. So we never builtdrivers/memory/fsl_ifc.oeven withCONFIG_FSL_IFC=y, and so we have nothing to link against.In order to remain compatible with old config files and to avoid such build failures, make
CONFIG_FSL_IFCselectCONFIG_MEMORY. Also fix the whitespace issue (spaces vs. a tab) in theKconfig.Cc Prabhakar Kushwaha <[email protected]>Cc Arnd Bergmann <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>---
[This probably makes sense to go in via Greg's char-misc/char-misc-next
(vs. powerpc-next) since that is where the regression was introduced.]arch/powerpc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/powerpc/Kconfig +0
-0
arch/powerpc/Kconfig config FSL_LBC · line 742
Quoted 6 lines
arch/powerpc/Kconfig +2
-1@@ -738,7 +738,8 @@ config FSL_LBC config FSL_IFC bool - depends on FSL_SOC + depends on FSL_SOC + select MEMORY
Why do we still have FSL_IFC in arch/powerpc/Kconfig if the driver has been moved? The NAND driver and other selectors of FSL_IFC can select MEMORY.
-Scott
Quoted 47 lines · Scott Wood
Quoted 46 lines · Paul Gortmaker
commit
d2ae2e20fbdde5a65f3a5a153044ab1e5c53f7cc("driver/memory:Move Freescale IFC driver to a common driver") introduces this build regression into thempc85xx_defconfig:
drivers/built-in.o: In function `fsl_ifc_nand_remove':
drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference tofsl_ifc_ctrl_dev'drivers/built-in.o: In function `fsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference tofsl_ifc_ctrl_dev'drivers/built-in.o: In function `match_bank':
drivers/mtd/nand/fsl_ifc_nand.c:1013: undefined reference toconvert_ifc_address' drivers/built-in.o: In functionfsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1059: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1080: undefined reference tofsl_ifc_ctrl_dev'drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference tofsl_ifc_ctrl_dev'
make: *** [vmlinux] Error 1This happens because there is nothing to descend us into the
drivers/memorydirectory in thempc85xx_defconfig. It wasn't selectingCONFIG_MEMORY. So we never builtdrivers/memory/fsl_ifc.oeven withCONFIG_FSL_IFC=y, and so we have nothing to link against.In order to remain compatible with old config files and to avoid such build failures, make
CONFIG_FSL_IFCselectCONFIG_MEMORY. Also fix the whitespace issue (spaces vs. a tab) in theKconfig.Cc Prabhakar Kushwaha <[email protected]>Cc Arnd Bergmann <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>---
[This probably makes sense to go in via Greg's char-misc/char-misc-next
(vs. powerpc-next) since that is where the regression was introduced.]arch/powerpc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/powerpc/Kconfig +0
-0@@ -738,7 +738,8 @@ config FSL_LBC
Quoted 9 lines
arch/powerpc/Kconfig config FSL_LBC · line 742
Quoted 5 lines
arch/powerpc/Kconfig +2
-1config FSL_IFC bool - depends on FSL_SOC + depends on FSL_SOC + select MEMORYWhy do we still have
FSL_IFCinarch/powerpc/Kconfigif the driver has been moved? The NAND driver and other selectors ofFSL_IFCcan select MEMORY.
At the risk of a slightly larger footprint to the regression fix, I'd agree that is a better overall solution. I'll code that up.
Unless folks want the regression fix as-is, and then the move?
Paul.
--
Quoted 4 lines
-Scott
PATCH v2 1/1 powerpc: select MEMORY for FSL_IFC to not break existing .config files
In reply to Scott Woodcommit d2ae2e20fbdde5a65f3a5a153044ab1e5c53f7cc ("driver/memory:Move Freescale IFC driver to a common driver") introduces this build regression into the mpc85xx_defconfig:
drivers/built-in.o: In function `fsl_ifc_nand_remove':
drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference to fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference to fsl_ifc_ctrl_dev' drivers/built-in.o: In function `fsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference to fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference to fsl_ifc_ctrl_dev' drivers/built-in.o: In function `match_bank':
drivers/mtd/nand/fsl_ifc_nand.c:1013: undefined reference to convert_ifc_address' drivers/built-in.o: In function fsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1059: undefined reference to fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1080: undefined reference to fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference to fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference to fsl_ifc_ctrl_dev'
make: *** [vmlinux] Error 1
This happens because there is nothing to descend us into the drivers/memory directory in the mpc85xx_defconfig. It wasn't selecting CONFIG_MEMORY. So we never built drivers/memory/fsl_ifc.o and so we have nothing to link the above symbols against.
Since the goal of the original commit was to relocate the driver to an arch independent location, it only makes sense to relocate the Kconfig setting there as well. But that alone won't fix the build failure; for that we ensure whoever selects FSL_IFC also selects MEMORY.
---
[v2: fix the mislocated FSL_IFC as per Scott's comment. It still
probably makes sense to go in via Greg's char-misc/char-misc-next (vs. powerpc-next) since that is where the regression was introduced.]
arch/powerpc/Kconfig | 4 ---- drivers/memory/Kconfig | 4 ++++ drivers/mtd/nand/Kconfig | 1 + 3 files changed, 5 insertions(+), 4 deletions(-)
arch/powerpc/Kconfig +0 -4
@@ -736,10 +736,6 @@ config FSL_LBC controller. Also contains some common code used by drivers for specific local bus peripherals. -config FSL_IFC - bool - depends on FSL_SOC - config FSL_GTM bool depends on PPC_83xx || QUICC_ENGINE || CPM2
drivers/memory/Kconfig +4 -0
@@ -50,4 +50,8 @@ config TEGRA30_MC analysis, especially for IOMMU/SMMU(System Memory Management Unit) module. +config FSL_IFC + bool + depends on FSL_SOC + endif
drivers/mtd/nand/Kconfig +1 -0
@@ -428,6 +428,7 @@ config MTD_NAND_FSL_IFC tristate "NAND support for Freescale IFC controller" depends on MTD_NAND && FSL_SOC select FSL_IFC + select MEMORY help Various Freescale chips e.g P1010, include a NAND Flash machine with built-in hardware ECC capabilities.
Signature · 1 line
1.8.5.2
Quoted 79 lines · Paul Gortmaker
commit
d2ae2e20fbdde5a65f3a5a153044ab1e5c53f7cc("driver/memory:Move Freescale IFC driver to a common driver") introduces this build regression into thempc85xx_defconfig:
drivers/built-in.o: In function `fsl_ifc_nand_remove':
drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference tofsl_ifc_ctrl_dev'drivers/built-in.o: In function `fsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference tofsl_ifc_ctrl_dev'drivers/built-in.o: In function `match_bank':
drivers/mtd/nand/fsl_ifc_nand.c:1013: undefined reference toconvert_ifc_address' drivers/built-in.o: In functionfsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1059: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1080: undefined reference tofsl_ifc_ctrl_dev'drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference tofsl_ifc_ctrl_dev'
make: *** [vmlinux] Error 1This happens because there is nothing to descend us into the
drivers/memorydirectory in thempc85xx_defconfig. It wasn't selectingCONFIG_MEMORY. So we never builtdrivers/memory/fsl_ifc.oand so we have nothing to link the above symbols against.Since the goal of the original commit was to relocate the driver to an arch independent location, it only makes sense to relocate the
Kconfigsetting there as well. But that alone won't fix the build failure; for that we ensure whoever selectsFSL_IFCalso selects MEMORY.Cc Prabhakar Kushwaha <[email protected]>Cc Scott Wood <[email protected]>Cc Arnd Bergmann <[email protected]>Cc David Woodhouse <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>---
[v2: fix the mislocated
FSL_IFCas per Scott's comment. It still
probably makes sense to go in via Greg's char-misc/char-misc-next (vs. powerpc-next) since that is where the regression was introduced.]arch/powerpc/Kconfig | 4 ---- drivers/memory/Kconfig | 4 ++++ drivers/mtd/nand/Kconfig | 1 + 3 files changed, 5 insertions(+), 4 deletions(-)arch/powerpc/Kconfig +0
-4@@ -736,10 +736,6 @@ config FSL_LBC controller. Also contains some common code used by drivers for specific local bus peripherals. -config FSL_IFC - bool - depends on FSL_SOC - config FSL_GTM bool depends on PPC_83xx || QUICC_ENGINE || CPM2drivers/memory/Kconfig +4
-0@@ -50,4 +50,8 @@ config TEGRA30_MC analysis, especially for IOMMU/SMMU(System Memory Management Unit) module. +config FSL_IFC + bool + depends on FSL_SOC + endifdrivers/mtd/nand/Kconfig +0
-0
drivers/mtd/nand/Kconfig config MTD_NAND_FSL_IFC · line 434
Quoted 7 lines
drivers/mtd/nand/Kconfig +1
-0@@ -428,6 +428,7 @@ config MTD_NAND_FSL_IFC tristate "NAND support for Freescale IFC controller" depends on MTD_NAND && FSL_SOC select FSL_IFC + select MEMORY help Various Freescale chips e.g P1010, include a NAND Flash machine with built-in hardware ECC capabilities.
Hi All,
I am not sure which version of patch is being picked here.
Latest version is v8 and it is a "patch set" and it do enable CONFIG_MEMORY in powerpc/configs
1. driver/memory:Move Freescale IFC driver to a common driver
http://patchwork.ozlabs.org/patch/315531/
2. powerpc/config: Enable memory driver
http://patchwork.ozlabs.org/patch/315532/
Regards,
Prabhakar
Quoted 91 lines · Prabhakar Kushwaha
Quoted 79 lines · Paul Gortmaker
commit
d2ae2e20fbdde5a65f3a5a153044ab1e5c53f7cc("driver/memory:Move Freescale IFC driver to a common driver") introduces this build regression into thempc85xx_defconfig:
drivers/built-in.o: In function `fsl_ifc_nand_remove':
drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference tofsl_ifc_ctrl_dev'drivers/built-in.o: In function `fsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference tofsl_ifc_ctrl_dev'drivers/built-in.o: In function `match_bank':
drivers/mtd/nand/fsl_ifc_nand.c:1013: undefined reference toconvert_ifc_address' drivers/built-in.o: In functionfsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1059: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1080: undefined reference tofsl_ifc_ctrl_dev'drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference tofsl_ifc_ctrl_dev'
make: *** [vmlinux] Error 1This happens because there is nothing to descend us into the
drivers/memorydirectory in thempc85xx_defconfig. It wasn't selectingCONFIG_MEMORY. So we never builtdrivers/memory/fsl_ifc.oand so we have nothing to link the above symbols against.Since the goal of the original commit was to relocate the driver to an arch independent location, it only makes sense to relocate the
Kconfigsetting there as well. But that alone won't fix the build failure; for that we ensure whoever selectsFSL_IFCalso selects MEMORY.Cc Prabhakar Kushwaha <[email protected]>Cc Scott Wood <[email protected]>Cc Arnd Bergmann <[email protected]>Cc David Woodhouse <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>---
[v2: fix the mislocated
FSL_IFCas per Scott's comment. It still
probably makes sense to go in via Greg's char-misc/char-misc-next (vs. powerpc-next) since that is where the regression was introduced.]arch/powerpc/Kconfig | 4 ---- drivers/memory/Kconfig | 4 ++++ drivers/mtd/nand/Kconfig | 1 + 3 files changed, 5 insertions(+), 4 deletions(-)arch/powerpc/Kconfig +0
-4@@ -736,10 +736,6 @@ config FSL_LBC controller. Also contains some common code used by drivers for specific local bus peripherals. -config FSL_IFC - bool - depends on FSL_SOC - config FSL_GTM bool depends on PPC_83xx || QUICC_ENGINE || CPM2drivers/memory/Kconfig +4
-0@@ -50,4 +50,8 @@ config TEGRA30_MC analysis, especially for IOMMU/SMMU(System Memory Management Unit) module. +config FSL_IFC + bool + depends on FSL_SOC + endifdrivers/mtd/nand/Kconfig +0
-0drivers/mtd/nand/Kconfig config MTD_NAND_FSL_IFC · line 434
Quoted 7 lines
drivers/mtd/nand/Kconfig +1
-0@@ -428,6 +428,7 @@ config MTD_NAND_FSL_IFC tristate "NAND support for Freescale IFC controller" depends on MTD_NAND && FSL_SOC select FSL_IFC + select MEMORY help Various Freescale chips e.g P1010, include a NAND Flash machine with built-in hardware ECC capabilities.Hi All,
Quoted 4 lines
I am not sure which version of patch is being picked here.
Latest version is v8 and it is a "patch set" and it do enable
CONFIG_MEMORYin powerpc/configs
It really doesn't matter what the latest version is, if the maintainer has already taken an earlier version and merged it. In that case one needs to work with the maintainer to determine whether they want a new version, or a delta/fixup commit on the old one.
Quoted 3 lines
1. driver/memory:Move Freescale IFC driver to a common driver
http://patchwork.ozlabs.org/patch/315531/
So, this has the Kconfig move part, but the one currently in char-misc does not. And it still needs the "select".
Quoted 3 lines
2. powerpc/config: Enable memory driver
http://patchwork.ozlabs.org/patch/315532/
Updating the defconfigs is fine, but incomplete in itself. You still need the IFC users to select MEMORY, otherwise you still introduce build failures for anyone else who chooses IFC but does not choose MEMORY.
In short, the char-misc tree still needs the v2 patch above.
Paul.
--
Quoted 8 lines
Regards,
Prabhakar
Quoted 92 lines · Paul Gortmaker
Quoted 91 lines · Prabhakar Kushwaha
Quoted 79 lines · Paul Gortmaker
commit
d2ae2e20fbdde5a65f3a5a153044ab1e5c53f7cc("driver/memory:Move Freescale IFC driver to a common driver") introduces this build regression into thempc85xx_defconfig:
drivers/built-in.o: In function `fsl_ifc_nand_remove':
drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference tofsl_ifc_ctrl_dev'drivers/built-in.o: In function `fsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference tofsl_ifc_ctrl_dev'drivers/built-in.o: In function `match_bank':
drivers/mtd/nand/fsl_ifc_nand.c:1013: undefined reference toconvert_ifc_address' drivers/built-in.o: In functionfsl_ifc_nand_probe':
drivers/mtd/nand/fsl_ifc_nand.c:1059: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1080: undefined reference tofsl_ifc_ctrl_dev'drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference tofsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference tofsl_ifc_ctrl_dev'
make: *** [vmlinux] Error 1This happens because there is nothing to descend us into the
drivers/memorydirectory in thempc85xx_defconfig. It wasn't selectingCONFIG_MEMORY. So we never builtdrivers/memory/fsl_ifc.oand so we have nothing to link the above symbols against.Since the goal of the original commit was to relocate the driver to an arch independent location, it only makes sense to relocate the
Kconfigsetting there as well. But that alone won't fix the build failure; for that we ensure whoever selectsFSL_IFCalso selects MEMORY.Cc Prabhakar Kushwaha <[email protected]>Cc Scott Wood <[email protected]>Cc Arnd Bergmann <[email protected]>Cc David Woodhouse <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>---
[v2: fix the mislocated
FSL_IFCas per Scott's comment. It still
probably makes sense to go in via Greg's char-misc/char-misc-next (vs. powerpc-next) since that is where the regression was introduced.]arch/powerpc/Kconfig | 4 ---- drivers/memory/Kconfig | 4 ++++ drivers/mtd/nand/Kconfig | 1 + 3 files changed, 5 insertions(+), 4 deletions(-)arch/powerpc/Kconfig +0
-4@@ -736,10 +736,6 @@ config FSL_LBC controller. Also contains some common code used by drivers for specific local bus peripherals. -config FSL_IFC - bool - depends on FSL_SOC - config FSL_GTM bool depends on PPC_83xx || QUICC_ENGINE || CPM2drivers/memory/Kconfig +4
-0@@ -50,4 +50,8 @@ config TEGRA30_MC analysis, especially for IOMMU/SMMU(System Memory Management Unit) module. +config FSL_IFC + bool + depends on FSL_SOC + endifdrivers/mtd/nand/Kconfig +0
-0drivers/mtd/nand/Kconfig config MTD_NAND_FSL_IFC · line 434
Quoted 7 lines
drivers/mtd/nand/Kconfig +1
-0@@ -428,6 +428,7 @@ config MTD_NAND_FSL_IFC tristate "NAND support for Freescale IFC controller" depends on MTD_NAND && FSL_SOC select FSL_IFC + select MEMORY help Various Freescale chips e.g P1010, include a NAND Flash machine with built-in hardware ECC capabilities.Hi All,
I am not sure which version of patch is being picked here.
Quoted 7 lines
Quoted 2 lines
Latest version is v8 and it is a "patch set" and it do enable
CONFIG_MEMORYin powerpc/configsIt really doesn't matter what the latest version is, if the maintainer has already taken an earlier version and merged it. In that case one needs to work with the maintainer to determine whether they want a new version, or a delta/fixup commit on the old one.
I think, I got the reason of this issue.
I thought this patch will be picked by powerpc.git and updated version were sent on linuxppc-dev mail list after initial version review on both powerpc and linux-kernel mailing list. It should have sent on both the list "always". A learning for future :)
I am OK with the current patch and modification because it full fill my requirements. I will sent separate patch to fix other things.
Quoted 5 lines
Quoted 2 lines
1. driver/memory:Move Freescale IFC driver to a common driver
http://patchwork.ozlabs.org/patch/315531/So, this has the
Kconfigmove part, but the one currently in char-misc does not. And it still needs the "select".
Quoted 10 lines
Quoted 2 lines
2. powerpc/config: Enable memory driver
http://patchwork.ozlabs.org/patch/315532/Updating the defconfigs is fine, but incomplete in itself. You still need the IFC users to select MEMORY, otherwise you still introduce build failures for anyone else who chooses IFC but does not choose MEMORY.
In short, the char-misc tree still needs the v2 patch above.
Yes, this patch still required.
Thanks,
Prabhakar