power_supply: Introduce power supply charging driver
Subsystems (2)
v6 cover power_supply: Introduce power supply charging driver
v1: introduced feature as a framework within power supply class driver with
separate files for battid framework and charging framework
v2: fixed review comments, moved macros and inline functions to power_supply.h
v3: moved the feature as a separate driver, combined battid framework and
charging framework inside the power supply charging driver. Moved charger specific properties to power_supply_charger.h and plugged the driver with power supply subsystem using power_supply_notifier introduced in my previous patch. Also a sample charger chip driver (bq24261) patch added to give more idea on the psy charging driver usage
v4: Fixed review comments, no major design changes.
v5: Fixed makefile inconsistencies, removed unused pdata callbacks
v6: Fixed nested loops, commenting style
The Power Supply charging driver connects multiple subsystems
to do charging in a generic way. The subsystems involves power_supply, thermal and battery communication subsystems (1wire).With this the charging is handled in a generic way.
The driver makes use of different new features - Battery Identification interfaces, pluggable charging algorithms, charger cable arbitrations etc. The patch also introduces generic interface for charger cable notifications. Charger cable events and capabilities can be notified using the generic power_supply_notifier chain.
Overall this driver removes the charging logic out of the charger chip driver and the charger chip driver can just listen to the request from the power supply charging driver to set the charger properties. This can be implemented by exposing get_property and set property callbacks.
Jenny TC (4):
power_supply: Add inlmt,iterm, min/max temp props
power_supply: Introduce generic psy charging driver
power_supply: Introduce PSE compliant algorithm
power_supply: bq24261 charger driver
Documentation/power/power_supply_charger.txt | 353 +++++++ Documentation/power/power_supply_class.txt | 6 + drivers/power/Kconfig | 31 + drivers/power/Makefile | 3 + drivers/power/bq24261-charger.c | 1350 ++++++++++++++++++++++++++ drivers/power/charging_algo_pse.c | 204 ++++ drivers/power/power_supply_charger.c | 1186 ++++++++++++++++++++++ drivers/power/power_supply_charger.h | 218 +++++ drivers/power/power_supply_core.c | 3 + drivers/power/power_supply_sysfs.c | 4 + include/linux/power/bq24261-charger.h | 25 + include/linux/power/power_supply_charger.h | 235 +++++ include/linux/power_supply.h | 164 ++++ 13 files changed, 3782 insertions(+) create mode 100644 Documentation/power/power_supply_charger.txt create mode 100644 drivers/power/bq24261-charger.c create mode 100644 drivers/power/charging_algo_pse.c create mode 100644 drivers/power/power_supply_charger.c create mode 100644 drivers/power/power_supply_charger.h create mode 100644 include/linux/power/bq24261-charger.h create mode 100644 include/linux/power/power_supply_charger.h
Signature · 1 line
1.7.9.5
PATCH v6 1/4 power_supply: Add inlmt,iterm, min/max temp props
Add new power supply properties for input current, charge termination current, min and max temperature
POWER_SUPPLY_PROP_TEMP_MIN - minimum operatable temperature POWER_SUPPLY_PROP_TEMP_MAX - maximum operatable temperature
POWER_SUPPLY_PROP_INLMT - input current limit programmed by charger. Indicates the input current for a charging source.
POWER_SUPPLY_PROP_CHARGE_TERM_CUR - Charge termination current used to detect the end of charge condition
--- Documentation/power/power_supply_class.txt | 6 ++++++ drivers/power/power_supply_sysfs.c | 4 ++++ include/linux/power_supply.h | 4 ++++ 3 files changed, 14 insertions(+)
Documentation/power/power_supply_class.txt +6 -0
@@ -118,6 +118,10 @@ relative, time-based measurements. CONSTANT_CHARGE_CURRENT - constant charge current programmed by charger. CONSTANT_CHARGE_CURRENT_MAX - maximum charge current supported by the power supply object. +INPUT_CURRENT_LIMIT - input current limit programmed by charger. Indicates +the current drawn from a charging source. +CHARGE_TERM_CURRENT - Charge termination current used to detect the end of charge +condition. CONSTANT_CHARGE_VOLTAGE - constant charge voltage programmed by charger. CONSTANT_CHARGE_VOLTAGE_MAX - maximum charge voltage supported by the
@@ -140,6 +144,8 @@ TEMP_ALERT_MAX - maximum battery temperature alert. TEMP_AMBIENT - ambient temperature. TEMP_AMBIENT_ALERT_MIN - minimum ambient temperature alert. TEMP_AMBIENT_ALERT_MAX - maximum ambient temperature alert. +TEMP_MIN - minimum operatable temperature +TEMP_MAX - maximum operatable temperature TIME_TO_EMPTY - seconds left for battery to be considered empty (i.e. while battery powers a load)
drivers/power/power_supply_sysfs.c +4 -0
@@ -167,6 +167,7 @@ static struct device_attribute power_supply_attrs[] = {POWER_SUPPLY_ATTR (constant_charge_voltage_max),POWER_SUPPLY_ATTR (charge_control_limit),POWER_SUPPLY_ATTR (charge_control_limit_max), +POWER_SUPPLY_ATTR (input_current_limit),POWER_SUPPLY_ATTR (energy_full_design),POWER_SUPPLY_ATTR (energy_empty_design), POWER_SUPPLY_ATTR(energy_full),
@@ -178,6 +179,8 @@ static struct device_attribute power_supply_attrs[] = {POWER_SUPPLY_ATTR (capacity_alert_max),POWER_SUPPLY_ATTR (capacity_level),POWER_SUPPLY_ATTR (temp), +POWER_SUPPLY_ATTR (temp_max), +POWER_SUPPLY_ATTR (temp_min),POWER_SUPPLY_ATTR (temp_alert_min),POWER_SUPPLY_ATTR (temp_alert_max), POWER_SUPPLY_ATTR(temp_ambient),
@@ -189,6 +192,7 @@ static struct device_attribute power_supply_attrs[] = {POWER_SUPPLY_ATTR (time_to_full_avg),POWER_SUPPLY_ATTR (type),POWER_SUPPLY_ATTR (scope), +POWER_SUPPLY_ATTR (charge_term_current),/* Properties of type `const char *' */ POWER_SUPPLY_ATTR (model_name), POWER_SUPPLY_ATTR(manufacturer),
include/linux/power_supply.h +4 -0
@@ -120,6 +120,7 @@ enum power_supply_property {POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX ,POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT ,POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX , +POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT ,POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN ,POWER_SUPPLY_PROP_ENERGY_EMPTY_DESIGN , POWER_SUPPLY_PROP_ENERGY_FULL,
@@ -131,6 +132,8 @@ enum power_supply_property {POWER_SUPPLY_PROP_CAPACITY_ALERT_MAX ,/* in percents! */ POWER_SUPPLY_PROP_CAPACITY_LEVEL ,POWER_SUPPLY_PROP_TEMP , +POWER_SUPPLY_PROP_TEMP_MAX , +POWER_SUPPLY_PROP_TEMP_MIN ,POWER_SUPPLY_PROP_TEMP_ALERT_MIN ,POWER_SUPPLY_PROP_TEMP_ALERT_MAX , POWER_SUPPLY_PROP_TEMP_AMBIENT,
@@ -142,6 +145,7 @@ enum power_supply_property {POWER_SUPPLY_PROP_TIME_TO_FULL_AVG ,POWER_SUPPLY_PROP_TYPE ,/* use power_supply.type instead */ POWER_SUPPLY_PROP_SCOPE , +POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT ,/* Properties of type `const char *' */ POWER_SUPPLY_PROP_MODEL_NAME , POWER_SUPPLY_PROP_MANUFACTURER,
Signature · 1 line
1.7.9.5
PATCH v6 2/4 power_supply: Introduce generic psy charging driver
In reply to Jenny TCThe Power Supply charging driver connects multiple subsystems
to do charging in a generic way. The subsystems involves power_supply, thermal and battery communication subsystems (1wire).With this the charging is handled in a generic way.
The driver makes use of different new features - Battery Identification interfaces, pluggable charging algorithms, charger cable arbitrations etc. The patch also introduces generic interface for charger cable notifications. Charger cable events and capabilities can be notified using the generic power_supply_notifier chain.
Overall this driver removes the charging logic out of the charger chip driver and the charger chip driver can just listen to the request from the power supply charging driver to set the charger properties. This can be implemented by exposing get_property and set property callbacks.
--- Documentation/power/power_supply_charger.txt | 353 ++++++++ drivers/power/Kconfig | 8 + drivers/power/Makefile | 1 + drivers/power/power_supply_charger.c | 1186 ++++++++++++++++++++++++++ drivers/power/power_supply_charger.h | 218 +++++ drivers/power/power_supply_core.c | 3 + include/linux/power/power_supply_charger.h | 187 ++++ include/linux/power_supply.h | 160 ++++ 8 files changed, 2116 insertions(+) create mode 100644 Documentation/power/power_supply_charger.txt create mode 100644 drivers/power/power_supply_charger.c create mode 100644 drivers/power/power_supply_charger.h create mode 100644 include/linux/power/power_supply_charger.h
Documentation/power/power_supply_charger.txt new file +353 -0
@@ -0,0 +1,353 @@ +1. Introduction +=============== + +The Power Supply charging driver connects multiple subsystems +to do charging in a generic way. The subsystems involves power_supply, +thermal and battery communication subsystems (1wire).With this the charging is +handled in a generic way by plugging the driver to power supply subsystem. + +The driver introduces different new features - Battery Identification +interfaces, pluggable charging algorithms, charger cable arbitrations etc. + +In existing driver implementations the charging is done based on the static +battery characteristics. This is done at the boot time by passing the battery +properties (max_voltage, capacity) etc. as a platform data to the +charger/battery driver. But new generation high volt batteries needs to be +identified dynamically to do charging in a safe manner. The batteries are +coming with different communication protocols. It become necessary to +communicate with battery and identify it's charging profiles before setup +charging. + +Also the charging algorithms can vary based on the battery characteristics +and the platform characteristics. To handle charging in a generic way it's +necessary to support pluggable charging algorithms. Power Supply Charging +driver selects algorithms based on the type of battery charging profile. +This is a simple binding and can be improved later. This may be improved to +select the algorithms based on the platform requirements. Also we can extend +this driver to plug algorithms from the user space. + +The driver also introduces the charger cable arbitration. A charger may +supports multiple cables, but it may not be able to charge with multiple +cables at a time (USB/AC/Wireless etc.). The arbitration logic inside the +driver selects the cable based on it's capabilities and the maximum +charge current the platform can support. + +Also the driver exposes features to control charging on different platform +states. One such feature is thermal. The driver handles the thermal +throttling requests for charging and control charging based on the thermal +subsystem requirements. + +Overall this driver removes the charging logic out of the charger chip driver +and the charger chip driver can just listen to the request from the power +supply charging driver to set the charger properties. This can be implemented +by exposing get_property and set property callbacks. + +2. Reading Battery charging profile +=================================== + +Power Supply charging driver expose APIs to retrieve battery profile of a +battery. The battery profile can be read by battery identification driver which +may be 1wire/I2C/SFI driver. Battery identification driver can register the +battery profile with the power supply charging driver using the API +psy_battery_prop_changed(). The driver also exposes API +psy_get_battery_prop() to retrieve the battery profile which can be +used by power supply drivers to setup the charging. Also drivers +can register for battery removal/insertion notifications using +power_supply_reg_notifier() + +3. Use Charging Driver to setup charging +=========================================== + +* Register the driver with the power_supply class +* Register the driver with the power supply charging driver +* Expose set_property and get_property functions so that charging + framework can control the charging + +3.1 Registering charger chip driver with power supply charging driver +================================================================ + +struct power_supply_class psy_usb; +struct power_supply_charger psyc_usb; + +/* register with power supply subsystem */ +psy_usb.name = DEV_NAME; +psy_usb.type = POWER_SUPPLY_TYPE_USB; + +/* pointer to power supply property structure */ +psy_usb.properties = &psy_usb_props; +psy_usb.num_properties = ARRAY_SIZE(psy_usb_props); + +/* pointer to power supply get property function */ +psy_usb.get_property = psy_usb_get_property; + +/* pointer to power supply set property function */ +psy_usb.set_property = psy_usb_set_property; + +/* pointer to the supplied_to argument to indicate the batteries + to which this charger is supplying power */ +psy_usb.supplied_to = supplied_to; +psy_usb.num_supplicants = num_supplicants; + +/* register with power_supply subsystem */ +power_supply_register(device, &psy_usb); + +/* Register with power supply charging driver */ + +/* Assign psy pointer to power supply charger */ +psyc_usb.psy = &chip->psy_usb; + +/* define supported cable types for this driver */ +psyc_usb.supported_cables = POWER_SUPPLY_CHARGER_TYPE_USB; + +/* pointer to power supply charger get property function */ +psyc_usb.get_property = bq24261_usb_psyc_get_property; + +/* pointer to power supply charger set property function */ +psyc_usb.set_property = bq24261_usb_psyc_set_property; + +/* pointer to throttle states */ +psyc_usb.throttle_states = chip->pdata->throttle_states; + +/* Number of throttle states */ +psyc_usb.num_throttle_states = chip->pdata->num_throttle_states; + +/*register with power supply charging */ +power_supply_register_charger(&chip->psyc_usb); + +3.2 Properties exposed to power supply class driver +================================================== +* POWER_SUPPLY_PROP_ONLINE + * Read access using get_property_function + * Returns the online property set using the set_property + function + * Write access using set_property function + * Expose the value through get_property_function. +* POWER_SUPPLY_PROP_PRESENT + * Read access using get_property_function + * Returns the present property set using the set_property + function + * Write access using set_property function + * Expose the value through get_property_function. +* POWER_SUPPLY_PROP_HEALTH + * Read access using get_property_function + * Returns charger health +* POWER_SUPPLY_PROP_TYPE + * Read access using power_supply structure + * Returns charger type +* POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT + * Read access using get property + * Returns the present charge control limit + * Write access using set property + * Set charge control limit. + * Action: Driver is not expected to take any actions on this. + Instead need to expose this on the read interface. + Charging framework process this and notifies the + charging parameters accordingly. +* POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX + * Read access using get property + * Returns the maximum charge control limit +* POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT + * Read access using get property + * Returns the input current limit passed by set_property + function + * Default value : 0 + * Write access using set property + * Set input current limit + * Action : Write h/w register to set the input current limit + based on the value +* POWER_SUPPLY_PROP_CHARGE_CURRENT + * Read access using get property + * Returns charge current passed by set_property function + * Default value : 0 + * Write access using set property + * Set charge current + * Action : Write h/w register to set the charge current based + on the value +* POWER_SUPPLY_PROP_CHARGE_VOLTAGE + * Read access using get property + * Returns charge voltage passed by set_property function + * Default value: 0 + * Write access using set property + * Set charge voltage + * Action : Write h/w register to set the charge voltage based + on the value +* POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT + * Read access using get property + * Returns charge termination current passed by set_property + function + * Default value : 0 + * Write access using set property + * Set charge termination current + * Action : Write h/w register to set the charge termination + current + based on the value +* POWER_SUPPLY_PROP_TEMP_MIN + * Read access using get property + * Returns minimum charging temperature passed by set_property + * Default value : Platform dependant + * Write access using set_property + * Set Minimum charging temperature + * Action : Write h/w register to set the minimum charging + temperature based on the value +* POWER_SUPPLY_PROP_TEMP_MAX + * Write access using set_property + * Set Maximum charging temperature + * Action : Write h/w register to set the maximum charging + temperature based on the value + * Read access using get property + * Returns maximum charging temperature passed by set_property + * Default value : Platform dependent +* POWER_SUPPLY_PROP_MAX_CHARGE_CURRENT + * Read access using get property + * Returns maximum charging current passed by set_property + * Default value : Platform dependent + * Write access using set_property + * Set Maximum charging current + * Action: Configure safety charging registers if any. If no h/w + actions expected, report the value on the + get_property interface. +* POWER_SUPPLY_PROP_MAX_CHARGE_VOLTAGE + * Read access using get property + * Returns maximum charging current passed by set_property + * Default value : Platform dependent + * Write access using set_property + * Set Maximum charging voltage + * Action: Configure safety charging registers if any. If not, + no actions expected for this. + +3.3 Properties exposed to power supply charging driver +===================================================== + +* POWER_SUPPLY_CHARGER_PROP_ENABLE_CHARGING + * Write access using set_property + * Enable/Disable charging. Charger supplies power to platform, + but charging is disabled + * Action: Configure charger chip registers to enable/disable + charging. Writing 0, disables charging, writing 1 enables + charging +* POWER_SUPPLY_CHARGER_PROP_ENABLE_CHARGER + * Write access using set_property + * Enable/Disable charger. Charger doesn't supply power to + platform or battery and battery start to discharge. + * Action: Configure charger chip registers to enable/disable + charger. Writing 0 disables charger, writing 1 enables + charger +* POWER_SUPPLY_CHARGER_PROP_CABLE_TYPE + * Write access using set_property + * Set charger cable type. + * Action: Report power supply type based on cable type +* POWER_SUPPLY_CHARGER_PROP_RESET_WDT + * Write access using set_property + * Reset charger Watch Dog Timer + * Action: Reset charger Watch Dog Timer. +* POWER_SUPPLY_CHARGER_PROP_PRIORITY + * Read access using get property + * Expose charger driver/chips priority if platform has multiple + charger chip/drivers. + +3.4 Throttling data configuration +============================= +Power supply charging driver can take actions for Thermal throttling requests. +Power supply core sends event PSY_EVENT_THROTTLE on power_supply_notifier +chain. Power supply charging driver handle this event and takes throttling +actions as in the throttling configuration structure. The throttling +configuration structure has the following format: + +struct psy_throttle_state { + enum psy_throttle_action throttle_action; + unsigned throttle_val; +}; + +enum psy_throttle_action { + /* Disable charger, charger doesn't supply VSYS */ + PSY_THROTTLE_DISABLE_CHARGER = 0, + + /* Disable charging, charger would supply VSYS */ + PSY_THROTTLE_DISABLE_CHARGING, + + /* Throttle charge current */ + PSY_THROTTLE_CC_LIMIT, + + /* Throttle input current limit */ + PSY_THROTTLE_INPUT_LIMIT, +}; + +Throttling configuration example: + +struct psy_throttle_state my_throttle_states[] = { + + /* Level 0: Limit charge current to 1500mA. Normal Level */ + { + .throttle_action = PSY_THROTTLE_CC_LIMIT, + .throttle_val = 1500, + }, + + /* Level 1: Limit charge current to 500mA */ + { + .throttle_action = PSY_THROTTLE_CC_LIMIT, + .throttle_val = 500, + }, + + /* + * Level 2: Disable charging: Stop charging, charger supply power to + * platform. + */ + { + .throttle_action = PSY_THROTTLE_DISABLE_CHARGING, + }, + + /* Level 3: Disable charger: Battery start discharging */ + { + .throttle_action = PSY_THROTTLE_DISABLE_CHARGER, + }, + +}; + +4. Charger Cable notifications +============================== + +Charger cables can have different charging capabilities (current) depending on +platform and cable type. The cable provider drivers detect and identify the +cable types and notifies the power supply subsystem by posting an event +PSY_EVENT_CABLE on the power_supply_notifier chain. The event notification +should have a property structure pointer which indicates the cable type, event +and capability. + +struct psy_cable_props cable; +cable.chrg_evt = PSY_CHARGER_CABLE_EVENT_CONNECT; +cable.chrg_type = PSY_CHARGER_CABLE_TYPE_USB_DCP; +cable.ma = 1500; + +atomic_notifier_call_chain(&power_supply_notifier, + PSY_EVENT_CABLE, &cable); + +Power supply charging driver process this event and takes actions to setup +charging. + +5. Registering new charging algorithm +=================================== +Power supply charging driver supports pluggable charging algorithms. Charging +algorithms processes charging profile and/or applies different logic (pulse +charging/fast charging/relaxed charging) to decide the charging parameters (CC +and CV). + +* Populate algorithm structure + struct psy_charging_algo new_algo; + /* populate the type charging profile the algorithm handles */ + pse_algo.chrg_prof_type = PSY_CHRG_PROF_PSE; + pse_algo.name = "my_algo"; + /* callback function to retrieve CC and CV */ + pse_algo.get_next_cc_cv = my_algo_get_next_cc_cv; + /* callback function to retreive battery thresholds */ + pse_algo.get_batt_thresholds = my_algo_get_bat_thresholds; + /* register charging algorithm */ + power_supply_register_charging_algo(&pse_algo); + +When the type of charging profile reported by battery and algorithm matches, +the algorithm will be invoked to get the charging parameters. + +6. TODO +======= +* Replace static cable array with dynamic list +* Implement safety timer and watch dog timer features with more monitoring +* Move charge full detection logic to psy charging driver from algorithm driver
drivers/power/Kconfig +8 -0
@@ -14,6 +14,14 @@ config POWER_SUPPLY_DEBUG Say Y here to enable debugging messages for power supply class and drivers. +config POWER_SUPPLY_CHARGER + bool "Power Supply Charger" + help + Say Y here to enable the power supply charging control driver. Charging + control supports charging in a generic way. This allows the charger + drivers to keep the charging logic outside and the charger driver + just need to abstract the charger hardware. + config PDA_POWER tristate "Generic PDA/phone power driver" depends on !S390
drivers/power/Makefile +1 -0
@@ -7,6 +7,7 @@ power_supply-$(CONFIG_LEDS_TRIGGERS) += power_supply_leds.o obj-$(CONFIG_POWER_SUPPLY) += power_supply.o obj-$(CONFIG_GENERIC_ADC_BATTERY) += generic-adc-battery.o +obj-$(CONFIG_POWER_SUPPLY_CHARGER) += power_supply_charger.o obj-$(CONFIG_PDA_POWER) += pda_power.o obj-$(CONFIG_APM_POWER) += apm_power.o obj-$(CONFIG_MAX8925_POWER) += max8925_power.o
drivers/power/power_supply_charger.c new file +1186 -0
1,186 lines not on this page · raw message
drivers/power/power_supply_charger.h new file +218 -0
218 lines not on this page · raw message
drivers/power/power_supply_core.c +3 -0
@@ -483,6 +483,9 @@ static int ps_set_cur_charge_cntl_limit(struct thermal_cooling_device *tcd, ret = psy->set_property (psy,POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT , &val); +atomic_notifier_call_chain (&power_supply_notifier, +PSY_EVENT_THROTTLE , psy); +return ret; }
include/linux/power/power_supply_charger.h new file +187 -0
187 lines not on this page · raw message
include/linux/power_supply.h +160 -0
170 lines not on this page · raw message
Signature · 1 line
1.7.9.5
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
include/linux/power/power_supply_charger.h line 8
Quoted 4 lines · Jenny TC
+++
b/include/linux/power/power_supply_charger.hinclude/linux/power/power_supply_charger.h new file +2
-0+#define MAX_CUR_VOLT_SAMPLES 3 +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ)
Why are things defined in Jiffies like this insead of seconds, milliseconds etc? This will vary with the current operating frequency of the system, why should physical measurements do that?
include/linux/power/power_supply_charger.h line 15
Quoted 6 lines
include/linux/power/power_supply_charger.h new file +6
-0+/* +* Define a TTL for some properties to optimize the frequency of +* algorithm calls. This can be used by properties which will be changed +* very frequently (e.g. Current, Voltage..) +*/ +#define PROP_TTL (HZ*10)
Same comment.
Quoted 13 lines
include/linux/power/power_supply_charger.h new file +13
-0+enum psy_charger_cable_event { +PSY_CHARGER_CABLE_EVENT_DISCONNECT =0 , +PSY_CHARGER_CABLE_EVENT_CONNECT , +PSY_CHARGER_CABLE_EVENT_UPDATE , +PSY_CHARGER_CABLE_EVENT_RESUME , +PSY_CHARGER_CABLE_EVENT_SUSPEND , +}; + +enum psy_charger_cable_type { +PSY_CHARGER_CABLE_TYPE_NONE =0 , +PSY_CHARGER_CABLE_TYPE_USB_SDP =1 <<0 , +PSY_CHARGER_CABLE_TYPE_USB_DCP =1 <<1 , +PSY_CHARGER_CABLE_TYPE_USB_CDP =1 <<2 ,
include/linux/power/power_supply_charger.h line 38
Quoted 10 lines
include/linux/power/power_supply_charger.h new file +10
-0+PSY_CHARGER_CABLE_TYPE_USB_ACA =1 <<3 , +PSY_CHARGER_CABLE_TYPE_AC =1 <<4 , +PSY_CHARGER_CABLE_TYPE_ACA_DOCK =1 <<5 , +PSY_CHARGER_CABLE_TYPE_ACA_A =1 <<6 , +PSY_CHARGER_CABLE_TYPE_ACA_B =1 <<7 , +PSY_CHARGER_CABLE_TYPE_ACA_C =1 <<8 , +PSY_CHARGER_CABLE_TYPE_SE1 =1 <<9 , +PSY_CHARGER_CABLE_TYPE_MHL =1 <<10 , + PSY_CHARGER_CABLE_TYPE_B_DEVICE = 1 << 11, +};
Why is this even an enum? It is clearly bitfields. I would just:
#include <linux/bitops.h>
#define PSY_CHARGER_CABLE_TYPE_NONE 0x0
#define PSY_CHARGER_CABLE_TYPE_USB_SDP BIT(0)
#define PSY_CHARGER_CABLE_TYPE_USB_DCP BIT(1)
(etc)
include/linux/power/power_supply_charger.h line 76
Quoted 4 lines
include/linux/power/power_supply_charger.h new file +4
-0+enum { +POWER_SUPPLY_BATTERY_REMOVED =0 , +POWER_SUPPLY_BATTERY_INSERTED , +};
Why is this enum anonymous? Does that mean the code just casts the enum to an int?
include/linux/power/power_supply_charger.h line 43
Quoted 5 lines
include/linux/power/power_supply_charger.h new file +5
-0+ +struct psy_cable_props { +enum psy_charger_cable_event chrg_evt; +enum psy_charger_cable_type chrg_type; +unsigned int mA;/* input current limit */
You are naming a struct member after a unit, can it not be given a better name like "current_limit" and write in the kerneldoc (not a comment) that it is stated in mA?
(...)
include/linux/power/power_supply_charger.h line 96
Quoted 9 lines
include/linux/power/power_supply_charger.h new file +9
-0+struct psy_batt_props { +struct list_head node; +const char *name; +long voltage_now;/* mV */ +long voltage_now_cache[MAX_CUR_VOLT_SAMPLES ];/* mV */ +long current_now;/* mA */ +long current_now_cache[MAX_CUR_VOLT_SAMPLES ];/* mV */ +int temperature;/* Degree Celsius */ +long status;/* POWER_SUPPLY_STATUS_* */
I don't understand these comments... Do you mean you are using the enums from <linux/power_supply.h>?
Would it not be better to give those enums a real name (as a separate patch) and then use:
enum power_supply_status status;
here? That would be helpful methinks.
include/linux/power/power_supply_charger.h line 99
Quoted 3 lines
include/linux/power/power_supply_charger.h new file +3
-0+unsigned long long tstamp; +enum psy_algo_stat algo_stat; +int health;/* POWER_SUPPLY_HEALTH_* */
Same thing.
include/linux/power/power_supply_charger.h line 109
Quoted 7 lines
include/linux/power/power_supply_charger.h new file +7
-0+struct psy_charger_props { +struct list_head node; +struct power_supply_charger *psyc; +const char *name; +bool present; +bool is_charging; +int health;/* POWER_SUPPLY_HEALTH_* */
Same thing.
include/linux/power/power_supply_charger.h line 113
Quoted 4 lines
include/linux/power/power_supply_charger.h new file +4
-0+bool online; +unsigned long cable; +unsigned long tstamp; +};
Kerneldoc this struct...
include/linux/power/power_supply_charger.h line 119
Quoted 6 lines
include/linux/power/power_supply_charger.h new file +6
-0+ +struct psy_batt_thresholds { +int temp_min;/* Degree Celsius */ +int temp_max;/* Degree Celsius */ +unsigned int iterm;/* mA */ +};
Kerneldoc this struct.
Quoted 4 lines
include/linux/power/power_supply_charger.h new file +4
-0+struct power_supply_charger { +struct power_supply *psy; +struct psy_throttle_state *throttle_states; +size_t num_throttle_states;
include/linux/power/power_supply_charger.h line 142
Quoted 10 lines
include/linux/power/power_supply_charger.h new file +10
-0+unsigned long supported_cables; +int (*get_property)(struct power_supply_charger *psyc, +enum power_supply_charger_property psp, +union power_supply_propval *val); +int (*set_property)(struct power_supply_charger *psyc, +enum power_supply_charger_property psp, +const union power_supply_propval *val); +int (*property_is_writeable)(struct power_supply_charger *psyc, +enum power_supply_charger_property psp); +};
Kerneldoc this vtable struct.
include/linux/power/power_supply_charger.h line 153
Quoted 10 lines
include/linux/power/power_supply_charger.h new file +10
-0+struct psy_charging_algo { +struct list_head node; +unsigned int chrg_prof_type; +char *name; +enum psy_algo_stat (*get_next_cc_cv)(struct psy_batt_props , +struct psy_batt_chrg_prof ,unsigned long *cc, +unsigned long *cv); +int (*get_batt_thresholds)(struct psy_batt_chrg_prof , +struct psy_batt_thresholds *bat_thr); +};
And this.
Quoted 12 lines
include/linux/power/power_supply_charger.h new file +12
-0+/* power_supply_charger functions */ + +#ifdef CONFIG_POWER_SUPPLY_CHARGER + +extern int power_supply_register_charger (struct power_supply_charger *psyc); +extern int power_supply_unregister_charger (struct power_supply_charger *psyc); +extern int power_supply_register_charging_algo (struct psy_charging_algo *); +extern int power_supply_unregister_charging_algo (struct psy_charging_algo *); +extern int psy_get_battery_prop (struct psy_batt_chrg_prof *batt_prop); +extern void psy_battery_prop_changed (int battery_conn_stat, +struct psy_batt_chrg_prof *batt_prop); +
include/linux/power/power_supply_charger.h line 177
Quoted 10 lines
include/linux/power/power_supply_charger.h new file +10
-0+#else + +static int power_supply_register_charger (struct power_supply_charger *psyc) +{return 0 ; } +static int power_supply_unregister_charger (struct power_supply_charger *psyc) +{return 0 ; } +static int power_supply_register_charging_algo (struct psy_charging_algo *algo) +{return 0 ; } +static int power_supply_unregister_charging_algo (struct psy_charging_algo *algo) +{return 0 ; }
Why do these return 0? Should they not just fail if the power supply charger support is not compiled in, like return -EINVAL etc?
Sorry for just making some random review of the header files, but this caught my attention and I couldn't resist.
Yours,
Linus Walleij
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Quoted 10 lines · Linus Walleij
include/linux/power/power_supply_charger.h line 8
Quoted 4 lines · Jenny TC
+++
b/include/linux/power/power_supply_charger.hinclude/linux/power/power_supply_charger.h new file +2
-0+#define MAX_CUR_VOLT_SAMPLES 3 +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ)Why are things defined in Jiffies like this insead of seconds, milliseconds etc? This will vary with the current operating frequency of the system, why should physical measurements do that?
Is it fine if I use msecs_to_jiffies(30000)?
Quoted 26 lines
Quoted 13 lines
include/linux/power/power_supply_charger.h new file +13
-0+enum psy_charger_cable_event { +PSY_CHARGER_CABLE_EVENT_DISCONNECT =0 , +PSY_CHARGER_CABLE_EVENT_CONNECT , +PSY_CHARGER_CABLE_EVENT_UPDATE , +PSY_CHARGER_CABLE_EVENT_RESUME , +PSY_CHARGER_CABLE_EVENT_SUSPEND , +}; + +enum psy_charger_cable_type { +PSY_CHARGER_CABLE_TYPE_NONE =0 , +PSY_CHARGER_CABLE_TYPE_USB_SDP =1 <<0 , +PSY_CHARGER_CABLE_TYPE_USB_DCP =1 <<1 , +PSY_CHARGER_CABLE_TYPE_USB_CDP =1 <<2 ,include/linux/power/power_supply_charger.h line 38
Quoted 10 lines
include/linux/power/power_supply_charger.h new file +10
-0+PSY_CHARGER_CABLE_TYPE_USB_ACA =1 <<3 , +PSY_CHARGER_CABLE_TYPE_AC =1 <<4 , +PSY_CHARGER_CABLE_TYPE_ACA_DOCK =1 <<5 , +PSY_CHARGER_CABLE_TYPE_ACA_A =1 <<6 , +PSY_CHARGER_CABLE_TYPE_ACA_B =1 <<7 , +PSY_CHARGER_CABLE_TYPE_ACA_C =1 <<8 , +PSY_CHARGER_CABLE_TYPE_SE1 =1 <<9 , +PSY_CHARGER_CABLE_TYPE_MHL =1 <<10 , + PSY_CHARGER_CABLE_TYPE_B_DEVICE = 1 << 11, +};Why is this even an enum? It is clearly bitfields. I would just:
Quoted 6 lines
#include <
linux/bitops.h>#define
PSY_CHARGER_CABLE_TYPE_NONE0x0
#definePSY_CHARGER_CABLE_TYPE_USB_SDPBIT(0)
#definePSY_CHARGER_CABLE_TYPE_USB_DCPBIT(1)
(etc)
This is to ensure type checks when the cable types are handled, #defines will not help in type checks.
Quoted 8 lines
include/linux/power/power_supply_charger.h line 76
Quoted 5 lines
include/linux/power/power_supply_charger.h new file +4
-0+enum { +POWER_SUPPLY_BATTERY_REMOVED =0 , +POWER_SUPPLY_BATTERY_INSERTED , +};Why is this enum anonymous? Does that mean the code just casts the enum to an int?
OK.I'll name the enum.
Quoted 10 lines
include/linux/power/power_supply_charger.h line 43
Quoted 6 lines
include/linux/power/power_supply_charger.h new file +5
-0+ +struct psy_cable_props { +enum psy_charger_cable_event chrg_evt; +enum psy_charger_cable_type chrg_type; +unsigned int mA;/* input current limit */ You are naming a struct member after a unit, can it not be given a better name like "
current_limit" and write in the kerneldoc (not a comment) that it is stated in mA?
I'll change the variable name in next patch set.
Quoted 13 lines
include/linux/power/power_supply_charger.h line 96
Quoted 9 lines
include/linux/power/power_supply_charger.h new file +9
-0+struct psy_batt_props { +struct list_head node; +const char *name; +long voltage_now;/* mV */ +long voltage_now_cache[MAX_CUR_VOLT_SAMPLES ];/* mV */ +long current_now;/* mA */ +long current_now_cache[MAX_CUR_VOLT_SAMPLES ];/* mV */ +int temperature;/* Degree Celsius */ +long status;/* POWER_SUPPLY_STATUS_* */ I don't understand these comments... Do you mean you are using the enums from <
linux/power_supply.h>?
Quoted 6 lines
Would it not be better to give those enums a real name (as a separate patch) and then use:
enum
power_supply_statusstatus;here? That would be helpful methinks.
My intention is to convey that status variable takes values POWER_SUPPLY_STATUS_*. I'll submit a separate patch to name the enums in power_supply.h. Also I'll make the appropriate changes in power_supply_charger.h
Quoted 8 lines
Quoted 8 lines
include/linux/power/power_supply_charger.h new file +8
-0+struct power_supply_charger { +struct power_supply *psy; +struct psy_throttle_state *throttle_states; +size_t num_throttle_states; +unsigned long supported_cables; +int (*get_property)(struct power_supply_charger *psyc, +enum power_supply_charger_property psp, +union power_supply_propval *val);
Quoted 8 lines
include/linux/power/power_supply_charger.h line 142
Quoted 6 lines
include/linux/power/power_supply_charger.h new file +6
-0+int (*set_property)(struct power_supply_charger *psyc, +enum power_supply_charger_property psp, +const union power_supply_propval *val); +int (*property_is_writeable)(struct power_supply_charger *psyc, +enum power_supply_charger_property psp); +};Kerneldoc this vtable struct.
I'll make the necessary kerneldoc changes as you suggested for this structure and other structures.
Quoted 27 lines
Quoted 13 lines
include/linux/power/power_supply_charger.h new file +12
-0+/* power_supply_charger functions */ + +#ifdef CONFIG_POWER_SUPPLY_CHARGER + +extern int power_supply_register_charger (struct power_supply_charger *psyc); +extern int power_supply_unregister_charger (struct power_supply_charger *psyc); +extern int power_supply_register_charging_algo (struct psy_charging_algo *); +extern int power_supply_unregister_charging_algo (struct psy_charging_algo *); +extern int psy_get_battery_prop (struct psy_batt_chrg_prof *batt_prop); +extern void psy_battery_prop_changed (int battery_conn_stat, +struct psy_batt_chrg_prof *batt_prop); +include/linux/power/power_supply_charger.h line 177
Quoted 10 lines
include/linux/power/power_supply_charger.h new file +10
-0+#else + +static int power_supply_register_charger (struct power_supply_charger *psyc) +{return 0 ; } +static int power_supply_unregister_charger (struct power_supply_charger *psyc) +{return 0 ; } +static int power_supply_register_charging_algo (struct psy_charging_algo *algo) +{return 0 ; } +static int power_supply_unregister_charging_algo (struct psy_charging_algo *algo) +{return 0 ; }Why do these return 0? Should they not just fail if the power supply charger support is not compiled in, like return
-EINVALetc?
Quoted 2 lines
Sorry for just making some random review of the header files, but this caught my attention and I couldn't resist.
No issues, it make sense to return error instead of 0. Thanks for the comments.
-Jenny
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Quoted 5 lines · Jenny Tc
Quoted 4 lines · Linus Walleij
Quoted 1 line · Jenny TC
+++
b/include/linux/power/power_supply_charger.h
Quoted 8 lines
Quoted 6 lines
include/linux/power/power_supply_charger.h line 8
Quoted 2 lines
include/linux/power/power_supply_charger.h new file +2
-0+#define MAX_CUR_VOLT_SAMPLES 3 +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ)Why are things defined in Jiffies like this insead of seconds, milliseconds etc? This will vary with the current operating frequency of the system, why should physical measurements do that?
Is it fine if I use
msecs_to_jiffies(30000)?
Keep the
#define DEF_CUR_VOLT_SAMPLE_PERIOD 30000
Then use msecs_to_jiffies(DEF_CUR_VOLT_SAMPLE_PERIOD) in the call site.
Quoted 28 lines
Quoted 28 lines
Quoted 13 lines
include/linux/power/power_supply_charger.h new file +13
-0+enum psy_charger_cable_event { +PSY_CHARGER_CABLE_EVENT_DISCONNECT =0 , +PSY_CHARGER_CABLE_EVENT_CONNECT , +PSY_CHARGER_CABLE_EVENT_UPDATE , +PSY_CHARGER_CABLE_EVENT_RESUME , +PSY_CHARGER_CABLE_EVENT_SUSPEND , +}; + +enum psy_charger_cable_type { +PSY_CHARGER_CABLE_TYPE_NONE =0 , +PSY_CHARGER_CABLE_TYPE_USB_SDP =1 <<0 , +PSY_CHARGER_CABLE_TYPE_USB_DCP =1 <<1 , +PSY_CHARGER_CABLE_TYPE_USB_CDP =1 <<2 ,include/linux/power/power_supply_charger.h line 38
Quoted 10 lines
include/linux/power/power_supply_charger.h new file +10
-0+PSY_CHARGER_CABLE_TYPE_USB_ACA =1 <<3 , +PSY_CHARGER_CABLE_TYPE_AC =1 <<4 , +PSY_CHARGER_CABLE_TYPE_ACA_DOCK =1 <<5 , +PSY_CHARGER_CABLE_TYPE_ACA_A =1 <<6 , +PSY_CHARGER_CABLE_TYPE_ACA_B =1 <<7 , +PSY_CHARGER_CABLE_TYPE_ACA_C =1 <<8 , +PSY_CHARGER_CABLE_TYPE_SE1 =1 <<9 , +PSY_CHARGER_CABLE_TYPE_MHL =1 <<10 , + PSY_CHARGER_CABLE_TYPE_B_DEVICE = 1 << 11, +};Why is this even an enum? It is clearly bitfields. I would just:
#include <
linux/bitops.h>
Quoted 7 lines
Quoted 4 lines
#define
PSY_CHARGER_CABLE_TYPE_NONE0x0
#definePSY_CHARGER_CABLE_TYPE_USB_SDPBIT(0)
#definePSY_CHARGER_CABLE_TYPE_USB_DCPBIT(1)
(etc)This is to ensure type checks when the cable types are handled, #defines will not help in type checks.
Type checks with static code check tools? But misrepresenting a bitfield as an enum just to satisfy a static code checker is not OK IMO.
Yours,
Linus Walleij
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Quoted 13 lines · Linus Walleij
Quoted 12 lines · Jenny Tc
Quoted 10 lines · Linus Walleij
include/linux/power/power_supply_charger.h line 8
Quoted 4 lines · Jenny TC
+++
b/include/linux/power/power_supply_charger.hinclude/linux/power/power_supply_charger.h new file +2
-0+#define MAX_CUR_VOLT_SAMPLES 3 +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ)Why are things defined in Jiffies like this insead of seconds, milliseconds etc? This will vary with the current operating frequency of the system, why should physical measurements do that?
Quoted 8 lines
Quoted 1 line
Is it fine if I use
msecs_to_jiffies(30000)?Keep the
#defineDEF_CUR_VOLT_SAMPLE_PERIOD30000Then use
msecs_to_jiffies(DEF_CUR_VOLT_SAMPLE_PERIOD)in the call site.
Ok..fine will fix it in next patch set
Quoted 33 lines
Quoted 33 lines
Quoted 32 lines
Quoted 13 lines
include/linux/power/power_supply_charger.h new file +13
-0+enum psy_charger_cable_event { +PSY_CHARGER_CABLE_EVENT_DISCONNECT =0 , +PSY_CHARGER_CABLE_EVENT_CONNECT , +PSY_CHARGER_CABLE_EVENT_UPDATE , +PSY_CHARGER_CABLE_EVENT_RESUME , +PSY_CHARGER_CABLE_EVENT_SUSPEND , +}; + +enum psy_charger_cable_type { +PSY_CHARGER_CABLE_TYPE_NONE =0 , +PSY_CHARGER_CABLE_TYPE_USB_SDP =1 <<0 , +PSY_CHARGER_CABLE_TYPE_USB_DCP =1 <<1 , +PSY_CHARGER_CABLE_TYPE_USB_CDP =1 <<2 ,include/linux/power/power_supply_charger.h line 38
Quoted 10 lines
include/linux/power/power_supply_charger.h new file +10
-0+PSY_CHARGER_CABLE_TYPE_USB_ACA =1 <<3 , +PSY_CHARGER_CABLE_TYPE_AC =1 <<4 , +PSY_CHARGER_CABLE_TYPE_ACA_DOCK =1 <<5 , +PSY_CHARGER_CABLE_TYPE_ACA_A =1 <<6 , +PSY_CHARGER_CABLE_TYPE_ACA_B =1 <<7 , +PSY_CHARGER_CABLE_TYPE_ACA_C =1 <<8 , +PSY_CHARGER_CABLE_TYPE_SE1 =1 <<9 , +PSY_CHARGER_CABLE_TYPE_MHL =1 <<10 , + PSY_CHARGER_CABLE_TYPE_B_DEVICE = 1 << 11, +};Why is this even an enum? It is clearly bitfields. I would just:
#include <
linux/bitops.h>#define
PSY_CHARGER_CABLE_TYPE_NONE0x0
#definePSY_CHARGER_CABLE_TYPE_USB_SDPBIT(0)
#definePSY_CHARGER_CABLE_TYPE_USB_DCPBIT(1)
(etc)
Quoted 6 lines
Quoted 2 lines
This is to ensure type checks when the cable types are handled, #defines will not help in type checks.
Type checks with static code check tools? But misrepresenting a bitfield as an enum just to satisfy a static code checker is not OK IMO.
not just for tools, compile time type checks also.
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
In reply to Linus WalleijHi!
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
include/linux/power/power_supply_charger.h line 8
Quoted 4 lines
+++
b/include/linux/power/power_supply_charger.hinclude/linux/power/power_supply_charger.h new file +2
-0+#define MAX_CUR_VOLT_SAMPLES 3 +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ)Why are things defined in Jiffies like this insead of seconds, milliseconds etc? This will vary with the current operating frequency of the system, why should physical measurements do that?
Quoted 7 lines
Quoted 1 line
Is it fine if I use
msecs_to_jiffies(30000)?Keep the
#defineDEF_CUR_VOLT_SAMPLE_PERIOD30000Then use
msecs_to_jiffies(DEF_CUR_VOLT_SAMPLE_PERIOD)in the call site.
Actually, I do not think this is good suggestion. 30*HZ -- is pretty clearly 30 seconds. 30000 may be 30sec or 30msec ... hard to tell.
If the constant is used in just one place, maybe you don't need the define?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
In reply to Linus WalleijQuoted 10 lines · Linus Walleij
include/linux/power/power_supply_charger.h line 8
Quoted 4 lines · Jenny TC
+++
b/include/linux/power/power_supply_charger.hinclude/linux/power/power_supply_charger.h new file +2
-0+#define MAX_CUR_VOLT_SAMPLES 3 +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ)Why are things defined in Jiffies like this insead of seconds, milliseconds etc? This will vary with the current operating frequency of the system, why should physical measurements do that?
It is actually ok. The define is relative to jiffies, and that's what interface expects.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Quoted 12 lines · Pavel Machek
Quoted 10 lines · Linus Walleij
include/linux/power/power_supply_charger.h line 8
Quoted 4 lines · Jenny TC
+++
b/include/linux/power/power_supply_charger.hinclude/linux/power/power_supply_charger.h new file +2
-0+#define MAX_CUR_VOLT_SAMPLES 3 +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ)Why are things defined in Jiffies like this insead of seconds, milliseconds etc? This will vary with the current operating frequency of the system, why should physical measurements do that?
Quoted 2 lines
It is actually ok. The define is relative to jiffies, and that's what interface expects.
So consider the option that the interface is wrong.
Stating something like a sample period in system-specific jiffies instead of period time T is just weird. What control systems guy would understand this?
Yours,
Linus Walleij
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Quoted 13 lines · Linus Walleij
Quoted 12 lines · Pavel Machek
Quoted 10 lines · Linus Walleij
include/linux/power/power_supply_charger.h line 8
Quoted 4 lines · Jenny TC
+++
b/include/linux/power/power_supply_charger.hinclude/linux/power/power_supply_charger.h new file +2
-0+#define MAX_CUR_VOLT_SAMPLES 3 +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ)Why are things defined in Jiffies like this insead of seconds, milliseconds etc? This will vary with the current operating frequency of the system, why should physical measurements do that?
Quoted 8 lines
Quoted 2 lines
It is actually ok. The define is relative to jiffies, and that's what interface expects.
So consider the option that the interface is wrong.
Stating something like a sample period in system-specific jiffies instead of period time T is just weird. What control systems guy would understand this?
30*HZ means 30 seconds in the kernel... what is hard to understand about it?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Quoted 17 lines · Pavel Machek
Quoted 16 lines · Linus Walleij
Quoted 14 lines · Pavel Machek
Quoted 10 lines · Linus Walleij
include/linux/power/power_supply_charger.h line 8
Quoted 4 lines · Jenny TC
+++
b/include/linux/power/power_supply_charger.hinclude/linux/power/power_supply_charger.h new file +2
-0+#define MAX_CUR_VOLT_SAMPLES 3 +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ)Why are things defined in Jiffies like this insead of seconds, milliseconds etc? This will vary with the current operating frequency of the system, why should physical measurements do that?
It is actually ok. The define is relative to jiffies, and that's what interface expects.
Quoted 8 lines
Quoted 5 lines
So consider the option that the interface is wrong.
Stating something like a sample period in system-specific jiffies instead of period time T is just weird. What control systems guy would understand this?
30*HZ means 30 seconds in the kernel... what is hard to understand about it?
Well I might be picky, but since it is a charging algorithm dealing with ampères, volts, constant-current/constant-voltage, watchdogs and timeouts, all stated in SI units, it would be nice if all such constants were specified in simple units instead of kernel-specific terms.
One reason is that this kind of code actually needs review from non-programmers, people like chemists and physicists.
I know it may be far fetched so no strong preference for sure.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Hi!
Quoted 7 lines
Quoted 2 lines
30*HZ means 30 seconds in the kernel... what is hard to understand about it?
Well I might be picky, but since it is a charging algorithm dealing with ampères, volts, constant-current/constant-voltage, watchdogs and timeouts, all stated in SI units, it would be nice if all such constants were specified in simple units instead of kernel-specific terms.
I agree HZ is badly named, but hopefully anyone working on kernel is already familiar with it.
But... what would actually help: I believe we should introduce milivolt_t, miliamp_t, milisec_t etc... types. Storing milivolts in int, then having comment saying "milivolts" is just wrong.
Pavel
Signature · 6 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Quoted 10 lines · Pavel Machek
Hi!
Quoted 7 lines
Quoted 2 lines
30*HZ means 30 seconds in the kernel... what is hard to understand about it?
Well I might be picky, but since it is a charging algorithm dealing with ampères, volts, constant-current/constant-voltage, watchdogs and timeouts, all stated in SI units, it would be nice if all such constants were specified in simple units instead of kernel-specific terms.
Quoted 6 lines
I agree HZ is badly named, but hopefully anyone working on kernel is already familiar with it.
But... what would actually help: I believe we should introduce
milivolt_t,miliamp_t,milisec_tetc... types. Storing milivolts in int, then having comment saying "milivolts" is just wrong.
Hm! I bet the regulator subsystem maintainers have opinions on that.
Yours,
Linus Walleij
Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Quoted 8 lines · Linus Walleij
Quoted 3 lines · Pavel Machek
But... what would actually help: I believe we should introduce
milivolt_t,miliamp_t,milisec_tetc... types. Storing milivolts in int, then having comment saying "milivolts" is just wrong.Hm! I bet the regulator subsystem maintainers have opinions on that.
The regulator subsystem is quite happily using unsigned ints here, usually we're using hungarian style names to clarify the type where that's useful (it tends to be closer to the usual naming conventions when representing these things mathematically). I'm not sure that having a typedef is going to buy us terribly much unless we convert the kernel to C++ where we can do more exciting stuff.
I would say that we are using microvolts rather than milivolts since it does occasionally matter.
PATCH v6 3/4 power_supply: Introduce PSE compliant algorithm
In reply to Jenny TCAs per Product Safety Engineering (PSE) specification for battery charging, the battery characteristics and thereby the charging rates can vary on different temperature zones. This patch introduces a PSE compliant charging algorithm with maintenance charging support. The algorithm can be selected by the power supply charging driver based on the type of the battery charging profile.
--- drivers/power/Kconfig | 13 ++ drivers/power/Makefile | 1 + drivers/power/charging_algo_pse.c | 204 ++++++++++++++++++++++++++++ include/linux/power/power_supply_charger.h | 48 +++++++ 4 files changed, 266 insertions(+) create mode 100644 drivers/power/charging_algo_pse.c
drivers/power/Kconfig +13 -0
@@ -22,6 +22,19 @@ config POWER_SUPPLY_CHARGER drivers to keep the charging logic outside and the charger driver just need to abstract the charger hardware. +config POWER_SUPPLY_CHARGING_ALGO_PSE + bool "PSE compliant charging algorithm" + help + Say Y here to select Product Safety Engineering (PSE) compliant + charging algorithm. As per PSE standard the battery characteristics + and thereby the charging rates can vary on different temperature + zones. This config will enable PSE compliant charging algorithm with + maintenance charging support. At runtime the algorithm will be + selected by the psy charger driver based on the type of the battery + charging profile. + + depends on POWER_SUPPLY_CHARGER + config PDA_POWER tristate "Generic PDA/phone power driver" depends on !S390
drivers/power/Makefile +1 -0
@@ -8,6 +8,7 @@ obj-$(CONFIG_POWER_SUPPLY) += power_supply.o obj-$(CONFIG_GENERIC_ADC_BATTERY) += generic-adc-battery.o obj-$(CONFIG_POWER_SUPPLY_CHARGER) += power_supply_charger.o +obj-$(CONFIG_POWER_SUPPLY_CHARGING_ALGO_PSE) += charging_algo_pse.o obj-$(CONFIG_PDA_POWER) += pda_power.o obj-$(CONFIG_APM_POWER) += apm_power.o obj-$(CONFIG_MAX8925_POWER) += max8925_power.o
drivers/power/charging_algo_pse.c new file +204 -0
204 lines not on this page · raw message
include/linux/power/power_supply_charger.h +48 -0
56 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH v6 4/4 power_supply: bq24261 charger driver
In reply to Jenny TCThis patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver
--- drivers/power/Kconfig | 10 + drivers/power/Makefile | 1 + drivers/power/bq24261-charger.c | 1350 +++++++++++++++++++++++++++++++++ include/linux/power/bq24261-charger.h | 25 + 4 files changed, 1386 insertions(+) create mode 100644 drivers/power/bq24261-charger.c create mode 100644 include/linux/power/bq24261-charger.h
drivers/power/Kconfig +10 -0
@@ -409,6 +409,16 @@ config BATTERY_GOLDFISH Say Y to enable support for the battery and AC power in the Goldfish emulator. +config CHARGER_BQ24261 + tristate "BQ24261 charger driver" + select POWER_SUPPLY_CHARGER + depends on I2C + help + Say Y to include support for BQ24261 Charger driver. This driver + makes use of power supply charging driver. So the driver gives + the charger hardware abstraction only. Charging logic is abstracted + in the power supply charging driver. + source "drivers/power/reset/Kconfig" endif # POWER_SUPPLY
drivers/power/Makefile +1 -0
@@ -59,4 +59,5 @@ obj-$(CONFIG_CHARGER_BQ24735) += bq24735-charger.o obj-$(CONFIG_POWER_AVS) += avs/ obj-$(CONFIG_CHARGER_SMB347) += smb347-charger.o obj-$(CONFIG_CHARGER_TPS65090) += tps65090-charger.o +obj-$(CONFIG_CHARGER_BQ24261) += bq24261-charger.o obj-$(CONFIG_POWER_RESET) += reset/
drivers/power/bq24261-charger.c new file +1350 -0
1,350 lines not on this page · raw message
include/linux/power/bq24261-charger.h new file +25 -0
@@ -0,0 +1,25 @@ +/* +* bq24261_charger.h: platform data structure for bq24261 driver +* +* (C) Copyright 2012 Intel Corporation +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License +* as published by the Free Software Foundation; version 2 +* of the License. +*/ + +#ifndef __BQ24261_CHARGER_H__ +#define __BQ24261_CHARGER_H__ + +struct bq24261_plat_data { +char **supplied_to; +size_t num_supplicants; +struct psy_throttle_state *throttle_states; +size_t num_throttle_states; +int safety_timer; +bool is_ts_enabled; + +}; + +#endif
Signature · 1 line
1.7.9.5