Skip to contentSkip to conversation

Makefile: fix target-finalize rule

PATCH New Fabio Porcedda 3 participants 3 messages Feb 20, 2014 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: fix target-finalize rule

Fix a bug introduced by the commit a24877586a566e052897e50e6a0c2f53cfb029f5 (Makefile: add support for top-level parallel make).

That commit put a new rule inside the target-finalize rule so it was erroneously splitted in two parts.

Cc Eric Le Bihan <[email protected]>
Cc Thomas De Schampheleire <[email protected]>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +2 -2
index 20aabd6..de568e3 100644
@@ -507,6 +507,8 @@ endif
 STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \)
 STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print
 
+$(TARGETS_ROOTFS): target-finalize
+
 target-finalize: $(TARGETS)
 	rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \
 		$(TARGET_DIR)/usr/lib/pkgconfig $(TARGET_DIR)/usr/share/pkgconfig \
@@ -534,8 +536,6 @@ endif
 		find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \
 		xargs -r $(KSTRIPCMD); fi
 
-$(TARGETS_ROOTFS): target-finalize
-
 # See http://sourceware.org/gdb/wiki/FAQ, "GDB does not see any threads
 # besides the one in which crash occurred; or SIGTRAP kills my program when
 # I set a breakpoint"
Signature · 1 line
1.8.5.2
#1 lore raw

PATCH 1/1 Makefile: fix target-finalize rule

Quoted 9 lines · Fabio Porcedda

Fix a bug introduced by the commit a24877586a566e052897e50e6a0c2f53cfb029f5 (Makefile: add support for top-level parallel make).

That commit put a new rule inside the target-finalize rule so it was erroneously splitted in two parts.

Cc Eric Le Bihan <[email protected]>
Cc Thomas De Schampheleire <[email protected]>
#2 lore raw

PATCH 1/1 Makefile: fix target-finalize rule

In reply to Fabio Porcedda
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabio" == Fabio Porcedda <[email protected]> writes:

Fix a bug introduced by the commit a24877586a566e052897e50e6a0c2f53cfb029f5 (Makefile: add support for top-level parallel make).

That commit put a new rule inside the target-finalize rule so it was erroneously splitted in two parts.

Cc Eric Le Bihan <[email protected]>
Cc Thomas De Schampheleire <[email protected]>

Committed to next, thanks.

Signature · 1 line
Bye, Peter Korsgaard