Skip to contentSkip to conversation

hwrng: msm: switch Kconfig to ARCH_QCOM depends

PATCH Superseded Kumar Gala 2 participants 3 messages Feb 20, 2014

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH v2 1/1 hwrng: msm: switch Kconfig to ARCH_QCOM depends

We've split Qualcomm MSM support into legacy and multiplatform. The RNG driver is only relevant on the multiplatform supported SoCs so switch the Kconfig depends to ARCH_QCOM.

CC Herbert Xu <[email protected]>
CC Stanimir Varbanov <[email protected]>

---

Herbert,

If you can ack this I'll send it via linux-qcom/arm-soc tree's

thanks

v2:
* Updated help text to remove MSM references, made more generic

 drivers/char/hw_random/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/char/hw_random/Kconfig +3 -3
index 2f2b084..f2b9f8c 100644
@@ -342,11 +342,11 @@ config HW_RANDOM_TPM
 	  If unsure, say Y.
 
 config HW_RANDOM_MSM
-	tristate "Qualcomm MSM Random Number Generator support"
-	depends on HW_RANDOM && ARCH_MSM
+	tristate "Qualcomm ARM SoCs Random Number Generator support"
+	depends on HW_RANDOM && ARCH_QCOM
 	---help---
 	  This driver provides kernel-side support for the Random Number
-	  Generator hardware found on Qualcomm MSM SoCs.
+	  Generator hardware found on Qualcomm ARM SoCs.
 
 	  To compile this driver as a module, choose M here. the
 	  module will be called msm-rng.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
#1 lore raw
Quoted 26 lines · Kumar Gala

We've split Qualcomm MSM support into legacy and multiplatform. The RNG driver is only relevant on the multiplatform supported SoCs so switch the Kconfig depends to ARCH_QCOM.

CC Herbert Xu <[email protected]>
CC Stanimir Varbanov <[email protected]>

---

Herbert,

If you can ack this I'll send it via linux-qcom/arm-soc tree's

thanks

v2:
* Updated help text to remove MSM references, made more generic

 drivers/char/hw_random/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/char/hw_random/Kconfig +0 -0
index 2f2b084..f2b9f8c 100644

drivers/char/hw_random/Kconfig config HW_RANDOM_TPM · line 346

Quoted 6 lines
drivers/char/hw_random/Kconfig +1 -1
@@ -342,11 +342,11 @@ config HW_RANDOM_TPM
 	  If unsure, say Y.
 
 config HW_RANDOM_MSM
-	tristate "Qualcomm MSM Random Number Generator support"
 
+	tristate "Qualcomm ARM SoCs Random Number Generator support"

Can the Hexagon use the PRNG, at least theoretically? If so maybe it'd be clearest to leave ARM off.

Christopher

Signature · 3 lines
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
author
#2 lore raw
Quoted 32 lines · Christopher Covington
Quoted 30 lines · Kumar Gala

We've split Qualcomm MSM support into legacy and multiplatform. The RNG driver is only relevant on the multiplatform supported SoCs so switch the Kconfig depends to ARCH_QCOM.

CC Herbert Xu <[email protected]>
CC Stanimir Varbanov <[email protected]>

---

Herbert,

If you can ack this I'll send it via linux-qcom/arm-soc tree's

thanks

v2:
* Updated help text to remove MSM references, made more generic

drivers/char/hw_random/Kconfig | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)
drivers/char/hw_random/Kconfig +0 -0
index 2f2b084..f2b9f8c 100644
@@ -342,11 +342,11 @@ config HW_RANDOM_TPM
 	  If unsure, say Y.
 

config HW_RANDOM_MSM

drivers/char/hw_random/Kconfig +0 -1
-	tristate "Qualcomm MSM Random Number Generator support"
Quoted 6 lines

drivers/char/hw_random/Kconfig config HW_RANDOM_TPM · line 345

Quoted 1 line
drivers/char/hw_random/Kconfig +1 -0
+	tristate "Qualcomm ARM SoCs Random Number Generator support"

Can the Hexagon use the PRNG, at least theoretically? If so maybe it'd be clearest to leave ARM off.

Christopher

Fair point.

- k

Signature · 2 lines
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation