qga: Fix memory allocation pasto
PATCH 1/1 qga: Fix memory allocation pasto
qmp_guest_file_seek() allocates memory for a GuestFileRead object instead of the GuestFileSeek object it actually uses. Harmless, because the GuestFileRead is slightly larger.
Signed-off-by Markus Armbruster <[email protected]>
--- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
qga/commands-posix.c +1 -1
@@ -525,7 +525,7 @@ struct GuestFileSeek *qmp_guest_file_seek(int64_t handle, int64_t offset,if (ret ==-1 ) {error_setg_errno (err, errno,"failed to seek file" ); }else { - seek_data =g_malloc0 (sizeof (GuestFileRead)); + seek_data =g_new0 (GuestFileSeek,1 ); seek_data->position =ftell (fh); seek_data->eof =feof (fh); }
Signature · 1 line
1.8.1.4
Quoted 8 lines · Markus Armbruster
qmp_guest_file_seek()allocates memory for a GuestFileRead object instead of the GuestFileSeek object it actually uses. Harmless, because the GuestFileRead is slightly larger.Signed-off-by Markus Armbruster <[email protected]>--- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Eric Blake <[email protected]>
Quoted 15 lines
qga/commands-posix.c +1
-1@@ -525,7 +525,7 @@ struct GuestFileSeek *qmp_guest_file_seek(int64_t handle, int64_t offset,if (ret ==-1 ) {error_setg_errno (err, errno,"failed to seek file" ); }else { - seek_data =g_malloc0 (sizeof (GuestFileRead)); + seek_data =g_new0 (GuestFileSeek,1 ); seek_data->position =ftell (fh); seek_data->eof =feof (fh); }
Signature · 2 lines
Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Michael Roth
AppliedQuoting Markus Armbruster (2014-02-21 06:36:49)
Quoted 5 lines
qmp_guest_file_seek()allocates memory for a GuestFileRead object instead of the GuestFileSeek object it actually uses. Harmless, because the GuestFileRead is slightly larger.Signed-off-by Markus Armbruster <[email protected]>
Thanks, applied to qga tree:
https://github.com/mdroth/qemu/commits/qga
Quoted 19 lines
--- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)qga/commands-posix.c +1
-1@@ -525,7 +525,7 @@ struct GuestFileSeek *qmp_guest_file_seek(int64_t handle, int64_t offset,if (ret ==-1 ) {error_setg_errno (err, errno,"failed to seek file" ); }else { - seek_data =g_malloc0 (sizeof (GuestFileRead)); + seek_data =g_new0 (GuestFileSeek,1 ); seek_data->position =ftell (fh); seek_data->eof =feof (fh); }Signature · 1 line
1.8.1.4