NTB: Fix typo in setting one translation register
PATCH 1/1 NTB: Fix typo in setting one translation register
From: Roland Dreier <[email protected]>
In the code for Xeon devices in back-to-back mode with xeon_errata_workaround disabled, the downstream device puts the wrong value in SNB_B2B_XLAT_OFFSETL (SNB_MBAR01_DSD_ADDR vs. SNB_MBAR01_USD_ADDR).
This was spotted while reading code, since the typo has no practical effect, at least for now: the low 32 bits of both constants are actually identical anyway. However, it's clearer and safer to use the right name.
--- drivers/ntb/ntb_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ntb/ntb_hw.c +1 -1
@@ -785,7 +785,7 @@ static int ntb_xeon_setup(struct ntb_device *ndev)/* B2B_XLAT_OFFSET is a 64bit register, but can * only take 32bit writes */ -writel (SNB_MBAR01_DSD_ADDR &0xffffffff , +writel (SNB_MBAR01_USD_ADDR &0xffffffff , ndev->reg_base +SNB_B2B_XLAT_OFFSETL );writel (SNB_MBAR01_USD_ADDR >>32 , ndev->reg_base +SNB_B2B_XLAT_OFFSETU );
Signature · 1 line
1.9.0
Quoted 9 lines · Roland Dreier
From: Roland Dreier <[email protected]>
In the code for Xeon devices in back-to-back mode with
xeon_errata_workarounddisabled, the downstream device puts the wrong value inSNB_B2B_XLAT_OFFSETL(SNB_MBAR01_DSD_ADDRvs.SNB_MBAR01_USD_ADDR).This was spotted while reading code, since the typo has no practical effect, at least for now: the low 32 bits of both constants are actually identical anyway. However, it's clearer and safer to use the right name.
Good catch. Applied.
Quoted 22 lines
Signed-off-by Roland Dreier <[email protected]>--- drivers/ntb/ntb_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/ntb/ntb_hw.c +1
-1@@ -785,7 +785,7 @@ static int ntb_xeon_setup(struct ntb_device *ndev)/* B2B_XLAT_OFFSET is a 64bit register, but can * only take 32bit writes */ -writel (SNB_MBAR01_DSD_ADDR &0xffffffff , +writel (SNB_MBAR01_USD_ADDR &0xffffffff , ndev->reg_base +SNB_B2B_XLAT_OFFSETL );writel (SNB_MBAR01_USD_ADDR >>32 , ndev->reg_base +SNB_B2B_XLAT_OFFSETU );Signature · 1 line
1.9.0