ath9k: do not set half/quarter channel flags in AR_PHY_MODE
PATCH 1/2 ath9k: do not set half/quarter channel flags in AR_PHY_MODE
5/10 MHz channel bandwidth is configured via the PLL clock, instead of the AR_PHY_MODE register. Using that register is AR93xx specific, and makes the mode incompatible with earlier chipsets.
In some early versions, these flags were apparently applied at the wrong point in time and thus did not cause connectivity issues, however now they are causing problems, as pointed out in this OpenWrt ticket:
https://dev.openwrt.org/ticket/14916
--- drivers/net/wireless/ath/ath9k/ar9003_phy.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/net/wireless/ath/ath9k/ar9003_phy.c +0 -4
@@ -868,10 +868,6 @@ static void ar9003_hw_set_rfmode(struct ath_hw *ah,if (IS_CHAN_A_FAST_CLOCK (ah, chan)) rfMode |= (AR_PHY_MODE_DYNAMIC |AR_PHY_MODE_DYN_CCK_DISABLE ); -if (IS_CHAN_QUARTER_RATE (chan)) - rfMode |=AR_PHY_MODE_QUARTER ; -if (IS_CHAN_HALF_RATE (chan)) - rfMode |=AR_PHY_MODE_HALF ;if (rfMode & (AR_PHY_MODE_QUARTER |AR_PHY_MODE_HALF )) REG_RMW_FIELD(ah, AR_PHY_FRAME_CTL,
Signature · 1 line
1.8.3.4 (Apple Git-47)
PATCH 2/2 ath9k: make some hardware reset log messages debug-only
On some chips, baseband watchdog hangs are more common than others, and the driver has support for handling them.
Interrupts even after a watchdog hang are also quite common, so there's not much point in spamming the user's logfiles.
--- drivers/net/wireless/ath/ath9k/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath9k/main.c +3 -3
@@ -451,7 +451,7 @@ void ath9k_tasklet(unsigned long data)* interrupts are enabled in the reset routine. */ atomic_inc (&ah->intr_ref_cnt); -ath_dbg (common,ANY ,"FATAL: Skipping interrupts\n" ); +ath_dbg (common,RESET ,"FATAL: Skipping interrupts\n" ); goto out; }
@@ -471,7 +471,7 @@ void ath9k_tasklet(unsigned long data)* interrupts are enabled in the reset routine. */ atomic_inc (&ah->intr_ref_cnt); -ath_dbg (common,ANY , +ath_dbg (common,RESET ,"BB_WATCHDOG: Skipping interrupts\n" ); goto out; }
@@ -484,7 +484,7 @@ void ath9k_tasklet(unsigned long data) type =RESET_TYPE_TX_GTT ;ath9k_queue_reset (sc, type);atomic_inc (&ah->intr_ref_cnt); -ath_dbg (common,ANY , +ath_dbg (common,RESET ,"GTT: Skipping interrupts\n" ); goto out; }
Signature · 1 line
1.8.3.4 (Apple Git-47)