Skip to contentSkip to conversation

binutils: install libiberty

PATCH New Arnout Vandecappelle (Essensium/Mind) 3 participants 3 messages Feb 22, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 binutils: install libiberty

Some packages (actually, just oprofile) need to link against libiberty. This option just installs libiberty.a so it has no effect on the target, therefore it's not needed to add a config option for it.

Before binutils-2.24, there was a bug in libiberty/Makefile.in that caused libiberty to be installed regardless of the --enable-install-libiberty option. This problem wasn't noticed before because binutils-2.24 is not selected on any of the autobuilders: the version can only be selected if an internal toolchain is used, and it defaults to 2.21.

---
 package/binutils/binutils.mk | 1 +
 1 file changed, 1 insertion(+)
package/binutils/binutils.mk +1 -0
index d6828f5..b5a2dc7 100644
@@ -51,6 +51,7 @@ endif
 BINUTILS_CONF_OPT = --disable-multilib --disable-werror \
 		--host=$(GNU_TARGET_NAME) \
 		--target=$(GNU_TARGET_NAME) \
+		--enable-install-libiberty \
 		$(BINUTILS_EXTRA_CONFIG_OPTIONS)
 
 # Install binutils after busybox to prefer full-blown utilities
Signature · 1 line
1.9.0
#1 lore raw

PATCH 1/1 binutils: install libiberty

Dear Arnout Vandecappelle (Essensium/Mind),

Quoted 11 lines · Arnout Vandecappelle (Essensium/Mind)

Some packages (actually, just oprofile) need to link against libiberty. This option just installs libiberty.a so it has no effect on the target, therefore it's not needed to add a config option for it.

Before binutils-2.24, there was a bug in libiberty/Makefile.in that caused libiberty to be installed regardless of the --enable-install-libiberty option. This problem wasn't noticed before because binutils-2.24 is not selected on any of the autobuilders: the version can only be selected if an internal toolchain is used, and it defaults to 2.21.

Quoted 4 lines
---
 package/binutils/binutils.mk | 1 +
 1 file changed, 1 insertion(+)

I believe this might fix:

http://autobuild.buildroot.org/results/be1/be199b97dcdaf28a8fef9d90953115a005baa173/build-end.log

If someone could verify this, maybe this patch could be committed to master.

On Microblaze, a non-default binutils version is used, and the version is fairly recent, most likely a 2.24-something version (we actually use a git commit).

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 binutils: install libiberty

In reply to Arnout Vandecappelle (Essensium/Mind)
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

Some packages (actually, just oprofile) need to link against libiberty. This option just installs libiberty.a so it has no effect on the target, therefore it's not needed to add a config option for it.

Quoted 8 lines

Before binutils-2.24, there was a bug in libiberty/Makefile.in that caused libiberty to be installed regardless of the --enable-install-libiberty option. This problem wasn't noticed before because binutils-2.24 is not selected on any of the autobuilders: the version can only be selected if an internal toolchain is used, and it defaults to 2.21.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard