Skip to contentSkip to conversation

cpufreq: enable ARM drivers on arm64

PATCH Applied Mark Brown 3 participants 4 messages Feb 24, 2014 – Mar 11, 2014

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 cpufreq: enable ARM drivers on arm64

From: Rob Herring <[email protected]>

Enable cpufreq and power kconfig menus on arm64 along with arm cpufreq drivers. The power menu is needed for OPP support. At least on Calxeda systems, the same cpufreq driver is used for arm and arm64 based systems.

---
 arch/arm64/Kconfig      | 8 ++++++++
 drivers/cpufreq/Kconfig | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
arch/arm64/Kconfig +8 -0
index fea7b47..939e95a 100644
@@ -327,6 +327,14 @@ source "drivers/cpuidle/Kconfig"
 
 endmenu
 
+menu "Power management options"
+
+source "kernel/power/Kconfig"
+
+source "drivers/cpufreq/Kconfig"
+
+endmenu
+
 source "net/Kconfig"
 
 source "drivers/Kconfig"
drivers/cpufreq/Kconfig +1 -1
index 4b029c0..1fbe11f 100644
@@ -200,7 +200,7 @@ source "drivers/cpufreq/Kconfig.x86"
 endmenu
 
 menu "ARM CPU frequency scaling drivers"
-depends on ARM
+depends on ARM || ARM64
 source "drivers/cpufreq/Kconfig.arm"
 endmenu
 
Signature · 1 line
1.9.0.rc3
#1 lore raw
Quoted 10 lines · Mark Brown

From: Rob Herring <[email protected]>

Enable cpufreq and power kconfig menus on arm64 along with arm cpufreq drivers. The power menu is needed for OPP support. At least on Calxeda systems, the same cpufreq driver is used for arm and arm64 based systems.

Queued up for 3.15, thanks!

Quoted 38 lines
---
 arch/arm64/Kconfig      | 8 ++++++++
 drivers/cpufreq/Kconfig | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
arch/arm64/Kconfig +8 -0
index fea7b47..939e95a 100644
@@ -327,6 +327,14 @@ source "drivers/cpuidle/Kconfig"
 
 endmenu
 
+menu "Power management options"
+
+source "kernel/power/Kconfig"
+
+source "drivers/cpufreq/Kconfig"
+
+endmenu
+
 source "net/Kconfig"
 
 source "drivers/Kconfig"
drivers/cpufreq/Kconfig +1 -1
index 4b029c0..1fbe11f 100644
@@ -200,7 +200,7 @@ source "drivers/cpufreq/Kconfig.x86"
 endmenu
 
 menu "ARM CPU frequency scaling drivers"
-depends on ARM
+depends on ARM || ARM64
 source "drivers/cpufreq/Kconfig.arm"
 endmenu
 
Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
#2 lore raw
In reply to Mark Brown

Hi Mark,

Sorry for late response, looks like Rafael has pulled this change, but ...

Quoted 21 lines · Mark Brown

From: Rob Herring <[email protected]>

Enable cpufreq and power kconfig menus on arm64 along with arm cpufreq drivers. The power menu is needed for OPP support. At least on Calxeda systems, the same cpufreq driver is used for arm and arm64 based systems.

---
  arch/arm64/Kconfig      | 8 ++++++++
  drivers/cpufreq/Kconfig | 2 +-
  2 files changed, 9 insertions(+), 1 deletion(-)
arch/arm64/Kconfig +0 -0
index fea7b47..939e95a 100644
@@ -327,6 +327,14 @@ source "drivers/cpuidle/Kconfig"
 

arch/arm64/Kconfig source "drivers/cpuidle/Kconfig" · line 337

Quoted 10 lines
arch/arm64/Kconfig +8 -0
  endmenu
 
+menu "Power management options"
+
+source "kernel/power/Kconfig"
+
+source "drivers/cpufreq/Kconfig"
+
+endmenu
+

Is this patch based on recent kernels ? If so, either it should have caused conflicts or silently duplicated the entries. "Power management options" are already present.

Also to be more consistent it with menu options, I would prefer this to be placed under "CPU Power Management" like CPUIdle.

Regards,
Sudeep

author
#3 lore raw
Quoted 13 lines · Sudeep Holla

Sorry for late response, looks like Rafael has pulled this change, but ...

arch/arm64/Kconfig source "drivers/cpuidle/Kconfig" · line 336

Quoted 7 lines
arch/arm64/Kconfig +7 -0
+menu "Power management options"
+
+source "kernel/power/Kconfig"
+
+source "drivers/cpufreq/Kconfig"
+
+endmenu

Is this patch based on recent kernels ? If so, either it should have caused conflicts or silently duplicated the entries. "Power management options" are already present.

Yes, it was against -next. It looks like either the original patch had the duplication or it crept in there during the rather lengthy time between submission and acceptance.

Quoted 2 lines

Also to be more consistent it with menu options, I would prefer this to be placed under "CPU Power Management" like CPUIdle.

I'll submit an incremental patch for this; in general the best thing to do once things have been applied is to send a patch.