Staging: comedi: Fix coding style issue in poc.c
PATCH 1/1 Staging: comedi: Fix coding style issue in poc.c
This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl
Signed-off-by David Roddick <[email protected]>
--- drivers/staging/comedi/drivers/poc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/comedi/drivers/poc.c +4 -4
@@ -36,15 +36,15 @@ Configuration options:struct boarddef_struct {const char *name;unsigned int iosize; -int (*setup) (struct comedi_device *); +int (*setup)(struct comedi_device *);int type;int n_chan;int n_bits; -int (*winsn) (struct comedi_device *,struct comedi_subdevice *, +int (*winsn)(struct comedi_device *,struct comedi_subdevice *,struct comedi_insn *,unsigned int *); -int (*rinsn) (struct comedi_device *,struct comedi_subdevice *, +int (*rinsn)(struct comedi_device *,struct comedi_subdevice *,struct comedi_insn *,unsigned int *); -int (*insnbits) (struct comedi_device *,struct comedi_subdevice *, +int (*insnbits)(struct comedi_device *,struct comedi_subdevice *,struct comedi_insn *,unsigned int *);const struct comedi_lrange *range; };
Signature · 1 line
1.8.5.3
Quoted 1 line · David Roddick
This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl
A few comments:
Please wrap your commit message to 70 columns or so.
There is 1 c in unnecessary.
The "This is a patch to " bit isn't particularly useful in the commit log, neither is the "found with checkpatch.pl".
drivers/staging/comedi/drivers/poc.c
Quoted 1 line
drivers/staging/comedi/drivers/poc.c +0
-0
[]
drivers/staging/comedi/drivers/poc.c Configuration options:
Quoted 1 line
drivers/staging/comedi/drivers/poc.c +0
-0@@ -36,15 +36,15 @@ Configuration options:
[]
drivers/staging/comedi/drivers/poc.c Configuration options: · line 44
Quoted 3 lines
drivers/staging/comedi/drivers/poc.c +1
-1-int (*winsn) (struct comedi_device *,struct comedi_subdevice *, +int (*winsn)(struct comedi_device *,struct comedi_subdevice *,struct comedi_insn *,unsigned int *);
Please wrap multi-line definitions lines like:
int (*winsn)(struct comedi_device *, struct comedi_subdevice *, struct comedi_insn *, unsigned int *);
Ideally, these arguments would have some descriptive names too.