Skip to contentSkip to conversation

Staging: comedi: fix coding style issues in poc.c

PATCH In review David Roddick 2 participants 2 messages Feb 24, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: comedi: fix coding style issues in poc.c

Removed unnecessary spaces after function pointer names and corrected multi-line wrap alignment

---
 drivers/staging/comedi/drivers/poc.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/comedi/drivers/poc.c +7 -7
index 2ae4ee1..514ccd8 100644
@@ -36,16 +36,16 @@ Configuration options:
 struct boarddef_struct {
 	const char *name;
 	unsigned int iosize;
-	int (*setup) (struct comedi_device *);
+	int (*setup)(struct comedi_device *);
 	int type;
 	int n_chan;
 	int n_bits;
-	int (*winsn) (struct comedi_device *, struct comedi_subdevice *,
-		      struct comedi_insn *, unsigned int *);
-	int (*rinsn) (struct comedi_device *, struct comedi_subdevice *,
-		      struct comedi_insn *, unsigned int *);
-	int (*insnbits) (struct comedi_device *, struct comedi_subdevice *,
-			 struct comedi_insn *, unsigned int *);
+	int (*winsn)(struct comedi_device *, struct comedi_subdevice *,
+		struct comedi_insn *, unsigned int *);
+	int (*rinsn)(struct comedi_device *, struct comedi_subdevice *,
+		struct comedi_insn *, unsigned int *);
+	int (*insnbits)(struct comedi_device *, struct comedi_subdevice *,
+		struct comedi_insn *, unsigned int *);
 	const struct comedi_lrange *range;
 };
 
Signature · 1 line
1.8.5.3
#1 lore raw

You have not understood what Joe said.

Quoted 2 lines · David Roddick

Removed unnecessary spaces after function pointer names and corrected multi-line wrap alignment

This should be line wrapped at 72 characters (same rule as email). In other words it should take two lines like this:

Removed unnecessary spaces after function pointer names and corrected multi-line wrap alignment.

Quoted 16 lines
---
 drivers/staging/comedi/drivers/poc.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/comedi/drivers/poc.c +1 -1
index 2ae4ee1..514ccd8 100644
@@ -36,16 +36,16 @@ Configuration options:
 struct boarddef_struct {
 	const char *name;
 	unsigned int iosize;
-	int (*setup) (struct comedi_device *);
+	int (*setup)(struct comedi_device *);
 	int type;

drivers/staging/comedi/drivers/poc.c Configuration options: · line 44

Quoted 10 lines
drivers/staging/comedi/drivers/poc.c +2 -6
 	int n_chan;
 	int n_bits;
-	int (*winsn) (struct comedi_device *, struct comedi_subdevice *,
-		      struct comedi_insn *, unsigned int *);
-	int (*rinsn) (struct comedi_device *, struct comedi_subdevice *,
-		      struct comedi_insn *, unsigned int *);
-	int (*insnbits) (struct comedi_device *, struct comedi_subdevice *,
-			 struct comedi_insn *, unsigned int *);
+	int (*winsn)(struct comedi_device *, struct comedi_subdevice *,
+		struct comedi_insn *, unsigned int *);

This is wrong. It should be exactly like Joe said:

	int (*winsn)(struct comedi_device *, struct comedi_subdevice *,
		     struct comedi_insn *, unsigned int *);

[tab][tab][space][space][space][space][space]struct comedi_insn *,

Ideally it would have a variable name here, but since that wasn't there in the original, we would accept the patch without it. All the data types are pretty clear what they are already, the only thing which is not clear is what the last parameter does.

regards,
dan carpenter