net: Fix permission check in netlink_connect()
Subsystems (2)
PATCH 1/1 net: Fix permission check in netlink_connect()
netlink_sendmsg() was changed to prevent non-root processes from sending messages with dst_pid != 0.netlink_connect() however still only checks if nladdr->nl_groups is set. This patch modifies netlink_connect() to check for the same condition.
Signed-off-by Mike Pecovnik <[email protected]>
--- net/netlink/af_netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/netlink/af_netlink.c +2 -2
@@ -1489,8 +1489,8 @@ static int netlink_connect(struct socket *sock, struct sockaddr *addr,if (addr->sa_family !=AF_NETLINK )return -EINVAL ; -/* Only superuser is allowed to send multicasts */ -if (nladdr->nl_groups && !netlink_capable (sock,NL_CFG_F_NONROOT_SEND )) +if ((nladdr->nl_groups || nladdr->nl_pid) && + !netlink_capable (sock,NL_CFG_F_NONROOT_SEND ))return -EPERM ;if (!nlk->portid)
Signature · 1 line
1.8.3.2
From: Mike Pecovnik <[email protected]>
Date: Mon, 24 Feb 2014 21:11:16 +0100
Quoted 6 lines
netlink_sendmsg()was changed to prevent non-root processes from sending messages withdst_pid!= 0.netlink_connect()however still only checks ifnladdr->nl_groupsis set. This patch modifiesnetlink_connect()to check for the same condition.Signed-off-by Mike Pecovnik <[email protected]>
Applied, thank you.