Skip to contentSkip to conversation

gpio: Mark xtensa gpio driver as BROKEN

PATCH In review Guenter Roeck 2 participants 2 messages Feb 25, 2014 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: Mark xtensa gpio driver as BROKEN

xtensa:allmodconfig build fails with

drivers/gpio/gpio-xtensa.c: Assembler messages:
drivers/gpio/gpio-xtensa.c:87: Error: unknown opcode or format name 'read_impwire' drivers/gpio/gpio-xtensa.c:110: Error: unknown opcode or format name 'rur.expstate' drivers/gpio/gpio-xtensa.c:124: Error: unknown opcode or format name 'wrmsk_expstate'

Tests with various compiler versions was unsuccessful, suggesting that the assembler instructions may only be available with some unspecified xtensa variant. Until that is resolved, mark the driver as broken to enable test builds.

---
I know this is likely controversial, but it seems to be better than letting builds fail. And maybe it causes a real fix to be submitted.

 drivers/gpio/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/Kconfig +1 -0
index 903f24d..0b5a0a1 100644
@@ -306,6 +306,7 @@ config GPIO_XILINX
 
 config GPIO_XTENSA
 	bool "Xtensa GPIO32 support"
+	depends on BROKEN
 	depends on XTENSA
 	depends on HAVE_XTENSA_GPIO32
 	depends on !SMP
Signature · 1 line
1.7.9.7
#1 lore raw
Quoted 12 lines · Guenter Roeck

xtensa:allmodconfig build fails with

drivers/gpio/gpio-xtensa.c: Assembler messages:
drivers/gpio/gpio-xtensa.c:87: Error: unknown opcode or format name 'read_impwire' drivers/gpio/gpio-xtensa.c:110: Error: unknown opcode or format name 'rur.expstate' drivers/gpio/gpio-xtensa.c:124: Error: unknown opcode or format name 'wrmsk_expstate'

Tests with various compiler versions was unsuccessful, suggesting that the assembler instructions may only be available with some unspecified xtensa variant. Until that is resolved, mark the driver as broken to enable test builds.

Quoted 4 lines

---
I know this is likely controversial, but it seems to be better than letting builds fail. And maybe it causes a real fix to be submitted.

The fix is on the way:
http://lists.linux-xtensa.org/pipermail/linux-xtensa/Week-of-Mon-20140203/001584.html

Signature · 2 lines
Thanks.
-- Max