xfs_io: add fzero command for zeroing range via fallocate
PATCH 1/1 xfs_io: add fzero command for zeroing range via fallocate
Add fzero command which zeroes a range of the file using fallocate FALLOC_FL_ZERO_RANGE flag.
Signed-off-by Lukas Czerner <[email protected]>
--- io/prealloc.c | 42 +++++++++++++++++++++++++++++++++++++++++- man/man8/xfs_io.8 | 5 +++++ 2 files changed, 46 insertions(+), 1 deletion(-)
io/prealloc.c +41 -1
@@ -33,6 +33,10 @@#define FALLOC_FL_COLLAPSE_RANGE 0x08#endif +#ifndef FALLOC_FL_ZERO_RANGE +#define FALLOC_FL_ZERO_RANGE 0x10 +#endif +static cmdinfo_t allocsp_cmd;static cmdinfo_t freesp_cmd;static cmdinfo_t resvsp_cmd;
@@ -42,6 +46,7 @@ static cmdinfo_t zero_cmd;static cmdinfo_t falloc_cmd;static cmdinfo_t fpunch_cmd;static cmdinfo_t fcollapse_cmd; +static cmdinfo_t fzero_cmd;#endif static int
@@ -230,6 +235,31 @@ fcollapse_f( }return 0 ; } + +static int +fzero_f ( +int argc, +char **argv) +{ +xfs_flock64_t segment; +int mode =FALLOC_FL_ZERO_RANGE ; +int index =1 ; + +if (strncmp (argv[index],"-k" ,3 ) ==0 ) { + mode |=FALLOC_FL_KEEP_SIZE ; + index++; + } + +if (!offset_length (argv[index], argv[index +1 ], &segment)) +return 0 ; + +if (fallocate (file->fd, mode, + segment.l_start, segment.l_len)) { +perror ("fallocate" ); +return 0 ; + } +return 0 ; +}#endif /* HAVE_FALLOCATE */ void
@@ -312,7 +342,17 @@ prealloc_init(void) fcollapse_cmd.flags =CMD_NOMAP_OK |CMD_FOREIGN_OK ; fcollapse_cmd.args =_ ("off len" ); fcollapse_cmd.oneline = -_ ("de-allocates space and eliminates the hole by shifting extents" ); +_ ("de-allocates space and eliminates the hole by shifting extents" );add_command (&fcollapse_cmd); + + fzero_cmd.name ="fzero" ; + fzero_cmd.cfunc = fzero_f; + fzero_cmd.argmin =2 ; + fzero_cmd.argmax =3 ; + fzero_cmd.flags =CMD_NOMAP_OK |CMD_FOREIGN_OK ; + fzero_cmd.args =_ ("[-k] off len" ); + fzero_cmd.oneline = +_ ("zeroes space and eliminates holes by preallocating" ); +add_command (&fzero_cmd);#endif /* HAVE_FALLOCATE */ }
man/man8/xfs_io.8 +5 -0
@@ -392,6 +392,11 @@ the FALLOC_FL_PUNCH_HOLE flag as described in the .BR fallocate (2) manual page. .TP +.BI fzero " offset length" +Call fallocate with FALLOC_FL_ZERO_RANGE flag as described in the +.BR fallocate (2) +manual page to allocate and zero blocks within the range. +.TP .BI truncate " offset" Truncates the current file at the given offset using .BR ftruncate (2).
Signature · 1 line
1.8.3.1
Quoted 4 lines · Lukas Czerner
Add fzero command which zeroes a range of the file using fallocate
FALLOC_FL_ZERO_RANGEflag.Signed-off-by Lukas Czerner <[email protected]>
Looks ok, but...
io/prealloc.c prealloc_init(void) · line 346
Quoted 7 lines
io/prealloc.c +1
-1@@ -312,7 +342,17 @@ prealloc_init(void) fcollapse_cmd.flags =CMD_NOMAP_OK |CMD_FOREIGN_OK ; fcollapse_cmd.args =_ ("off len" ); fcollapse_cmd.oneline = -_ ("de-allocates space and eliminates the hole by shifting extents" ); +_ ("de-allocates space and eliminates the hole by shifting extents" );add_command (&fcollapse_cmd);
I'll drop this change because it pushes the line beyond 80 characters....
Otherwise,
Reviewed-by Dave Chinner <[email protected]>
Signature · 2 lines
Dave Chinner [email protected]