Skip to contentSkip to conversation

ncftp: clarify the NCFTP_RUN_AUTOCONF hook.

PATCH New Arnout Vandecappelle (Essensium/Mind) 2 participants 2 messages Feb 25, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ncftp: clarify the NCFTP_RUN_AUTOCONF hook.

When I saw this patch it took me a while to figure out how/why it worked, so let's make life easier for the eventual version bumper to understand what's going on here.

---
For -next

---
 package/ncftp/ncftp.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/ncftp/ncftp.mk +4 -1
index 841c82b..6ab3934 100644
@@ -13,10 +13,13 @@ NCFTP_LICENSE_FILES = doc/LICENSE.txt
 
 NCFTP_DEPENDENCIES = host-autoconf
 
+# The bundled configure script is generated by autoconf 2.13 and doesn't
+# detect cross-compilation correctly. Therefore, we have to regenerate it.
+# We need to pass -I because of the non-standard m4 directory name, and
+# none of the other autotools are used, so the below is the easiest.
 define NCFTP_RUN_AUTOCONF
        (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
 endef
-
 NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
 
 ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
Signature · 1 line
1.9.0
#1 lore raw

PATCH 1/1 ncftp: clarify the NCFTP_RUN_AUTOCONF hook.

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

When I saw this patch it took me a while to figure out how/why it worked, so let's make life easier for the eventual version bumper to understand what's going on here.

---
For -next

We made the change on master, and this change is obviously (tm) safe, so I've added it to master instead, thanks.

Signature · 1 line
Bye, Peter Korsgaard