irq-metag*: stop set_affinity vectoring to offline cpus
PATCH 1/1 irq-metag*: stop set_affinity vectoring to offline cpus
Fix irq_set_affinity callbacks in the Meta IRQ chip drivers to AND cpu_online_mask into the cpumask when picking a CPU to vector the interrupt to.
As Thomas pointed out, the /proc/irq/$N/smp_affinity interface doesn't filter out offline CPUs, so without this patch if you offline CPU0 and set an IRQ affinity to 0x3 it vectors the interrupt onto CPU0 even though it is offline.
Reported-by Thomas Gleixner <[email protected]>
Signed-off-by James Hogan <[email protected]>
Cc Thomas Gleixner <[email protected]>
---
I'll apply this patch for v3.14.
drivers/irqchip/irq-metag-ext.c | 2 +- drivers/irqchip/irq-metag.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-metag-ext.c +1 -1
@@ -515,7 +515,7 @@ static int meta_intc_set_affinity(struct irq_data *data,* one cpu (the interrupt code doesn't support it), so we just * pick the first cpu we find in 'cpumask'. */ - cpu =cpumask_any (cpumask); + cpu =cpumask_any_and (cpumask, cpu_online_mask); thread = cpu_2_hwthread_id[cpu];metag_out32 (TBI_TRIG_VEC (TBID_SIGNUM_TR2 (thread)), vec_addr);
drivers/irqchip/irq-metag.c +1 -1
@@ -201,7 +201,7 @@ static int metag_internal_irq_set_affinity(struct irq_data *data,* one cpu (the interrupt code doesn't support it), so we just * pick the first cpu we find in 'cpumask'. */ - cpu =cpumask_any (cpumask); + cpu =cpumask_any_and (cpumask, cpu_online_mask); thread = cpu_2_hwthread_id[cpu]; metag_out32(TBI_TRIG_VEC(TBID_SIGNUM_TR1(thread)),
Signature · 1 line
1.8.1.2