staging: comedi: drivers: fix for a potential NULL pointer dereference

PATCH New Kumar Amit Mehta 1 participant 1 message Feb 25, 2014

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Kumar Amit Mehta

author

2014-02-25 23:04 UTC #0 lore raw

PATCH 1/1 staging: comedi: drivers: fix for a potential NULL pointer dereference

Return -ENOMEM in ni_E_init if ni_gpct_device_construct returns NULL

Signed-off-by Kumar Amit Mehta <[email protected]>

---
 drivers/staging/comedi/drivers/ni_mio_common.c | 3 +++
 1 file changed, 3 insertions(+)

drivers/staging/comedi/drivers/ni_mio_common.c +3 -0

index 8adb535..3a86d48 100644
@@ -4407,6 +4407,9 @@ static int ni_E_init(struct comedi_device *dev)
 							&ni_gpct_read_register,
 							counter_variant,
 							NUM_GPCT);
+	if (!devpriv->counter_dev)
+		return -ENOMEM;
+
 	/* General purpose counters */
 	for (j = 0; j < NUM_GPCT; ++j) {
 		s = &dev->subdevices[NI_GPCT_SUBDEV(j)];

Signature · 1 line

1.8.5.3