Skip to contentSkip to conversation

python-numpy: fix compile error for qemumips

PATCH In review Chen Qi 3 participants 6 messages Feb 26, 2014 – Feb 27, 2014

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

cover python-numpy: fix compile error for qemumips

The following changes since commit 5a4b5c6b8ebd5f8d29888aafcd9608e03717bcd5:

runqemu: Use readlink instead of realpath (2014-02-25 21:29:51 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib ChenQi/python-numpy
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/python-numpy

Chen Qi (1):
python-numpy: fix compile error for qemumips

 meta/recipes-devtools/python/python-numpy_1.7.0.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 python-numpy: fix compile error for qemumips

When building python-numpy for qemumips, the following error appeared.

cp: cannot stat `xxx/python-numpy/1.7.0-r1/*config.h': No such file or directory

This is because for qemumips, there are no such files in SRC_URI. And actually we don't need such files. So for qemumips, the `cp' command is expected to fail.

The same problem appeared for qemumips64 and qemuppc.

This patch fixes this compiling error.

---
 meta/recipes-devtools/python/python-numpy_1.7.0.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/python/python-numpy_1.7.0.bb +1 -1
index 3fa485e..43f5a40 100644
@@ -45,7 +45,7 @@ do_compile_prepend_class-target() {
     BUILD_SYS=${BUILD_SYS} HOST_SYS=${HOST_SYS} \
     ${STAGING_BINDIR_NATIVE}/python-native/python setup.py build ${DISTUTILS_BUILD_ARGS} || \
     true
-    cp ${WORKDIR}/*config.h ${S}/build/$(ls ${S}/build | grep src)/numpy/core/include/numpy/
+    cp ${WORKDIR}/*config.h ${S}/build/$(ls ${S}/build | grep src)/numpy/core/include/numpy/ || true
 }
 
 FILES_${PN}-staticdev += "${PYTHON_SITEPACKAGES_DIR}/numpy/core/lib/*.a"
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 3 lines · Chen Qi

This is because for qemumips, there are no such files in SRC_URI. And actually we don't need such files. So for qemumips, the `cp' command is expected to fail.

Those files contain the definitions of things like word size and byte ordering, so unless I've misunderstood the build process for numpy what's happening with this patch is that it's using the host environment.

Ross

author
#3 lore raw
Quoted 4 lines · Ross
Quoted 3 lines · Chen Qi

This is because for qemumips, there are no such files in SRC_URI. And actually we don't need such files. So for qemumips, the `cp' command is expected to fail.

Quoted 8 lines

Those files contain the definitions of things like word size and byte ordering, so unless I've misunderstood the build process for numpy what's happening with this patch is that it's using the host environment.

Ross

Those files are there already.
For archs like x86, we first replace them so that the build process doesn't fail (according to the comments in the recipe); but for mips/ppc, we don't need to do so, the build just succeeds.

chenqi@pek-hostel-vm07:~/poky/build-qemumips64 [0] $ ls tmp/work/mips64-poky-linux/python-numpy/1.7.0-r1/numpy-1.7.0/build/src.linux-i686-2.7/numpy/core/include/numpy/ config.h __multiarray_api.c __multiarray_api.h multiarray_api.txt _numpyconfig.h __ufunc_api.c __ufunc_api.h ufunc_api.txt __umath_generated.c

Best Regards,
Chen Qi

#4 lore raw
Quoted 19 lines · ChenQi
Quoted 4 lines · Ross
Quoted 3 lines · Chen Qi

This is because for qemumips, there are no such files in SRC_URI. And actually we don't need such files. So for qemumips, the `cp' command is expected to fail.

Quoted 8 lines

Those files contain the definitions of things like word size and byte ordering, so unless I've misunderstood the build process for numpy what's happening with this patch is that it's using the host environment.

Ross

Those files are there already.
For archs like x86, we first replace them so that the build process doesn't fail (according to the comments in the recipe); but for mips/ppc, we don't need to do so, the build just succeeds.

Quoted 5 lines

chenqi@pek-hostel-vm07:~/poky/build-qemumips64 [0] $ ls tmp/work/mips64-poky-linux/python-numpy/1.7.0-r1/numpy-1.7.0/build/src.linux-i686-2.7/numpy/core/include/numpy/ config.h __multiarray_api.c __multiarray_api.h multiarray_api.txt
_numpyconfig.h __ufunc_api.c __ufunc_api.h ufunc_api.txt
__umath_generated.c

Ross' point stands, its just using the values from the host (build) system. If your build system was mips it might stand a chance of working, I suspect you're building on x86 though and x86 != mips.

Cheers,

Richard

author
#5 lore raw
Quoted 24 lines · Richard Purdie
Quoted 18 lines · ChenQi
Quoted 4 lines · Ross
Quoted 3 lines · Chen Qi

This is because for qemumips, there are no such files in SRC_URI. And actually we don't need such files. So for qemumips, the `cp' command is expected to fail.

Quoted 8 lines

Those files contain the definitions of things like word size and byte ordering, so unless I've misunderstood the build process for numpy what's happening with this patch is that it's using the host environment.

Ross

Those files are there already.
For archs like x86, we first replace them so that the build process doesn't fail (according to the comments in the recipe); but for mips/ppc, we don't need to do so, the build just succeeds.

Quoted 5 lines

chenqi@pek-hostel-vm07:~/poky/build-qemumips64 [0] $ ls tmp/work/mips64-poky-linux/python-numpy/1.7.0-r1/numpy-1.7.0/build/src.linux-i686-2.7/numpy/core/include/numpy/ config.h __multiarray_api.c __multiarray_api.h multiarray_api.txt
_numpyconfig.h __ufunc_api.c __ufunc_api.h ufunc_api.txt
__umath_generated.c

Quoted 10 lines

Ross' point stands, its just using the values from the host (build) system. If your build system was mips it might stand a chance of working, I suspect you're building on x86 though and x86 != mips.

Cheers,

Richard

Ross & Richard,

Thanks for making it clear.
Yesterday, I built it and tested it on target. As some basic tests passed, I thought everything was OK. Now I've checked those files, and obviously I've made a mistake.
I'll rework on this one.

Best Regards,
Chen Qi