security-flags: Deal with powerpc build issues
PATCH 1/1 security-flags: Deal with powerpc build issues
Building powerpc machines with the standard security flags generated numerous build failures. Use a reduced set of flags for now to avoid linker issues and other compile failures.
---
meta/conf/distro/include/security_flags.inc +8 -0
@@ -2,6 +2,14 @@ SECURITY_CFLAGS ?= "-fstack-protector-all -pie -fpie -D_FORTIFY_SOURCE=2" SECURITY_NO_PIE_CFLAGS ?= "-fstack-protector-all -D_FORTIFY_SOURCE=2" SECURITY_LDFLAGS ?= "-Wl,-z,relro,-z,now" +# powerpc does not get on with pie for reasons not looked into as yet +SECURITY_CFLAGS_powerpc = "-fstack-protector-all -D_FORTIFY_SOURCE=2" +# Deal with ppc specific linker failures when using the cflags +SECURITY_CFLAGS_pn-dbus_powerpc = "" +SECURITY_CFLAGS_pn-dbus-ptest_powerpc = "" +SECURITY_CFLAGS_pn-libmatchbox_powerpc = "" +SECURITY_CFLAGS_pn-webkit-gtk = "" + SECURITY_CFLAGS_pn-aspell = "${SECURITY_NO_PIE_CFLAGS}" SECURITY_CFLAGS_pn-beecrypt = "${SECURITY_NO_PIE_CFLAGS}" # Curl seems to check for FORTIFY_SOURCE in CFLAGS, but even assigned
Quoted 13 lines · Richard Purdie
Building powerpc machines with the standard security flags generated numerous build failures. Use a reduced set of flags for now to avoid linker issues and other compile failures.
Signed-off-by Richard Purdie <[email protected]>---
meta/conf/distro/include/security_flags.inc +0
-0
meta/conf/distro/include/security_flags.inc SECURITY_CFLAGS ?= "-fstack-protector-all -pie -fpie -D_FORTIFY_SOURCE=2" · line 11
Quoted 10 lines
meta/conf/distro/include/security_flags.inc +7
-0@@ -2,6 +2,14 @@ SECURITY_CFLAGS ?= "-fstack-protector-all -pie -fpie -D_FORTIFY_SOURCE=2" SECURITY_NO_PIE_CFLAGS ?= "-fstack-protector-all -D_FORTIFY_SOURCE=2" SECURITY_LDFLAGS ?= "-Wl,-z,relro,-z,now" +# powerpc does not get on with pie for reasons not looked into as yet +SECURITY_CFLAGS_powerpc = "-fstack-protector-all -D_FORTIFY_SOURCE=2" +# Deal with ppc specific linker failures when using the cflags +SECURITY_CFLAGS_pn-dbus_powerpc = "" +SECURITY_CFLAGS_pn-dbus-ptest_powerpc = "" +SECURITY_CFLAGS_pn-libmatchbox_powerpc = "" +SECURITY_CFLAGS_pn-webkit-gtk = ""
The change for webkit doesn't seem to be PowerPC specific? If it needs to be here, shouldn't it be in a separate change, or at least documented in the change log?
Quoted 4 lines
meta/conf/distro/include/security_flags.inc +1
-0+ SECURITY_CFLAGS_pn-aspell = "${SECURITY_NO_PIE_CFLAGS}" SECURITY_CFLAGS_pn-beecrypt = "${SECURITY_NO_PIE_CFLAGS}" # Curl seems to check for FORTIFY_SOURCE in CFLAGS, but even assigned
Signature · 4 lines
------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------
Quoted 17 lines · Gary Thomas
Quoted 16 lines · Richard Purdie
Building powerpc machines with the standard security flags generated numerous build failures. Use a reduced set of flags for now to avoid linker issues and other compile failures.
Signed-off-by Richard Purdie <[email protected]>---
meta/conf/distro/include/security_flags.inc +0
-0@@ -2,6 +2,14 @@ SECURITY_CFLAGS ?= "-fstack-protector-all -pie -fpie -D_FORTIFY_SOURCE=2" SECURITY_NO_PIE_CFLAGS ?= "-fstack-protector-all -D_FORTIFY_SOURCE=2" SECURITY_LDFLAGS ?= "-Wl,-z,relro,-z,now"
Quoted 11 lines
meta/conf/distro/include/security_flags.inc SECURITY_CFLAGS ?= "-fstack-protector-all -pie -fpie -D_FORTIFY_SOURCE=2" · line 11
Quoted 7 lines
meta/conf/distro/include/security_flags.inc +7
-0+# powerpc does not get on with pie for reasons not looked into as yet +SECURITY_CFLAGS_powerpc = "-fstack-protector-all -D_FORTIFY_SOURCE=2" +# Deal with ppc specific linker failures when using the cflags +SECURITY_CFLAGS_pn-dbus_powerpc = "" +SECURITY_CFLAGS_pn-dbus-ptest_powerpc = "" +SECURITY_CFLAGS_pn-libmatchbox_powerpc = "" +SECURITY_CFLAGS_pn-webkit-gtk = ""The change for webkit doesn't seem to be PowerPC specific? If it needs to be here, shouldn't it be in a separate change, or at least documented in the change log?
Sorry, I'll make that powerpc specific, it was meant to be...
Cheers,
Richard