Skip to contentSkip to conversation

ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'

PATCH Superseded Jarkko Nikula 3 participants 4 messages Feb 26, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'

Some kernel configurations can cause following build error:

sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
memcpy_fromio(&fw_tstamp,
^
cc1: some warnings being treated as errors

Fix this by including <asm/io.h> explicitly.

---
Also sst-dsp., sst-baytrail-dsp.c and sst-haswell-dsp.c are using memcpy_fromio/_toio but there <asm/io.h> seems to come via <linux/dma-mapping.h> or <linux/io.h> so I didn't touch them.

---
 sound/soc/intel/sst-baytrail-ipc.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/intel/sst-baytrail-ipc.c +1 -0
index 8c91a68b90bc..8b067e34094e 100644
@@ -27,6 +27,7 @@
 #include <linux/kthread.h>
 #include <linux/firmware.h>
 #include <asm/div64.h>
+#include <asm/io.h>
 
 #include "sst-baytrail-ipc.h"
 #include "sst-dsp.h"
Signature · 6 lines
1.8.5.3

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
#1 lore raw

At Wed, 26 Feb 2014 15:12:21 +0200,

Quoted 10 lines · Jarkko Nikula

Some kernel configurations can cause following build error:

sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
memcpy_fromio(&fw_tstamp,
^
cc1: some warnings being treated as errors

Fix this by including <asm/io.h> explicitly.

linux/io.h should be included instead, as checkpatch.pl would suggest.

Takashi

Quoted 30 lines

---
Also sst-dsp., sst-baytrail-dsp.c and sst-haswell-dsp.c are using memcpy_fromio/_toio but there <asm/io.h> seems to come via <linux/dma-mapping.h> or <linux/io.h> so I didn't touch them.

---
 sound/soc/intel/sst-baytrail-ipc.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/intel/sst-baytrail-ipc.c +1 -0
index 8c91a68b90bc..8b067e34094e 100644
@@ -27,6 +27,7 @@
 #include <linux/kthread.h>
 #include <linux/firmware.h>
 #include <asm/div64.h>
+#include <asm/io.h>
 
 #include "sst-baytrail-ipc.h"
 #include "sst-dsp.h"
Signature · 6 lines
1.8.5.3

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#2 lore raw

PATCH v2 1/1 ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'

In reply to Jarkko Nikula

Some kernel configurations can cause following build error:

sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
memcpy_fromio(&fw_tstamp,
^
cc1: some warnings being treated as errors

Fix this by including <linux/io.h> explicitly.

---
v2: including <linux/io.h> instead of <asm/io.h>. Thanks to Takashi Iwai for noticing (checkpatch.pl tells it too).

Also sst-dsp., sst-baytrail-dsp.c and sst-haswell-dsp.c are using memcpy_fromio/_toio but there <asm/io.h> seems to come via <linux/dma-mapping.h> or <linux/io.h> so I didn't touch them.

---
 sound/soc/intel/sst-baytrail-ipc.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/intel/sst-baytrail-ipc.c +1 -0
index 8c91a68b90bc..c12e194bbc6b 100644
@@ -26,6 +26,7 @@
 #include <linux/platform_device.h>
 #include <linux/kthread.h>
 #include <linux/firmware.h>
+#include <linux/io.h>
 #include <asm/div64.h>
 
 #include "sst-baytrail-ipc.h"
Signature · 6 lines
1.8.5.3

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
maintainer Applied
#3 lore raw
Quoted 7 lines · Jarkko Nikula

Some kernel configurations can cause following build error:

sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
memcpy_fromio(&fw_tstamp,
^
cc1: some warnings being treated as errors

Applied, thanks.