Skip to contentSkip to conversation

ode: Explicitly disable double-precision with PACKAGECONFIG

PATCH In review Martin Jansa 2 participants 7 messages Feb 26, 2014 – Feb 27, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ode: Explicitly disable double-precision with PACKAGECONFIG

* when it's left for autodetection, configure fails for qemux86* when == and configure calls AC_TRY_RUN

---
 meta-oe/recipes-support/ode/ode_0.9.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta-oe/recipes-support/ode/ode_0.9.bb +4 -0
index 1f3a5ca..8b9955e 100644
@@ -22,3 +22,7 @@ do_configure_append() {
 
 FILES_${PN} = "${libdir}/lib*${SOLIBS}"
 
+PACKAGECONFIG ?= ""
+# if it isn't explicitly selected and "$build_os" == "$target_os", then configure will run
+# series of AC_TRY_RUN which won't work for cross-compilation and configure fails
+PACKAGECONFIG[double-precision] = "--enable-double-precision,--disable-double-precision"
Signature · 1 line
1.9.0
#1 lore raw

PATCH 2/2 ode: upgrade to 0.13

---
 meta-oe/recipes-support/ode/ode_0.13.bb | 27 +++++++++++++++++++++++++++
 meta-oe/recipes-support/ode/ode_0.9.bb  | 28 ----------------------------
 2 files changed, 27 insertions(+), 28 deletions(-)
 create mode 100644 meta-oe/recipes-support/ode/ode_0.13.bb
 delete mode 100644 meta-oe/recipes-support/ode/ode_0.9.bb
meta-oe/recipes-support/ode/ode_0.13.bb new file +27 -0
new file mode 100644
index 0000000..8e9eb15
@@ -0,0 +1,27 @@
+SUMMARY = "ODE is an Open Source Physics Engine"
+SECTION = "libs"
+HOMEPAGE = "http://www.ode.org"
+LICENSE = "LGPLv2.1 & BSD"
+LIC_FILES_CHKSUM = " \
+    file://COPYING;md5=1de906ee96808d9776dd72a5f9a79a22 \
+    file://LICENSE.TXT;md5=771782cb6245c7fbbe74bc0ec059beff \
+"
+# LICENSE-BSD.TXT is missing in 0.13 tarball, but COPYING still says it's dual licensed
+# and svn repo still contains LICENSE-BSD.TXT so maybe it will return in next tarball
+# file://LICENSE-BSD.TXT;md5=c74e6304a772117e059458fb9763a928
+
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/opende/ode-${PV}.tar.bz2"
+SRC_URI[md5sum] = "04b32c9645c147e18caff7a597a19f84"
+SRC_URI[sha256sum] = "34ce3e236e313bf109a0cb5546d2fca462aed99f29a42e62bc1463b803c31ef9"
+
+inherit autotools binconfig
+
+EXTRA_OECONF = "--disable-demos --enable-soname"
+
+FILES_${PN} = "${libdir}/lib*${SOLIBS}"
+
+PACKAGECONFIG ?= ""
+# if it isn't explicitly selected and "$build_os" == "$target_os", then configure will run
+# series of AC_TRY_RUN which won't work for cross-compilation and configure fails
+PACKAGECONFIG[double-precision] = "--enable-double-precision,--disable-double-precision"
meta-oe/recipes-support/ode/ode_0.9.bb deleted +0 -28
deleted file mode 100644
index 8b9955e..0000000
@@ -1,28 +0,0 @@
-SUMMARY = "ODE is an Open Source Physics Engine"
-SECTION = "libs"
-HOMEPAGE = "http://www.ode.org"
-LICENSE = "LGPLv2.1 & BSD"
-LIC_FILES_CHKSUM = "file://LICENSE-BSD.TXT;md5=c74e6304a772117e059458fb9763a928 \
-                    file://LICENSE.TXT;md5=771782cb6245c7fbbe74bc0ec059beff"
-
-
-SRC_URI = "${SOURCEFORGE_MIRROR}/opende/ode-src-${PV}.zip \
-           file://install.patch"
-
-SRC_URI[md5sum] = "4c03759b76a0649a6d5108c8e172e1e4"
-SRC_URI[sha256sum] = "460d0851b743b1f144ef2a8259004d6774504c95d08e9357a96a296111496feb"
-
-inherit autotools binconfig
-
-EXTRA_OECONF = "--disable-demos --enable-soname"
-
-do_configure_append() {
-    echo "#define dInfinity DBL_MAX" >>include/ode/config.h
-}
-
-FILES_${PN} = "${libdir}/lib*${SOLIBS}"
-
-PACKAGECONFIG ?= ""
-# if it isn't explicitly selected and "$build_os" == "$target_os", then configure will run
-# series of AC_TRY_RUN which won't work for cross-compilation and configure fails
-PACKAGECONFIG[double-precision] = "--enable-double-precision,--disable-double-precision"
Signature · 1 line
1.9.0
#2 lore raw

Re: [meta-oe][PATCH 2/2] ode: upgrade to 0.13

Quoted 8 lines · Martin Jansa
---
 meta-oe/recipes-support/ode/ode_0.13.bb | 27 +++++++++++++++++++++++++++
 meta-oe/recipes-support/ode/ode_0.9.bb  | 28 ----------------------------
 2 files changed, 27 insertions(+), 28 deletions(-)
 create mode 100644 meta-oe/recipes-support/ode/ode_0.13.bb
 delete mode 100644 meta-oe/recipes-support/ode/ode_0.9.bb

git format-patch -M please

Quoted 6 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +0 -0
new file mode 100644
index 0000000..8e9eb15

meta-oe/recipes-support/ode/ode_0.13.bb line 10

Quoted 10 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +10 -0
@@ -0,0 +1,27 @@
+SUMMARY = "ODE is an Open Source Physics Engine"
+SECTION = "libs"
+HOMEPAGE = "http://www.ode.org"
+LICENSE = "LGPLv2.1 & BSD"
+LIC_FILES_CHKSUM = " \
+    file://COPYING;md5=1de906ee96808d9776dd72a5f9a79a22 \
+    file://LICENSE.TXT;md5=771782cb6245c7fbbe74bc0ec059beff \
+"
+# LICENSE-BSD.TXT is missing in 0.13 tarball, but COPYING still says it's dual licensed
+# and svn repo still contains LICENSE-BSD.TXT so maybe it will return in next tarball

can this be added as a patch ?

Quoted 58 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +17 -0
+# file://LICENSE-BSD.TXT;md5=c74e6304a772117e059458fb9763a928
+
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/opende/ode-${PV}.tar.bz2"
+SRC_URI[md5sum] = "04b32c9645c147e18caff7a597a19f84"
+SRC_URI[sha256sum] = "34ce3e236e313bf109a0cb5546d2fca462aed99f29a42e62bc1463b803c31ef9"
+
+inherit autotools binconfig
+
+EXTRA_OECONF = "--disable-demos --enable-soname"
+
+FILES_${PN} = "${libdir}/lib*${SOLIBS}"
+
+PACKAGECONFIG ?= ""
+# if it isn't explicitly selected and "$build_os" == "$target_os", then configure will run
+# series of AC_TRY_RUN which won't work for cross-compilation and configure fails
+PACKAGECONFIG[double-precision] = "--enable-double-precision,--disable-double-precision"
meta-oe/recipes-support/ode/ode_0.9.bb deleted +0 -29
deleted file mode 100644
index 8b9955e..0000000
@@ -1,28 +0,0 @@
-SUMMARY = "ODE is an Open Source Physics Engine"
-SECTION = "libs"
-HOMEPAGE = "http://www.ode.org"
-LICENSE = "LGPLv2.1 & BSD"
-LIC_FILES_CHKSUM = "file://LICENSE-BSD.TXT;md5=c74e6304a772117e059458fb9763a928 \
-                    file://LICENSE.TXT;md5=771782cb6245c7fbbe74bc0ec059beff"
-
-
-SRC_URI = "${SOURCEFORGE_MIRROR}/opende/ode-src-${PV}.zip \
-           file://install.patch"
-
-SRC_URI[md5sum] = "4c03759b76a0649a6d5108c8e172e1e4"
-SRC_URI[sha256sum] = "460d0851b743b1f144ef2a8259004d6774504c95d08e9357a96a296111496feb"
-
-inherit autotools binconfig
-
-EXTRA_OECONF = "--disable-demos --enable-soname"
-
-do_configure_append() {
-    echo "#define dInfinity DBL_MAX" >>include/ode/config.h
-}
-
-FILES_${PN} = "${libdir}/lib*${SOLIBS}"
-
-PACKAGECONFIG ?= ""
-# if it isn't explicitly selected and "$build_os" == "$target_os", then configure will run
-# series of AC_TRY_RUN which won't work for cross-compilation and configure fails
-PACKAGECONFIG[double-precision] = "--enable-double-precision,--disable-double-precision"
--

1.9.0

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw

Re: [meta-oe][PATCH 2/2] ode: upgrade to 0.13

Quoted 22 lines · Khem Raj
Quoted 8 lines · Martin Jansa
---
 meta-oe/recipes-support/ode/ode_0.13.bb | 27 +++++++++++++++++++++++++++
 meta-oe/recipes-support/ode/ode_0.9.bb  | 28 ----------------------------
 2 files changed, 27 insertions(+), 28 deletions(-)
 create mode 100644 meta-oe/recipes-support/ode/ode_0.13.bb
 delete mode 100644 meta-oe/recipes-support/ode/ode_0.9.bb

git format-patch -M please

Quoted 10 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +4 -0
new file mode 100644
index 0000000..8e9eb15
@@ -0,0 +1,27 @@
+SUMMARY = "ODE is an Open Source Physics Engine"
+SECTION = "libs"
+HOMEPAGE = "http://www.ode.org"
+LICENSE = "LGPLv2.1 & BSD"
Quoted 8 lines

meta-oe/recipes-support/ode/ode_0.13.bb line 10

Quoted 6 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +6 -0
+LIC_FILES_CHKSUM = " \
+    file://COPYING;md5=1de906ee96808d9776dd72a5f9a79a22 \
+    file://LICENSE.TXT;md5=771782cb6245c7fbbe74bc0ec059beff \
+"
+# LICENSE-BSD.TXT is missing in 0.13 tarball, but COPYING still says it's dual licensed
+# and svn repo still contains LICENSE-BSD.TXT so maybe it will return in next tarball

can this be added as a patch ?

Yes, but I don't know the real intentions in upstream, so I would rather keep it as comment and return it in next release (if they return it as well).

Quoted 63 lines
Quoted 55 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +17 -0
+# file://LICENSE-BSD.TXT;md5=c74e6304a772117e059458fb9763a928
+
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/opende/ode-${PV}.tar.bz2"
+SRC_URI[md5sum] = "04b32c9645c147e18caff7a597a19f84"
+SRC_URI[sha256sum] = "34ce3e236e313bf109a0cb5546d2fca462aed99f29a42e62bc1463b803c31ef9"
+
+inherit autotools binconfig
+
+EXTRA_OECONF = "--disable-demos --enable-soname"
+
+FILES_${PN} = "${libdir}/lib*${SOLIBS}"
+
+PACKAGECONFIG ?= ""
+# if it isn't explicitly selected and "$build_os" == "$target_os", then configure will run
+# series of AC_TRY_RUN which won't work for cross-compilation and configure fails
+PACKAGECONFIG[double-precision] = "--enable-double-precision,--disable-double-precision"
meta-oe/recipes-support/ode/ode_0.9.bb deleted +0 -29
deleted file mode 100644
index 8b9955e..0000000
@@ -1,28 +0,0 @@
-SUMMARY = "ODE is an Open Source Physics Engine"
-SECTION = "libs"
-HOMEPAGE = "http://www.ode.org"
-LICENSE = "LGPLv2.1 & BSD"
-LIC_FILES_CHKSUM = "file://LICENSE-BSD.TXT;md5=c74e6304a772117e059458fb9763a928 \
-                    file://LICENSE.TXT;md5=771782cb6245c7fbbe74bc0ec059beff"
-
-
-SRC_URI = "${SOURCEFORGE_MIRROR}/opende/ode-src-${PV}.zip \
-           file://install.patch"
-
-SRC_URI[md5sum] = "4c03759b76a0649a6d5108c8e172e1e4"
-SRC_URI[sha256sum] = "460d0851b743b1f144ef2a8259004d6774504c95d08e9357a96a296111496feb"
-
-inherit autotools binconfig
-
-EXTRA_OECONF = "--disable-demos --enable-soname"
-
-do_configure_append() {
-    echo "#define dInfinity DBL_MAX" >>include/ode/config.h
-}
-
-FILES_${PN} = "${libdir}/lib*${SOLIBS}"
-
-PACKAGECONFIG ?= ""
-# if it isn't explicitly selected and "$build_os" == "$target_os", then configure will run
-# series of AC_TRY_RUN which won't work for cross-compilation and configure fails
-PACKAGECONFIG[double-precision] = "--enable-double-precision,--disable-double-precision"
--

1.9.0

Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw

Re: [meta-oe][PATCH 2/2] ode: upgrade to 0.13

Quoted 32 lines · Martin Jansa
Quoted 22 lines · Khem Raj
Quoted 8 lines · Martin Jansa

---
meta-oe/recipes-support/ode/ode_0.13.bb | 27 +++++++++++++++++++++++++++ meta-oe/recipes-support/ode/ode_0.9.bb | 28 ----------------------------

2 files changed, 27 insertions(+), 28 deletions(-)

create mode 100644 meta-oe/recipes-support/ode/ode_0.13.bb delete mode 100644 meta-oe/recipes-support/ode/ode_0.9.bb

git format-patch -M please

Quoted 10 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +4 -0
new file mode 100644
index 0000000..8e9eb15
@@ -0,0 +1,27 @@
+SUMMARY = "ODE is an Open Source Physics Engine"
+SECTION = "libs"
+HOMEPAGE = "http://www.ode.org"
+LICENSE = "LGPLv2.1 & BSD"
Quoted 8 lines

meta-oe/recipes-support/ode/ode_0.13.bb line 10

Quoted 6 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +6 -0
+LIC_FILES_CHKSUM = " \
+    file://COPYING;md5=1de906ee96808d9776dd72a5f9a79a22 \
+    file://LICENSE.TXT;md5=771782cb6245c7fbbe74bc0ec059beff \
+"
+# LICENSE-BSD.TXT is missing in 0.13 tarball, but COPYING still says it's dual licensed
+# and svn repo still contains LICENSE-BSD.TXT so maybe it will return in next tarball

can this be added as a patch ?

Quoted 3 lines

Yes, but I don't know the real intentions in upstream, so I would rather keep it as comment and return it in next release (if they return it as well).

OK fair.

#5 lore raw

Re: [meta-oe][PATCH 2/2] ode: upgrade to 0.13

In reply to Khem Raj
Quoted 11 lines · Khem Raj
Quoted 8 lines · Martin Jansa
---
 meta-oe/recipes-support/ode/ode_0.13.bb | 27 +++++++++++++++++++++++++++
 meta-oe/recipes-support/ode/ode_0.9.bb  | 28 ----------------------------
 2 files changed, 27 insertions(+), 28 deletions(-)
 create mode 100644 meta-oe/recipes-support/ode/ode_0.13.bb
 delete mode 100644 meta-oe/recipes-support/ode/ode_0.9.bb

git format-patch -M please

It was sent with -M..

-M48 and higher sends it like this and the default is 50%

Quoted 81 lines
Quoted 6 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +0 -0
new file mode 100644
index 0000000..8e9eb15

meta-oe/recipes-support/ode/ode_0.13.bb line 10

Quoted 10 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +10 -0
@@ -0,0 +1,27 @@
+SUMMARY = "ODE is an Open Source Physics Engine"
+SECTION = "libs"
+HOMEPAGE = "http://www.ode.org"
+LICENSE = "LGPLv2.1 & BSD"
+LIC_FILES_CHKSUM = " \
+    file://COPYING;md5=1de906ee96808d9776dd72a5f9a79a22 \
+    file://LICENSE.TXT;md5=771782cb6245c7fbbe74bc0ec059beff \
+"
+# LICENSE-BSD.TXT is missing in 0.13 tarball, but COPYING still says it's dual licensed
+# and svn repo still contains LICENSE-BSD.TXT so maybe it will return in next tarball

can this be added as a patch ?

Quoted 54 lines
meta-oe/recipes-support/ode/ode_0.13.bb new file +17 -0
+# file://LICENSE-BSD.TXT;md5=c74e6304a772117e059458fb9763a928
+
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/opende/ode-${PV}.tar.bz2"
+SRC_URI[md5sum] = "04b32c9645c147e18caff7a597a19f84"
+SRC_URI[sha256sum] = "34ce3e236e313bf109a0cb5546d2fca462aed99f29a42e62bc1463b803c31ef9"
+
+inherit autotools binconfig
+
+EXTRA_OECONF = "--disable-demos --enable-soname"
+
+FILES_${PN} = "${libdir}/lib*${SOLIBS}"
+
+PACKAGECONFIG ?= ""
+# if it isn't explicitly selected and "$build_os" == "$target_os", then configure will run
+# series of AC_TRY_RUN which won't work for cross-compilation and configure fails
+PACKAGECONFIG[double-precision] = "--enable-double-precision,--disable-double-precision"
meta-oe/recipes-support/ode/ode_0.9.bb deleted +0 -29
deleted file mode 100644
index 8b9955e..0000000
@@ -1,28 +0,0 @@
-SUMMARY = "ODE is an Open Source Physics Engine"
-SECTION = "libs"
-HOMEPAGE = "http://www.ode.org"
-LICENSE = "LGPLv2.1 & BSD"
-LIC_FILES_CHKSUM = "file://LICENSE-BSD.TXT;md5=c74e6304a772117e059458fb9763a928 \
-                    file://LICENSE.TXT;md5=771782cb6245c7fbbe74bc0ec059beff"
-
-
-SRC_URI = "${SOURCEFORGE_MIRROR}/opende/ode-src-${PV}.zip \
-           file://install.patch"
-
-SRC_URI[md5sum] = "4c03759b76a0649a6d5108c8e172e1e4"
-SRC_URI[sha256sum] = "460d0851b743b1f144ef2a8259004d6774504c95d08e9357a96a296111496feb"
-
-inherit autotools binconfig
-
-EXTRA_OECONF = "--disable-demos --enable-soname"
-
-do_configure_append() {
-    echo "#define dInfinity DBL_MAX" >>include/ode/config.h
-}
-
-FILES_${PN} = "${libdir}/lib*${SOLIBS}"
-
-PACKAGECONFIG ?= ""
-# if it isn't explicitly selected and "$build_os" == "$target_os", then configure will run
-# series of AC_TRY_RUN which won't work for cross-compilation and configure fails
-PACKAGECONFIG[double-precision] = "--enable-double-precision,--disable-double-precision"
--

1.9.0

Quoted 4 lines

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#6 lore raw
In reply to Martin Jansa
Quoted 2 lines · Martin Jansa

* when it's left for autodetection, configure fails for qemux86* when == and configure calls AC_TRY_RUN

Missing "$build_os" == "$target_os" added in master-next branch.

Quoted 21 lines
---
 meta-oe/recipes-support/ode/ode_0.9.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta-oe/recipes-support/ode/ode_0.9.bb +4 -0
index 1f3a5ca..8b9955e 100644
@@ -22,3 +22,7 @@ do_configure_append() {
 
 FILES_${PN} = "${libdir}/lib*${SOLIBS}"
 
+PACKAGECONFIG ?= ""
+# if it isn't explicitly selected and "$build_os" == "$target_os", then configure will run
+# series of AC_TRY_RUN which won't work for cross-compilation and configure fails
+PACKAGECONFIG[double-precision] = "--enable-double-precision,--disable-double-precision"
Signature · 1 line
1.9.0
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]