Skip to contentSkip to conversation

video: backlight: gpio-backlight: Add DT support.

PATCH In review Denis Carikli 3 participants 4 messages Feb 27, 2014 – Mar 5, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v12 1/1 video: backlight: gpio-backlight: Add DT support.

---
ChangeLog v11-resend->v12:
- Moved the Cc from the commit message to the "email patch".
- The documentation is now more clear.
- The unnecessary default_on variable was removed.
- gbl->fbdev was already NULL and didn't need to be re-assigned, so the re-assignement was removed.
- The of_device_id struct and .of_match_table are now guarded against the driver beeing compiled without CONFIG_OF.

ChangeLog v11->v11-resend:
- Removed the Cc list because it's only one patch.

ChangeLog v10->v11:
- Shrinked the Cc list.
- Fixed the of_match_table warning.

ChangeLog v9->v10:
- Only the respective maintainers, or people who responded to the patch were kept in the Cc.
- The unnecessary of_match_ptr in of_match_table was removed.

ChangeLog v8->v9:
- Added Shawn Guo in the Cc list.
- The default-brightness-level is now a boolean default-on property, the gpio is only touched if the gpio-backlight driver instance probes.
- The code and documentation was updated accordingly.

ChangeLog v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm, That way we avoid having to handle the case where it's not set, which means that we would need not to set the gpio, but still report a brightness value for sysfs, when not all gpio controllers are able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight: gpio_backlight: Use a default state enum." patch was then dropped, becuase it is not necessary anymore.

ChangeLog v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.

ChangeLog v5->v6:
- The default state handling was reworked:
- it's now called default-state, and looks like the gpio-leds default-state.
- it now has a "keep" option, like for the gpio-leds.
- that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.

ChangeLog v4->v5:
- The default-brightness property now defaults to 0 in the driver.
- def_value int becomes a bool.
- The check for the gpio validity has been reworked.

---
 .../bindings/video/backlight/gpio-backlight.txt    |   16 ++++++
 drivers/video/backlight/gpio_backlight.c           |   58 +++++++++++++++++---
 2 files changed, 67 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt new file +16 -0
new file mode 100644
index 0000000..321be66
@@ -0,0 +1,16 @@
+gpio-backlight bindings
+
+Required properties:
+  - compatible: "gpio-backlight"
+  - gpios: describes the gpio that is used for enabling/disabling the backlight.
+    refer to bindings/gpio/gpio.txt for more details.
+
+Optional properties:
+  - default-on: enable the backlight at boot.
+
+Example:
+	backlight {
+		compatible = "gpio-backlight";
+		gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
+		default-on;
+	};
drivers/video/backlight/gpio_backlight.c +51 -7

110 lines not on this page · raw message

Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Acked-by on v12 1/1
#1 lore raw
Quoted 57 lines · Denis Carikli

---
ChangeLog v11-resend->v12:
- Moved the Cc from the commit message to the "email patch".
- The documentation is now more clear.
- The unnecessary default_on variable was removed.
- gbl->fbdev was already NULL and didn't need to be re-assigned, so the re-assignement was removed.
- The of_device_id struct and .of_match_table are now guarded against the driver beeing compiled without CONFIG_OF.

ChangeLog v11->v11-resend:
- Removed the Cc list because it's only one patch.

ChangeLog v10->v11:
- Shrinked the Cc list.
- Fixed the of_match_table warning.

ChangeLog v9->v10:
- Only the respective maintainers, or people who responded to the patch were kept in the Cc.
- The unnecessary of_match_ptr in of_match_table was removed.

ChangeLog v8->v9:
- Added Shawn Guo in the Cc list.
- The default-brightness-level is now a boolean default-on property, the gpio is only touched if the gpio-backlight driver instance probes.
- The code and documentation was updated accordingly.

ChangeLog v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm, That way we avoid having to handle the case where it's not set, which means that we would need not to set the gpio, but still report a brightness value for sysfs, when not all gpio controllers are able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight: gpio_backlight: Use a default state enum." patch was then dropped, becuase it is not necessary anymore.

ChangeLog v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.

ChangeLog v5->v6:
- The default state handling was reworked:
- it's now called default-state, and looks like the gpio-leds default-state.
- it now has a "keep" option, like for the gpio-leds.
- that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.

ChangeLog v4->v5:
- The default-brightness property now defaults to 0 in the driver.
- def_value int becomes a bool.
- The check for the gpio validity has been reworked.

Quoted 5 lines
---
 .../bindings/video/backlight/gpio-backlight.txt    |   16 ++++++
 drivers/video/backlight/gpio_backlight.c           |   58 +++++++++++++++++---
 2 files changed, 67 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt

Patch looks good to me now, I just want to see if Jingoo and/or Bryan with to add anything. If they don't respond within the next couple of days I'll apply the patch.

Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Acked-by
#2 lore raw
Quoted 65 lines · Lee Jones
Quoted 57 lines · Denis Carikli

---
ChangeLog v11-resend->v12:
- Moved the Cc from the commit message to the "email patch".
- The documentation is now more clear.
- The unnecessary default_on variable was removed.
- gbl->fbdev was already NULL and didn't need to be re-assigned, so the re-assignement was removed.
- The of_device_id struct and .of_match_table are now guarded against the driver beeing compiled without CONFIG_OF.

ChangeLog v11->v11-resend:
- Removed the Cc list because it's only one patch.

ChangeLog v10->v11:
- Shrinked the Cc list.
- Fixed the of_match_table warning.

ChangeLog v9->v10:
- Only the respective maintainers, or people who responded to the patch were kept in the Cc.
- The unnecessary of_match_ptr in of_match_table was removed.

ChangeLog v8->v9:
- Added Shawn Guo in the Cc list.
- The default-brightness-level is now a boolean default-on property, the gpio is only touched if the gpio-backlight driver instance probes.
- The code and documentation was updated accordingly.

ChangeLog v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm, That way we avoid having to handle the case where it's not set, which means that we would need not to set the gpio, but still report a brightness value for sysfs, when not all gpio controllers are able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight: gpio_backlight: Use a default state enum." patch was then dropped, becuase it is not necessary anymore.

ChangeLog v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.

ChangeLog v5->v6:
- The default state handling was reworked:
- it's now called default-state, and looks like the gpio-leds default-state.
- it now has a "keep" option, like for the gpio-leds.
- that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.

ChangeLog v4->v5:
- The default-brightness property now defaults to 0 in the driver.
- def_value int becomes a bool.
- The check for the gpio validity has been reworked.

Quoted 5 lines
---
 .../bindings/video/backlight/gpio-backlight.txt    |   16 ++++++
 drivers/video/backlight/gpio_backlight.c           |   58 +++++++++++++++++---
 2 files changed, 67 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
Quoted 5 lines

Patch looks good to me now, I just want to see if Jingoo and/or Bryan with to add anything. If they don't respond within the next couple of days I'll apply the patch.

Best regards,
Jingoo Han

Quoted 6 lines

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead

Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to Denis Carikli
Quoted 57 lines · Denis Carikli

---
ChangeLog v11-resend->v12:
- Moved the Cc from the commit message to the "email patch".
- The documentation is now more clear.
- The unnecessary default_on variable was removed.
- gbl->fbdev was already NULL and didn't need to be re-assigned, so the re-assignement was removed.
- The of_device_id struct and .of_match_table are now guarded against the driver beeing compiled without CONFIG_OF.

ChangeLog v11->v11-resend:
- Removed the Cc list because it's only one patch.

ChangeLog v10->v11:
- Shrinked the Cc list.
- Fixed the of_match_table warning.

ChangeLog v9->v10:
- Only the respective maintainers, or people who responded to the patch were kept in the Cc.
- The unnecessary of_match_ptr in of_match_table was removed.

ChangeLog v8->v9:
- Added Shawn Guo in the Cc list.
- The default-brightness-level is now a boolean default-on property, the gpio is only touched if the gpio-backlight driver instance probes.
- The code and documentation was updated accordingly.

ChangeLog v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm, That way we avoid having to handle the case where it's not set, which means that we would need not to set the gpio, but still report a brightness value for sysfs, when not all gpio controllers are able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight: gpio_backlight: Use a default state enum." patch was then dropped, becuase it is not necessary anymore.

ChangeLog v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.

ChangeLog v5->v6:
- The default state handling was reworked:
- it's now called default-state, and looks like the gpio-leds default-state.
- it now has a "keep" option, like for the gpio-leds.
- that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.

ChangeLog v4->v5:
- The default-brightness property now defaults to 0 in the driver.
- def_value int becomes a bool.
- The check for the gpio validity has been reworked.

Quoted 5 lines
---
 .../bindings/video/backlight/gpio-backlight.txt    |   16 ++++++
 drivers/video/backlight/gpio_backlight.c           |   58 +++++++++++++++++---
 2 files changed, 67 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt

Applied with Jingoo's Ack.

Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html