Skip to contentSkip to conversation

CONFIG_PRINT_TIME: Measuring boot time.

PATCH New Benoit Monin 3 participants 3 messages Mar 4, 2009 – Mar 6, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CONFIG_PRINT_TIME: Measuring boot time.

This option prefixes every console line with the time in seconds since power-up. It is inspired by the Linux kernel option PRINTK_TIME and uses the same output format.

It can be used to measure the time taken by U-Boot to boot the kernel or application. For example:

[    0.003532] U-Boot 2009.03-rc1-00008-gfa74f69-dirty (mar 04 2009 - 14:18:39)
[    0.011994]
[    0.013694] CPU:   AMCC PowerPC 440EPx Rev. A at 528 MHz (PLB=132, OPB=66, EBC=66 MHz)
[    0.023121]        Security/Kasumi support
[    0.028001]        Bootstrap Option H - Boot ROM Location I2C (Addr 0x52)
[    0.036075]        Internal PCI arbiter enabled, PCI async ext clock used
[    0.044142]        32 kB I-Cache 32 kB D-Cache
[    0.049445] Board: Sequoia - AMCC PPC440EPx Evaluation Board, Rev. F, PCI=66 MHz

...

---
 README           |    5 +++++
 common/console.c |   36 ++++++++++++++++++++++++++++++------
 2 files changed, 35 insertions(+), 6 deletions(-)
README +5 -0
index d0a636e..848ff29 100644
@@ -478,6 +478,11 @@ The following options need to be configured:
 		the "silent" environment variable. See
 		doc/README.silent for more information.
 
+		When CONFIG_PRINT_TIME is defined, all console messages
+		are prefixed with the time in second since power-up.
+		This option mimics the Linux kernel option PRINTK_TIME
+		and uses the same output format (ex: [    0.049445] ...).
+
 - Console Baudrate:
 		CONFIG_BAUDRATE - in bps
 		Select one of the baudrates listed in
common/console.c +30 -6
index 2add047..75f0f28 100644
@@ -325,6 +325,17 @@ int tstc(void)
 	return serial_tstc();
 }
 
+static void __putc(const char c)
+{
+	if (gd->flags & GD_FLG_DEVINIT) {
+		/* Send to the standard output */
+		fputc (stdout, c);
+	} else {
+		/* Send directly to the handler */
+		serial_putc (c);
+	}
+}
+
 void putc(const char c)
 {
 #ifdef CONFIG_SILENT_CONSOLE
@@ -337,13 +348,20 @@ void putc(const char c)
 		return;
 #endif
 
-	if (gd->flags & GD_FLG_DEVINIT) {
-		/* Send to the standard output */
-		fputc(stdout, c);
-	} else {
-		/* Send directly to the handler */
-		serial_putc(c);
+	__putc(c);
+#ifdef CONFIG_PRINT_TIME
+	if (c == '\n') {
+		unsigned long ms;
+		char tbuf[32];
+		int tlen;
+		int i;
+
+		ms = ticks2usec(get_ticks());
+		tlen = sprintf(tbuf, "[%5lu.%06lu] ", (ms / 1000000UL), (ms % 1000000UL));
+		for (i = 0; i < tlen; i++)
+			__putc(tbuf[i]);
 	}
+#endif
 }
 
 void puts(const char *s)
@@ -358,6 +376,11 @@ void puts(const char *s)
 		return;
 #endif
 
+#ifdef CONFIG_PRINT_TIME
+	while (*s) {
+		putc(*s++);
+	}
+#else
 	if (gd->flags & GD_FLG_DEVINIT) {
 		/* Send to the standard output */
 		fputs(stdout, s);
@@ -365,6 +388,7 @@ void puts(const char *s)
 		/* Send directly to the handler */
 		serial_puts(s);
 	}
+#endif
 }
 
 void printf(const char *fmt, ...)
Signature · 2 lines
 Cr?ez votre adresse ?lectronique prenom.nom at laposte.net 
 1 Go d'espace de stockage, anti-spam et anti-virus int?gr?s.
#1 lore raw

PATCH 1/1 CONFIG_PRINT_TIME: Measuring boot time.

Quoted 70 lines · Benoit Monin

This option prefixes every console line with the time in seconds since power-up. It is inspired by the Linux kernel option PRINTK_TIME and uses the same output format.

It can be used to measure the time taken by U-Boot to boot the kernel or application. For example:

[    0.003532] U-Boot 2009.03-rc1-00008-gfa74f69-dirty (mar 04 2009 - 14:18:39)
[    0.011994]
[    0.013694] CPU:   AMCC PowerPC 440EPx Rev. A at 528 MHz (PLB=132, OPB=66, EBC=66 MHz)
[    0.023121]        Security/Kasumi support
[    0.028001]        Bootstrap Option H - Boot ROM Location I2C (Addr 0x52)
[    0.036075]        Internal PCI arbiter enabled, PCI async ext clock used
[    0.044142]        32 kB I-Cache 32 kB D-Cache
[    0.049445] Board: Sequoia - AMCC PPC440EPx Evaluation Board, Rev. F, PCI=66 MHz

...

---
 README           |    5 +++++
 common/console.c |   36 ++++++++++++++++++++++++++++++------
 2 files changed, 35 insertions(+), 6 deletions(-)
README +5 -0
index d0a636e..848ff29 100644
@@ -478,6 +478,11 @@ The following options need to be configured:
 		the "silent" environment variable. See
 		doc/README.silent for more information.
 
+		When CONFIG_PRINT_TIME is defined, all console messages
+		are prefixed with the time in second since power-up.
+		This option mimics the Linux kernel option PRINTK_TIME
+		and uses the same output format (ex: [    0.049445] ...).
+
 - Console Baudrate:
 		CONFIG_BAUDRATE - in bps
 		Select one of the baudrates listed in
common/console.c +11 -4
index 2add047..75f0f28 100644
@@ -325,6 +325,17 @@ int tstc(void)
 	return serial_tstc();
 }
 
+static void __putc(const char c)
+{
+	if (gd->flags & GD_FLG_DEVINIT) {
+		/* Send to the standard output */
+		fputc (stdout, c);
+	} else {
+		/* Send directly to the handler */
+		serial_putc (c);
+	}
+}
+
 void putc(const char c)
 {
 #ifdef CONFIG_SILENT_CONSOLE
@@ -337,13 +348,20 @@ void putc(const char c)
 		return;
 #endif
 
-	if (gd->flags & GD_FLG_DEVINIT) {
-		/* Send to the standard output */
-		fputc(stdout, c);
-	} else {

common/console.c void putc(const char c) · line 358

Quoted 10 lines
common/console.c +8 -2
-		/* Send directly to the handler */
-		serial_putc(c);
+	__putc(c);
+#ifdef CONFIG_PRINT_TIME
+	if (c == '\n') {
+		unsigned long ms;
+		char tbuf[32];
+		int tlen;
+		int i;
+

NACK

common/console.c void putc(const char c) · line 359

Quoted 1 line
common/console.c +1 -0
+		ms = ticks2usec(get_ticks());

ticks2usec only exist on ppc

common/console.c void putc(const char c) · line 360

Quoted 1 line
common/console.c +1 -0
+		tlen = sprintf(tbuf, "[%5lu.%06lu] ", (ms / 1000000UL), (ms % 1000000UL));

wont work on arm
please do_div

Quoted 8 lines
common/console.c +3 -0
+		for (i = 0; i < tlen; i++)
+			__putc(tbuf[i]);
 	}
+#endif
 }
 
 void puts(const char *s)

common/console.c void puts(const char *s) · line 381

Quoted 6 lines
common/console.c +3 -0
@@ -358,6 +376,11 @@ void puts(const char *s)
 		return;
 #endif
 
+#ifdef CONFIG_PRINT_TIME
+	while (*s) {
+		putc(*s++);

please use fputs and serail_puts

Best Regards,
J.

#2 lore raw

PATCH 1/1 CONFIG_PRINT_TIME: Measuring boot time.

In reply to Benoit Monin

Dear Benoit Monin,

Quoted 4 lines · In message <13935170.21001.1236183410521.JavaMail.www@wwinf8202> you wrote:

This option prefixes every console line with the time in seconds since power-up. It is inspired by the Linux kernel option PRINTK_TIME and uses the same output format.

Thanks, but I reject this patch, as it adds only code bloat and slows down the boot process. The same effect can be acchieved by a few linex of expect code parsing the output - without adding code or slowing down the system.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I object to intellect without discipline;  I object to power without
constructive purpose.
	-- Spock, "The Squire of Gothos", stardate 2124.5