NFSv4 always compare stateids in nfs4_stateid_is_current
Subsystems (2)
PATCH 1/1 NFSv4 always compare stateids in nfs4_stateid_is_current
From: Andy Adamson <[email protected]>
When nfs4_stateid_is_current does not compare the from the wire stateid to the current stateid, nfs4_read/write_stateid_changed can return a false positive resulting in a READ or WRITE looping forever retrying a bad stateid and never triggering a stateid recovery.
Do not check the non-boolean return from nfs4_set_rw_stateid.
Signed-off-by Andy Adamson <[email protected]>
--- fs/nfs/nfs4proc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
fs/nfs/nfs4proc.c +2 -3
@@ -4051,10 +4051,9 @@ static bool nfs4_stateid_is_current(nfs4_stateid *stateid,const struct nfs_lock_context *l_ctx, fmode_t fmode) { - nfs4_stateid current_stateid; + nfs4_stateid current_stateid = &zero_stateid; -if (nfs4_set_rw_stateid (¤t_stateid, ctx, l_ctx, fmode)) -return false; +nfs4_set_rw_stateid (¤t_stateid, ctx, l_ctx, fmode);return nfs4_stateid_match (stateid, ¤t_stateid); }
Signature · 1 line
1.8.3.1