cpufreq: stats: Fix error handling in __cpufreq_stats_create_table()
Subsystems (2)
PATCH v3 2/3 cpufreq: stats: Fix error handling in __cpufreq_stats_create_table()
Remove sysfs group if __cpufreq_stats_create_table() fails after creating one.
Acked-by Viresh Kumar <[email protected]>
Signed-off-by Saravana Kannan <[email protected]>
--- drivers/cpufreq/cpufreq_stats.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/cpufreq/cpufreq_stats.c +3 -1
@@ -216,7 +216,7 @@ static int __cpufreq_stats_create_table(struct cpufreq_policy *policy, stat->time_in_state =kzalloc (alloc_size,GFP_KERNEL );if (!stat->time_in_state) { ret = -ENOMEM ; - goto error_out; + goto error_alloc; } stat->freq_table = (unsigned int *)(stat->time_in_state + count);
@@ -237,6 +237,8 @@ static int __cpufreq_stats_create_table(struct cpufreq_policy *policy, stat->last_index =freq_table_get_index (stat, policy->cur);spin_unlock (&cpufreq_stats_lock);return 0 ; +error_alloc: +sysfs_remove_group (&policy->kobj, &stats_attr_group); error_out:kfree (stat);per_cpu (cpufreq_stats_table, cpu) =NULL ;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation