Skip to contentSkip to conversation

codeparser: Fix var_execs to append to execs, not references

PATCH New Richard Purdie 1 participant 1 message Feb 28, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 codeparser: Fix var_execs to append to execs, not references

When using the "execs" information in new code, it became clear that the returned data was incorrect and there were missing exec'd functions. This corrects the error and changes one of the test results to match the correct behaviour.

---

bitbake/lib/bb/codeparser.py +1 -1
index 62b6cf9..a50b9f2 100644
@@ -186,7 +186,7 @@ class PythonParser():
             if n.__class__.__name__ == "Call":
                 self.visit_Call(n)
 
-        self.references.update(self.var_execs)
+        self.execs.update(self.var_execs)
 
         codeparsercache.pythoncacheextras[h] = {}
         codeparsercache.pythoncacheextras[h]["refs"] = self.references
bitbake/lib/bb/tests/codeparser.py +2 -1
index 938b04b..4454bc5 100644
@@ -236,7 +236,8 @@ be. These unit tests are testing snippets."""
             self.d.setVar("do_something", "echo 'hi mom! ${FOO}'")
             self.d.setVarFlag("do_something", etype, True)
             self.parseExpression("bb.build.exec_func('do_something', d)")
-            self.assertReferences(set(["do_something"]))
+            self.assertReferences(set([]))
+            self.assertExecs(set(["do_something"]))
 
     def test_function_reference(self):
         self.context["testfunc"] = lambda msg: bb.msg.note(1, None, msg)