Skip to contentSkip to conversation

ARM: tegra: add device tree for SHIELD

PATCH In review Alexandre Courbot 2 participants 4 messages Mar 3, 2014 – Mar 4, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: tegra: add device tree for SHIELD

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option and USB requiring external power.

A default kernel command-line as well as initrd addresses are hardcoded to match the static values the bootloader is known to use. This allows booting from an appended DTB without having to alter it at boot time, since the bootloader has no Device Tree support.

---
 arch/arm/boot/dts/Makefile          |    1 +
 arch/arm/boot/dts/tegra114-roth.dts | 1069 +++++++++++++++++++++++++++++++++++
 2 files changed, 1070 insertions(+)
 create mode 100644 arch/arm/boot/dts/tegra114-roth.dts
arch/arm/boot/dts/Makefile +1 -0
index c98f343b47ca..27ca6fd664d0 100644
@@ -356,6 +356,7 @@ dtb-$(CONFIG_ARCH_TEGRA) += tegra20-harmony.dtb \
 	tegra30-cardhu-a02.dtb \
 	tegra30-cardhu-a04.dtb \
 	tegra114-dalmore.dtb \
+	tegra114-roth.dtb \
 	tegra124-venice2.dtb
 dtb-$(CONFIG_ARCH_VERSATILE) += versatile-ab.dtb \
 	versatile-pb.dtb
arch/arm/boot/dts/tegra114-roth.dts new file +1069 -0

1,069 lines not on this page · raw message

Signature · 1 line
1.9.0
#1 lore raw
Quoted 10 lines · Alexandre Courbot

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option and USB requiring external power.

A default kernel command-line as well as initrd addresses are hardcoded to match the static values the bootloader is known to use. This allows booting from an appended DTB without having to alter it at boot time, since the bootloader has no Device Tree support.

---

Forgot to specify this is a v2, apologies for the inconvenience.

Changes since v1:
- Comment on the memory range
- Removed nodes for currently unsupported hardware (i.e. wifi)

#2 lore raw
In reply to Alexandre Courbot
Quoted 7 lines · Alexandre Courbot

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option and USB requiring external power.

A default kernel command-line as well as initrd addresses are hardcoded to match the static values the bootloader is known to use. This allows booting from an appended DTB without having to alter it at boot time, since the bootloader has no Device Tree support.

This and the TN7 patch look fine. Hopefully I'll apply them soon, pending the ti,irq-externally-inverted discussion.

arch/arm/boot/dts/tegra114-roth.dts line 945

Quoted 1 line
arch/arm/boot/dts/tegra114-roth.dts new file +1 -0
+	/* SD card */

Oh, that's all you meant by wanting to add comments? I guess I just recognize SD-vs-eMMC by the bus width, but adding the comments is a good idea.

#3 lore raw
Quoted 11 lines · Stephen Warren
Quoted 7 lines · Alexandre Courbot

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option and USB requiring external power.

A default kernel command-line as well as initrd addresses are hardcoded to match the static values the bootloader is known to use. This allows booting from an appended DTB without having to alter it at boot time, since the bootloader has no Device Tree support.

This and the TN7 patch look fine. Hopefully I'll apply them soon, pending the ti,irq-externally-inverted discussion.

Great, thanks! That means only small hacks remain in my out-of-tree branch. Will make it easier to enable the remaining features (panel, Wifi, audio, etc.) from now on.

Quoted 6 lines

arch/arm/boot/dts/tegra114-roth.dts line 945

Quoted 2 lines
arch/arm/boot/dts/tegra114-roth.dts new file +1 -0
+	/* SD card */

Oh, that's all you meant by wanting to add comments? I guess I just recognize SD-vs-eMMC by the bus width, but adding the comments is a good idea.

Haha no, I actually meant to add small descriptive comments in front of each pinmux group, but thinking twice it doesn't seem to bring as much readability as I initially thought,

Thanks,
Alex.