NVMe: Initialize device reference count earlier

PATCH New Keith Busch 1 participant 1 message Mar 3, 2014

Subsystems (2)

Block layer NVMe

lore

Share & tools

lore

Keith Busch

author

2014-03-03 18:09 UTC #0 lore raw

PATCH 1/1 NVMe: Initialize device reference count earlier

If an NVMe device becomes ready but fails to create IO queues, the driver creates a character device handle so the device can be managed. The device reference count needs to be initialized before creating the character device.

Signed-off-by Keith Busch <keith.busch at intel.com>

---
 drivers/block/nvme-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/block/nvme-core.c +1 -1

index cd39390..53f0c5e 100644
@@ -2546,6 +2546,7 @@ static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	if (result)
 		goto release;
 
+	kref_init(&dev->kref);
 	result = nvme_dev_start(dev);
 	if (result) {
 		if (result == -EBUSY)

@@ -2553,7 +2554,6 @@ static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 		goto release_pools;
 	}
 
-	kref_init(&dev->kref);
 	result = nvme_dev_add(dev);
 	if (result)
 		goto shutdown;

Signature · 1 line

1.7.10.4