RFC: WIP: sc16is7xx.c
PATCH v2 1/1 RFC: WIP: sc16is7xx.c
From: Jon Ringle <[email protected]>
Quoted 20 lines · Joe Perches
Quoted 7 lines · Greg KH
Quoted 6 lines · On Thu, Mar 06, 2014 at 09:35:46PM -0500, [email protected] wrote:
From: Jon Ringle <[email protected]>
I am requesting comments on this serial driver.
I am currently having some latency issues with it where I experience packet loss at speed of 19200.Quoted 7 lines
Quoted 1 line
I welcome any and all comments.
The basic coding style problems make it hard to read to be able to help review it, sorry.
Yes, brains have patterns, you want to follow the same patterns as others, it matters.
Here's a patternizing patch on top of this...
It's an extended version of what I sent Jon privately.
Quoted 8 lines
Mostly whitespace but some other neatening too. Brace removals, tabifying, 80 column comments, spelling typos, pr_<level>, c90 comments, etc.
I don't care that's it does a lot of things in a single patch because this hasn't ever been submitted before and I hope Jon rolls it into his next submission.
Thanks Joe!
Here is the patch with Joe's cleanup.
Jon
--- drivers/tty/serial/Kconfig | 7 + drivers/tty/serial/Makefile | 1 + drivers/tty/serial/sc16is7xx.c | 871 +++++++++++++++++++++++++++++++++++++++ include/uapi/linux/serial_core.h | 3 + 4 files changed, 882 insertions(+) create mode 100644 drivers/tty/serial/sc16is7xx.c
drivers/tty/serial/Kconfig +7 -0
@@ -1179,6 +1179,13 @@ config SERIAL_SCCNXP_CONSOLE help Support for console on SCCNXP serial ports. +config SERIAL_SC16IS7XX + tristate "SC16IS7xx RS485 serial support" + select SERIAL_CORE + default n + help + This selects support for SC16IS7xx for use as a RS485 serial port + config SERIAL_BFIN_SPORT tristate "Blackfin SPORT emulate UART" depends on BLACKFIN
drivers/tty/serial/Makefile +1 -0
@@ -49,6 +49,7 @@ obj-$(CONFIG_SERIAL_SB1250_DUART) += sb1250-duart.o obj-$(CONFIG_ETRAX_SERIAL) += crisv10.o obj-$(CONFIG_SERIAL_SC26XX) += sc26xx.o obj-$(CONFIG_SERIAL_SCCNXP) += sccnxp.o +obj-$(CONFIG_SERIAL_SC16IS7XX) += sc16is7xx.o obj-$(CONFIG_SERIAL_JSM) += jsm/ obj-$(CONFIG_SERIAL_TXX9) += serial_txx9.o obj-$(CONFIG_SERIAL_VR41XX) += vr41xx_siu.o
drivers/tty/serial/sc16is7xx.c new file +871 -0
871 lines not on this page · raw message
include/uapi/linux/serial_core.h +3 -0
@@ -238,4 +238,7 @@/* Tilera TILE-Gx UART */ #define PORT_TILEGX 106 +/* SC16IS74xx */ +#define PORT_SC16IS7XX 107 +#endif /* _UAPILINUX_SERIAL_CORE_H */
Signature · 6 lines
1.8.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html