ath9k_hw: fix unreachable code in baseband hang detection code

PATCH New Felix Fietkau 1 participant 1 message Mar 9, 2014 Qualcomm Atheros ATH9K wireless driver

Share & tools

Felix Fietkau

author

2014-03-09 08:51 UTC #0 lore raw

PATCH 1/1 ath9k_hw: fix unreachable code in baseband hang detection code

The commit "ath9k: reduce baseband hang detection false positive rate" added a delay in the loop checking the baseband state, however it was unreachable due to previous 'continue' statements.

Reported-by Dan Carpenter <[email protected]>

Signed-off-by Felix Fietkau <[email protected]>

---
 drivers/net/wireless/ath/ath9k/hw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/net/wireless/ath/ath9k/hw.c +1 -2

index 303ce27..9078a6c 100644
@@ -1548,6 +1548,7 @@ bool ath9k_hw_check_alive(struct ath_hw *ah)
 		if (reg != last_val)
 			return true;
 
+		udelay(1);
 		last_val = reg;
 		if ((reg & 0x7E7FFFEF) == 0x00702400)
 			continue;

@@ -1560,8 +1561,6 @@ bool ath9k_hw_check_alive(struct ath_hw *ah)
 		default:
 			return true;
 		}
-
-		udelay(1);
 	} while (count-- > 0);
 
 	return false;

Signature · 1 line

1.8.3.4 (Apple Git-47)