r8152: fix rx issues
Subsystems (4)
cover r8152: fix rx issues
The two patched are used to fix rx issues.
Hayes Wang (2):
r8152: fix wrong checksum status for received IPv4 packets
r8152: set rx mode early when linking on
drivers/net/usb/r8152.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
Signature · 6 lines
2.13.6 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/2 r8152: fix wrong checksum status for received IPv4 packets
The device could only check the checksum of TCP and UDP packets. Therefore, for the IPv4 packets excluding TCP and UDP, the check of checksum is necessary, even though the IP checksum is correct.
Take ICMP for example, The IP checksum may be correct, but the ICMP checksum may be wrong.
--- drivers/net/usb/r8152.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/net/usb/r8152.c +3 -5
@@ -1848,11 +1848,9 @@ static u8 r8152_rx_csum(struct r8152 *tp, struct rx_desc *rx_desc)if (opts2 &RD_IPV4_CS ) {if (opts3 &IPF ) checksum =CHECKSUM_NONE ; -else if ((opts2 &RD_UDP_CS ) && (opts3 &UDPF )) - checksum =CHECKSUM_NONE ; -else if ((opts2 &RD_TCP_CS ) && (opts3 &TCPF )) - checksum =CHECKSUM_NONE ; -else +else if ((opts2 &RD_UDP_CS ) && !(opts3 &UDPF )) + checksum =CHECKSUM_UNNECESSARY ; +else if ((opts2 &RD_TCP_CS ) && !(opts3 &TCPF )) checksum =CHECKSUM_UNNECESSARY ; }else if (opts2 &RD_IPV6_CS ) {if ((opts2 &RD_UDP_CS ) && !(opts3 &UDPF ))
PATCH 2/2 r8152: set rx mode early when linking on
In reply to Hayes WangSet rx mode before calling netif_wake_queue() when linking on to avoid the device missing the receiving packets.
The transmission may start after calling netif_wake_queue(), and the packets of resopnse may reach before calling rtl8152_set_rx_mode() which let the device could receive packets. Then, the packets of response would be missed.
--- drivers/net/usb/r8152.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/usb/r8152.c +3 -2
@@ -3795,11 +3795,12 @@ static void set_carrier(struct r8152 *tp)if (speed &LINK_STATUS ) {if (!netif_carrier_ok (netdev)) { tp->rtl_ops.enable (tp); -set_bit (RTL8152_SET_RX_MODE , &tp->flags);netif_stop_queue (netdev);napi_disable (napi);netif_carrier_on (netdev);rtl_start_rx (tp); +clear_bit (RTL8152_SET_RX_MODE , &tp->flags); +_rtl8152_set_rx_mode (netdev);napi_enable (&tp->napi);netif_wake_queue (netdev);netif_info (tp, link, netdev,"carrier on\n" );
@@ -4259,7 +4260,7 @@ static int rtl8152_post_reset(struct usb_interface *intf)mutex_lock (&tp->control); tp->rtl_ops.enable (tp);rtl_start_rx (tp); -rtl8152_set_rx_mode (netdev); +_rtl8152_set_rx_mode (netdev);mutex_unlock (&tp->control); }
David Miller
maintainerFrom: Hayes Wang <[email protected]>
Date: Fri, 2 Feb 2018 16:43:34 +0800
Quoted 1 line
The two patched are used to fix rx issues.
Series applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html