Skip to contentSkip to conversation

eth/r8152: update the firmware

PATCH New Hayes Wang 2 participants 8 messages Jun 1, 2020 – Jun 4, 2020 USB

lore
Share & tools
lore

Hayes Wang

author
#0 lore raw

PATCH 1/1 eth/r8152: update the firmware

Update the firmware to improve compatibility for none-intel USB host controller.

---
 drivers/usb/eth/r8152.h    |   8 +
 drivers/usb/eth/r8152_fw.c | 481 ++++++++++++++++++++-----------------
 2 files changed, 265 insertions(+), 224 deletions(-)
drivers/usb/eth/r8152.h +8 -0
index c7f62b8b3e..10e0da8eb1 100644
@@ -25,6 +25,7 @@
 #define PLA_BDC_CR		0xd1a0
 #define PLA_TEREDO_TIMER	0xd2cc
 #define PLA_REALWOW_TIMER	0xd2e8
+#define PLA_EXTRA_STATUS	0xd398
 #define PLA_LEDSEL		0xdd90
 #define PLA_LED_FEATURE		0xdd92
 #define PLA_PHYAR		0xde00
@@ -76,6 +77,7 @@
 #define USB_DEV_STAT		0xb808
 #define USB_CONNECT_TIMER	0xcbf8
 #define USB_BURST_SIZE		0xcfc0
+#define USB_FW_FIX_EN1		0xcfcc
 #define USB_USB_CTRL		0xd406
 #define USB_PHY_CTRL		0xd408
 #define USB_TX_AGG		0xd40a
@@ -285,6 +287,9 @@
 /* PLA_BOOT_CTRL */
 #define AUTOLOAD_DONE		0x0002
 
+/* PLA_EXTRA_STATUS */
+#define U3P3_CHECK_EN		BIT(7)
+
 /* USB_USB2PHY */
 #define USB2PHY_SUSPEND		0x0001
 #define USB2PHY_L1		0x0002
@@ -304,6 +309,9 @@
 #define STAT_SPEED_HIGH		0x0000
 #define STAT_SPEED_FULL		0x0002
 
+/* USB_FW_FIX_EN1 */
+#define FW_IP_RESET_EN		BIT(9)
+
 /* USB_TX_AGG */
 #define TX_AGG_MAX_THRESHOLD	0x03
 
drivers/usb/eth/r8152_fw.c +257 -224

551 lines not on this page · raw message

Signature · 1 line
2.21.1
#1 lore raw

PATCH 1/1 eth/r8152: update the firmware

Quoted 2 lines · Hayes Wang

Update the firmware to improve compatibility for none-intel USB host controller.

Can you be more specific about the problem you are fixing here ? What is the problem ?

author
#2 lore raw

PATCH 1/1 eth/r8152: update the firmware

Marek Vasut [mailto:marex at denx.de]

Quoted 6 lines

Sent: Tuesday, June 02, 2020 12:46 AM

Quoted 2 lines

Update the firmware to improve compatibility for none-intel USB host controller.

Can you be more specific about the problem you are fixing here ? What is the problem ?

There is low probability that the device may be lost when rebooting. Should I submit v2 to reword the commit message?

Best Regards,
Hayes

#3 lore raw

PATCH 1/1 eth/r8152: update the firmware

Quoted 10 lines · Hayes Wang

Marek Vasut [mailto:marex at denx.de]

Quoted 6 lines

Sent: Tuesday, June 02, 2020 12:46 AM

Quoted 2 lines

Update the firmware to improve compatibility for none-intel USB host controller.

Can you be more specific about the problem you are fixing here ? What is the problem ?

There is low probability that the device may be lost when rebooting. Should I submit v2 to reword the commit message?

Lost how ?

author
#4 lore raw

PATCH 1/1 eth/r8152: update the firmware

Marek Vasut [mailto:marex at denx.de]

Quoted 1 line

Sent: Tuesday, June 02, 2020 7:02 PM

[...]

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Can you be more specific about the problem you are fixing here ? What is the problem ?

There is low probability that the device may be lost when rebooting. Should I submit v2 to reword the commit message?

Lost how ?

USB enumeration may fail. The device would be at wrong state. I don't know detail about the hardware behavior.

#5 lore raw

PATCH 1/1 eth/r8152: update the firmware

Quoted 6 lines · Hayes Wang

Marek Vasut [mailto:marex at denx.de]

Quoted 1 line

Sent: Tuesday, June 02, 2020 7:02 PM

[...]

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

Can you be more specific about the problem you are fixing here ? What is the problem ?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

There is low probability that the device may be lost when rebooting. Should I submit v2 to reword the commit message?

Lost how ?

USB enumeration may fail. The device would be at wrong state. I don't know detail about the hardware behavior.

Is there any chance you can ask someone ? It would be real helpful to know the details of the problem, in case someone runs into it, they would know what is going on.

author
#6 lore raw

PATCH 1/1 eth/r8152: update the firmware

Marek Vasut [mailto:marex at denx.de]

Quoted 1 line

Sent: Tuesday, June 02, 2020 7:59 PM

[...]

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines

Can you be more specific about the problem you are fixing here ? What is the problem ?

There is low probability that the device may be lost when rebooting. Should I submit v2 to reword the commit message?

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Lost how ?

USB enumeration may fail. The device would be at wrong state. I don't know detail about the hardware behavior.

Is there any chance you can ask someone ? It would be real helpful to know the details of the problem, in case someone runs into it, they would know what is going on.

I get the following information.

1.
Our device has auto-installed driver feature - via switch CD-ROM/NIC mode. But in some corner cases, it would switch to CD-ROM unexpected. This issue results in Lan Function Disabled.

2.
While USB PHY transits to P3 from P0 due to the absent of transmitter control, it would issues undefined signal to its? link partner. Some Down Stream Port misidentify the undefined signal as wakeup signal. So the link state will not keep in suspend even the system is idle.

Best Regards,
Hayes

#7 lore raw

PATCH 1/1 eth/r8152: update the firmware

Quoted 25 lines · Hayes Wang

Marek Vasut [mailto:marex at denx.de]

Quoted 1 line

Sent: Tuesday, June 02, 2020 7:59 PM

[...]

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines

Can you be more specific about the problem you are fixing here ? What is the problem ?

There is low probability that the device may be lost when rebooting. Should I submit v2 to reword the commit message?

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Lost how ?

USB enumeration may fail. The device would be at wrong state. I don't know detail about the hardware behavior.

Is there any chance you can ask someone ? It would be real helpful to know the details of the problem, in case someone runs into it, they would know what is going on.

I get the following information.

1.
Our device has auto-installed driver feature - via switch CD-ROM/NIC mode. But in some corner cases, it would switch to CD-ROM unexpected. This issue results in Lan Function Disabled.

Quoted 6 lines

2.
While USB PHY transits to P3 from P0 due to the absent of transmitter control, it would issues undefined signal to its? link partner. Some Down Stream Port misidentify the undefined signal as wakeup signal. So the link state will not keep in suspend even the system is idle.

OK, then please add this into the commit message and send a V2, I'll pick it then. Thanks!