Skip to contentSkip to conversation

lib/oe: turn oe into a namespace package

PATCH In review Christopher Larson 2 participants 5 messages Mar 15, 2014 – Mar 18, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/oe: turn oe into a namespace package

This will let folks extend the oe package with modules from other layers. Given openembedded consists of more than just oe-core, I think this makes sense, and adds some useful flexibility.

---
 meta/lib/oe/__init__.py | 2 ++
 1 file changed, 2 insertions(+)
meta/lib/oe/__init__.py +2 -0
index e69de29..3ad9513 100644
@@ -0,0 +1,2 @@
+from pkgutil import extend_path
+__path__ = extend_path(__path__, __name__)
Signature · 1 line
1.8.3.4
#1 lore raw
Quoted 14 lines · On Friday 14 March 2014 19:06:26 Christopher Larson wrote:

This will let folks extend the oe package with modules from other layers. Given openembedded consists of more than just oe-core, I think this makes sense, and adds some useful flexibility.

---
 meta/lib/oe/__init__.py | 2 ++
 1 file changed, 2 insertions(+)
meta/lib/oe/__init__.py +0 -0
index e69de29..3ad9513 100644

meta/lib/oe/__init__.py line 2

Quoted 2 lines
meta/lib/oe/__init__.py +2 -0
@@ -0,0 +1,2 @@
+from pkgutil import extend_path
+__path__ = extend_path(__path__, __name__)

FWIW, this broke builds on my CentOS build machine that uses a slightly older buildtools install from 1.4. I hope we have pkgutil in our more current buildtools - if not could you please send a fix for that as well?

Thanks,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#2 lore raw
Quoted 10 lines · Paul Eggleton
Quoted 9 lines · On Friday 14 March 2014 19:06:26 Christopher Larson wrote:

This will let folks extend the oe package with modules from other layers. Given openembedded consists of more than just oe-core, I think this makes sense, and adds some useful flexibility.

---
 meta/lib/oe/__init__.py | 2 ++
 1 file changed, 2 insertions(+)
Quoted 12 lines

meta/lib/oe/__init__.py line 2

Quoted 7 lines
meta/lib/oe/__init__.py +2 -0
index e69de29..3ad9513 100644
@@ -0,0 +1,2 @@
+from pkgutil import extend_path
+__path__ = extend_path(__path__, __name__)

FWIW, this broke builds on my CentOS build machine that uses a slightly older
buildtools install from 1.4. I hope we have pkgutil in our more current buildtools - if not could you please send a fix for that as well?

Ah, interesting, sorry about the hassle there. I'm 90% certain it's in the current buildtools tarball, as I do all my build testing with a CentOS 6 chroot using a buildtools tarball, and didn't hit that problem, but I'll double check.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#3 lore raw
Quoted 30 lines · Chris Larson
Quoted 12 lines · Paul Eggleton
Quoted 1 line · On Friday 14 March 2014 19:06:26 Christopher Larson wrote:

This will let folks extend the oe package with modules from other

layers.

Quoted 1 line

Given openembedded consists of more than just oe-core, I think this

makes

Quoted 7 lines

sense, and adds some useful flexibility.

---
 meta/lib/oe/__init__.py | 2 ++
 1 file changed, 2 insertions(+)
Quoted 12 lines

meta/lib/oe/__init__.py line 2

Quoted 7 lines
meta/lib/oe/__init__.py +2 -0
index e69de29..3ad9513 100644
@@ -0,0 +1,2 @@
+from pkgutil import extend_path
+__path__ = extend_path(__path__, __name__)

FWIW, this broke builds on my CentOS build machine that uses a slightly older
buildtools install from 1.4. I hope we have pkgutil in our more current buildtools - if not could you please send a fix for that as well?

Quoted 5 lines

Ah, interesting, sorry about the hassle there. I'm 90% certain it's in the current buildtools tarball, as I do all my build testing with a CentOS 6 chroot using a buildtools tarball, and didn't hit that problem, but I'll double check.

Looks like it was added in
https://github.com/openembedded/oe-core/commit/7d93288.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#4 lore raw
Quoted 8 lines · On Tuesday 18 March 2014 09:52:23 Chris Larson wrote:
Quoted 7 lines · Chris Larson
Quoted 4 lines · Paul Eggleton

FWIW, this broke builds on my CentOS build machine that uses a slightly older
buildtools install from 1.4. I hope we have pkgutil in our more current buildtools - if not could you please send a fix for that as well?

Quoted 7 lines
Quoted 4 lines

Ah, interesting, sorry about the hassle there. I'm 90% certain it's in the current buildtools tarball, as I do all my build testing with a CentOS 6 chroot using a buildtools tarball, and didn't hit that problem, but I'll double check.

Looks like it was added in
https://github.com/openembedded/oe-core/commit/7d93288.

OK, thanks for checking; it looks like this commit is in dora as well. I'll update to a 1.5.x buildtools on my build server.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre