perf sched latency: prettify printed table
PATCH 1/1 perf sched latency: prettify printed table
--- tools/perf/builtin-sched.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
tools/perf/builtin-sched.c +5 -5
@@ -1124,7 +1124,7 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_ avg = work_list->total_lat / work_list->nb_atoms; - printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %9.6f s\n", + printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %12.6f s\n", (double)work_list->total_runtime / 1e6, work_list->nb_atoms, (double)avg / 1e6, (double)work_list->max_lat / 1e6,
@@ -1527,9 +1527,9 @@ static int perf_sched__lat(struct perf_sched *sched)perf_sched__sort_lat (sched); -printf ("\n ---------------------------------------------------------------------------------------------------------------\n" ); -printf (" Task | Runtime ms | Switches | Average delay ms | Maximum delay ms | Maximum delay at |\n" ); -printf (" ---------------------------------------------------------------------------------------------------------------\n" ); +printf ("\n -----------------------------------------------------------------------------------------------------------------\n" ); +printf (" Task | Runtime ms | Switches | Average delay ms | Maximum delay ms | Maximum delay at |\n" ); +printf (" -----------------------------------------------------------------------------------------------------------------\n" ); next =rb_first (&sched->sorted_atom_root);
@@ -1541,7 +1541,7 @@ static int perf_sched__lat(struct perf_sched *sched) next =rb_next (next); } -printf (" -----------------------------------------------------------------------------------------\n" ); +printf (" -----------------------------------------------------------------------------------------------------------------\n" );printf (" TOTAL: |%11.3f ms |%9" PRIu64" |\n" , (double )sched->all_runtime /1e6 , sched->all_count);
Signature · 1 line
1.9.rc0.1.g9d22d25
Quoted 8 lines · Ramkumar Ramachandra
Cc Frederic Weisbecker <[email protected]>Cc David Ahern <[email protected]>Cc Jiri Olsa <[email protected]>Cc Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Ramkumar Ramachandra <[email protected]>--- tools/perf/builtin-sched.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
ENOCHANGELOG ;-)
please provide changelog details how's the output prettified (before/after example)
thanks,
jirka
PATCH v2 1/1 perf sched latency: prettify printed table
Before:
---------------------------------------------------------------------------------------------------------------
Task | Runtime ms | Switches | Average delay ms | Maximum delay ms | Maximum delay at |
---------------------------------------------------------------------------------------------------------------
... | | | | | git:24540 | 336.622 ms | 10 | avg: 0.032 ms | max: 0.062 ms | max at: 115610.111046 s git:24541 | 0.457 ms | 1 | avg: 0.000 ms | max: 0.000 ms | max at: 0.000000 s
-----------------------------------------------------------------------------------------
TOTAL: | 396.542 ms | 353 |
---------------------------------------------------
After:
-----------------------------------------------------------------------------------------------------------------
Task | Runtime ms | Switches | Average delay ms | Maximum delay ms | Maximum delay at |
-----------------------------------------------------------------------------------------------------------------
... | | | | | git:24540 | 336.622 ms | 10 | avg: 0.032 ms | max: 0.062 ms | max at: 115610.111046 s git:24541 | 0.457 ms | 1 | avg: 0.000 ms | max: 0.000 ms | max at: 0.000000 s
-----------------------------------------------------------------------------------------------------------------
TOTAL: | 396.542 ms | 353 |
---------------------------------------------------
--- tools/perf/builtin-sched.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
tools/perf/builtin-sched.c +5 -5
@@ -1124,7 +1124,7 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_ avg = work_list->total_lat / work_list->nb_atoms; - printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %9.6f s\n", + printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13.6f s\n", (double)work_list->total_runtime / 1e6, work_list->nb_atoms, (double)avg / 1e6, (double)work_list->max_lat / 1e6,
@@ -1527,9 +1527,9 @@ static int perf_sched__lat(struct perf_sched *sched)perf_sched__sort_lat (sched); -printf ("\n ---------------------------------------------------------------------------------------------------------------\n" ); -printf (" Task | Runtime ms | Switches | Average delay ms | Maximum delay ms | Maximum delay at |\n" ); -printf (" ---------------------------------------------------------------------------------------------------------------\n" ); +printf ("\n -----------------------------------------------------------------------------------------------------------------\n" ); +printf (" Task | Runtime ms | Switches | Average delay ms | Maximum delay ms | Maximum delay at |\n" ); +printf (" -----------------------------------------------------------------------------------------------------------------\n" ); next =rb_first (&sched->sorted_atom_root);
@@ -1541,7 +1541,7 @@ static int perf_sched__lat(struct perf_sched *sched) next =rb_next (next); } -printf (" -----------------------------------------------------------------------------------------\n" ); +printf (" -----------------------------------------------------------------------------------------------------------------\n" );printf (" TOTAL: |%11.3f ms |%9" PRIu64" |\n" , (double )sched->all_runtime /1e6 , sched->all_count);
Signature · 1 line
1.9.0.431.g014438b
tip-bot for Ramkumar Ramachandra
merge bot[tip:perf/core] perf sched: Fixup header alignment in 'latency' output
perf sched: Fixup header alignment in 'latency' output
Commit-ID: 80790e0b7ef768b6591fdf764b62c572b76a5d80 Gitweb: http://git.kernel.org/tip/80790e0b7ef768b6591fdf764b62c572b76a5d80 Author: Ramkumar Ramachandra <[email protected]> AuthorDate: Mon, 17 Mar 2014 10:18:21 -0400 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 18 Mar 2014 18:16:55 -0300
perf sched: Fixup header alignment in 'latency' output
Before:
---------------------------------------------------------------------------------------------------------------
Task | Runtime ms | Switches | Average delay ms | Maximum delay ms | Maximum delay at |
---------------------------------------------------------------------------------------------------------------
... | | | | | git:24540 | 336.622 ms | 10 | avg: 0.032 ms | max: 0.062 ms | max at: 115610.111046 s git:24541 | 0.457 ms | 1 | avg: 0.000 ms | max: 0.000 ms | max at: 0.000000 s
-----------------------------------------------------------------------------------------
TOTAL: | 396.542 ms | 353 |
---------------------------------------------------
After:
-----------------------------------------------------------------------------------------------------------------
Task | Runtime ms | Switches | Average delay ms | Maximum delay ms | Maximum delay at |
-----------------------------------------------------------------------------------------------------------------
... | | | | | git:24540 | 336.622 ms | 10 | avg: 0.032 ms | max: 0.062 ms | max at: 115610.111046 s git:24541 | 0.457 ms | 1 | avg: 0.000 ms | max: 0.000 ms | max at: 0.000000 s
-----------------------------------------------------------------------------------------------------------------
TOTAL: | 396.542 ms | 353 |
---------------------------------------------------
--- tools/perf/builtin-sched.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
tools/perf/builtin-sched.c +5 -5
@@ -1124,7 +1124,7 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_ avg = work_list->total_lat / work_list->nb_atoms; - printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %9.6f s\n", + printf("|%11.3f ms |%9" PRIu64 " | avg:%9.3f ms | max:%9.3f ms | max at: %13.6f s\n", (double)work_list->total_runtime / 1e6, work_list->nb_atoms, (double)avg / 1e6, (double)work_list->max_lat / 1e6,
@@ -1527,9 +1527,9 @@ static int perf_sched__lat(struct perf_sched *sched)perf_sched__sort_lat (sched); -printf ("\n ---------------------------------------------------------------------------------------------------------------\n" ); -printf (" Task | Runtime ms | Switches | Average delay ms | Maximum delay ms | Maximum delay at |\n" ); -printf (" ---------------------------------------------------------------------------------------------------------------\n" ); +printf ("\n -----------------------------------------------------------------------------------------------------------------\n" ); +printf (" Task | Runtime ms | Switches | Average delay ms | Maximum delay ms | Maximum delay at |\n" ); +printf (" -----------------------------------------------------------------------------------------------------------------\n" ); next =rb_first (&sched->sorted_atom_root);
@@ -1541,7 +1541,7 @@ static int perf_sched__lat(struct perf_sched *sched) next =rb_next (next); } -printf (" -----------------------------------------------------------------------------------------\n" ); +printf (" -----------------------------------------------------------------------------------------------------------------\n" );printf (" TOTAL: |%11.3f ms |%9" PRIu64" |\n" , (double )sched->all_runtime /1e6 , sched->all_count);