Skip to contentSkip to conversation

gpio: Return int for .irq_request_resources callback

PATCH In review Axel Lin 2 participants 2 messages Mar 18, 2014 – Mar 24, 2014

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: Return int for .irq_request_resources callback

This fixes below build warnings:

CC drivers/gpio/gpio-dwapb.o
drivers/gpio/gpio-dwapb.c: In function 'dwapb_configure_irqs':
drivers/gpio/gpio-dwapb.c:258:33: warning: assignment from incompatible pointer type [enabled by default]
CC drivers/gpio/gpio-pl061.o
drivers/gpio/gpio-pl061.c:261:2: warning: initialization from incompatible pointer type [enabled by default] drivers/gpio/gpio-pl061.c:261:2: warning: (near initialization for 'pl061_irqchip.irq_request_resources') [enabled by default]

Fixes 9a63a88cd390 ("gpio: switch drivers to use new callback")
---
 drivers/gpio/gpio-dwapb.c | 2 +-
 drivers/gpio/gpio-pl061.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-dwapb.c +1 -1
index 2cacb9ed..ed5711f 100644
@@ -136,7 +136,7 @@ static void dwapb_irq_disable(struct irq_data *d)
 	spin_unlock_irqrestore(&bgc->lock, flags);
 }
 
-static unsigned int dwapb_irq_reqres(struct irq_data *d)
+static int dwapb_irq_reqres(struct irq_data *d)
 {
 	struct irq_chip_generic *igc = irq_data_get_irq_chip_data(d);
 	struct dwapb_gpio *gpio = igc->private;
drivers/gpio/gpio-pl061.c +1 -1
index 2189183..d2a0ad5 100644
@@ -233,7 +233,7 @@ static void pl061_irq_unmask(struct irq_data *d)
 	spin_unlock(&chip->lock);
 }
 
-static unsigned int pl061_irq_reqres(struct irq_data *d)
+static int pl061_irq_reqres(struct irq_data *d)
 {
 	struct pl061_gpio *chip = irq_data_get_irq_chip_data(d);
 
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 1 line · Axel Lin

This fixes below build warnings:

I already wrote and pushed a similar patch myself, but thanks!

Yours,
Linus Walleij