drm/i915/bdw: Restore PPAT on thaw
Subsystems (2)
PATCH 1/1 drm/i915/bdw: Restore PPAT on thaw
Apparently it is wiped out from under us, and we get some really fun caching artifacts upon resume (it seems to be WB for all types by default).
--- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +5 -1
@@ -30,6 +30,8 @@#include "i915_trace.h" #include "intel_drv.h" +static void gen8_setup_private_ppat (struct drm_i915_private *dev_priv); +bool intel_enable_ppgtt (struct drm_device *dev,bool full) {if (i915.enable_ppgtt ==0 || !HAS_ALIASING_PPGTT (dev))
@@ -1371,8 +1373,10 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev) } -if (INTEL_INFO (dev)->gen >=8 ) +if (INTEL_INFO (dev)->gen >=8 ) { +gen8_setup_private_ppat (dev_priv);return ; + }list_for_each_entry (vm, &dev_priv->vm_list, global_link) {/* TODO: Perhaps it shouldn't be gen6 specific */
Signature · 1 line
1.9.0
Quoted 6 lines · Ben Widawsky
Apparently it is wiped out from under us, and we get some really fun caching artifacts upon resume (it seems to be WB for all types by default).
Reported-by James Ausmus <[email protected]>Signed-off-by Ben Widawsky <[email protected]>
Works for me backported on to both a 3.14-rc3 w/ ChromeOS sauce and a vanilla 3.14-rc6. Thanks!
Quoted 32 lines
--- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_gem_gtt.c +5
-2@@ -30,6 +30,8 @@#include "i915_trace.h" #include "intel_drv.h" +static void gen8_setup_private_ppat (struct drm_i915_private *dev_priv); +bool intel_enable_ppgtt (struct drm_device *dev,bool full) {if (i915.enable_ppgtt ==0 || !HAS_ALIASING_PPGTT (dev))@@ -1371,8 +1373,10 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev) } -if (INTEL_INFO (dev)->gen >=8 ) +if (INTEL_INFO (dev)->gen >=8 ) { +gen8_setup_private_ppat (dev_priv);return ; + }list_for_each_entry (vm, &dev_priv->vm_list, global_link) {/* TODO: Perhaps it shouldn't be gen6 specific */ --1.9.0
Signature · 3 lines
James Ausmus Sr. Software Engineer SSG-OTC ChromeOS Integration
Quoted 6 lines · Ben Widawsky
Apparently it is wiped out from under us, and we get some really fun caching artifacts upon resume (it seems to be WB for all types by default).
Reported-by James Ausmus <[email protected]>Signed-off-by Ben Widawsky <[email protected]>
Perhaps related to https://bugs.freedesktop.org/show_bug.cgi?id=76113 ? -Chris
Quoted 37 lines
--- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_gem_gtt.c +5
-1@@ -30,6 +30,8 @@#include "i915_trace.h" #include "intel_drv.h" +static void gen8_setup_private_ppat (struct drm_i915_private *dev_priv); +bool intel_enable_ppgtt (struct drm_device *dev,bool full) {if (i915.enable_ppgtt ==0 || !HAS_ALIASING_PPGTT (dev))@@ -1371,8 +1373,10 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev) } -if (INTEL_INFO (dev)->gen >=8 ) +if (INTEL_INFO (dev)->gen >=8 ) { +gen8_setup_private_ppat (dev_priv);return ; + }list_for_each_entry (vm, &dev_priv->vm_list, global_link) {/* TODO: Perhaps it shouldn't be gen6 specific */ Signature · 6 lines
1.9.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Quoted 6 lines · Ben Widawsky
Apparently it is wiped out from under us, and we get some really fun caching artifacts upon resume (it seems to be WB for all types by default).
Reported-by James Ausmus <[email protected]>Signed-off-by Ben Widawsky <[email protected]>
Excellent!
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76113
Quoted 30 lines
--- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_gem_gtt.c +5
-1@@ -30,6 +30,8 @@#include "i915_trace.h" #include "intel_drv.h" +static void gen8_setup_private_ppat (struct drm_i915_private *dev_priv); +bool intel_enable_ppgtt (struct drm_device *dev,bool full) {if (i915.enable_ppgtt ==0 || !HAS_ALIASING_PPGTT (dev))@@ -1371,8 +1373,10 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev) } -if (INTEL_INFO (dev)->gen >=8 ) +if (INTEL_INFO (dev)->gen >=8 ) { +gen8_setup_private_ppat (dev_priv);return ; + }list_for_each_entry (vm, &dev_priv->vm_list, global_link) {/* TODO: Perhaps it shouldn't be gen6 specific */
Signature · 1 line
[email protected]
Daniel Vetter
AppliedQuoted 5 lines · Timo Aaltonen
Quoted 4 lines · Ben Widawsky
Apparently it is wiped out from under us, and we get some really fun caching artifacts upon resume (it seems to be WB for all types by default).
Quoted 7 lines
Quoted 2 lines
Reported-by James Ausmus <[email protected]>Signed-off-by Ben Widawsky <[email protected]>Excellent!
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76113
Tested-by Timo Aaltonen <[email protected]>
Also Cc: [email protected]
Queued for -next, thanks for the patch.
-Daniel
Quoted 39 lines
Quoted 31 lines
--- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_gem_gtt.c +5
-1@@ -30,6 +30,8 @@#include "i915_trace.h" #include "intel_drv.h" +static void gen8_setup_private_ppat (struct drm_i915_private *dev_priv); +bool intel_enable_ppgtt (struct drm_device *dev,bool full) {if (i915.enable_ppgtt ==0 || !HAS_ALIASING_PPGTT (dev))@@ -1371,8 +1373,10 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev) } -if (INTEL_INFO (dev)->gen >=8 ) +if (INTEL_INFO (dev)->gen >=8 ) { +gen8_setup_private_ppat (dev_priv);return ; + }list_for_each_entry (vm, &dev_priv->vm_list, global_link) {/* TODO: Perhaps it shouldn't be gen6 specific */ Signature · 5 lines
[email protected] _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch