ARM: topology: Make it clear that all CPUs need to be described
PATCH 1/1 ARM: topology: Make it clear that all CPUs need to be described
From: Mark Brown <[email protected]>
The ARMv8 code will reject topologies that omit some CPUs (and it's not clear that it's ever sensible to do so). Update the binding document to make this clear.
--- Documentation/devicetree/bindings/arm/topology.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/arm/topology.txt +4 -3
@@ -75,9 +75,10 @@ The cpu-map node can only contain three types of child nodes: whose bindings are described in paragraph 3. -The nodes describing the CPU topology (cluster/core/thread) can only be -defined within the cpu-map node. -Any other configuration is consider invalid and therefore must be ignored. +The nodes describing the CPU topology (cluster/core/thread) can only +be defined within the cpu-map node and every core/thread in the system +must be defined within the topology. Any other configuration is +consider invalid and therefore must be ignored. =========================================== 2.1 - cpu-map child nodes naming convention
Signature · 1 line
1.9.1
PATCH 1/1 ARM: topology: Make it clear that all CPUs need to be described
Quoted 16 lines · Mark Brown
From: Mark Brown <[email protected]>
The ARMv8 code will reject topologies that omit some CPUs (and it's not clear that it's ever sensible to do so). Update the binding document to make this clear.
Signed-off-by Mark Brown <[email protected]>--- Documentation/devicetree/bindings/arm/topology.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/arm/topology.txt +0
-0
Documentation/devicetree/bindings/arm/topology.txt The cpu-map node can only contain three types of child nodes: · line 81
Quoted 10 lines
Documentation/devicetree/bindings/arm/topology.txt +4
-3@@ -75,9 +75,10 @@ The cpu-map node can only contain three types of child nodes: whose bindings are described in paragraph 3. -The nodes describing the CPU topology (cluster/core/thread) can only be -defined within the cpu-map node. -Any other configuration is consider invalid and therefore must be ignored. +The nodes describing the CPU topology (cluster/core/thread) can only +be defined within the cpu-map node and every core/thread in the system +must be defined within the topology. Any other configuration is +consider invalid and therefore must be ignored.
s/consider/considered/ (or drop the word entirely?).
Otherwise this looks sane to me, given there are currently no users of this information relying on partial topology descriptions.
Cheers,
Mark.
PATCH 1/1 ARM: topology: Make it clear that all CPUs need to be described
Quoted 9 lines · Mark Rutland
Documentation/devicetree/bindings/arm/topology.txt The cpu-map node can only contain three types of child nodes: · line 81
Quoted 5 lines · Mark Brown
Documentation/devicetree/bindings/arm/topology.txt +4
-1-Any other configuration is consider invalid and therefore must be ignored. +The nodes describing the CPU topology (cluster/core/thread) can only +be defined within the cpu-map node and every core/thread in the system +must be defined within the topology. Any other configuration is +consider invalid and therefore must be ignored.s/consider/considered/ (or drop the word entirely?).
Yup (that's a preexisting thing in the text that got reflowed).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140321/4da148ef/attachment-0001.sig>