Skip to contentSkip to conversation

block: Use RCU_INIT_POINTER(x, NULL) in partition-generic.c

PATCH New Monam Agarwal 1 participant 1 message Mar 22, 2014 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: Use RCU_INIT_POINTER(x, NULL) in partition-generic.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

---
 block/partition-generic.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
block/partition-generic.c +2 -2
index 789cdea..f1ef057 100644
@@ -249,8 +249,8 @@ void delete_partition(struct gendisk *disk, int partno)
 	if (!part)
 		return;
 
-	rcu_assign_pointer(ptbl->part[partno], NULL);
-	rcu_assign_pointer(ptbl->last_lookup, NULL);
+	RCU_INIT_POINTER(ptbl->part[partno], NULL);
+	RCU_INIT_POINTER(ptbl->last_lookup, NULL);
 	kobject_put(part->holder_dir);
 	device_del(part_to_dev(part));
 	blk_free_devt(part_devt(part));
Signature · 1 line
1.7.9.5