drivers/staging: Use RCU_INIT_POINTER(x, NULL) in fwserial/fwserial.c
PATCH 1/1 drivers/staging: Use RCU_INIT_POINTER(x, NULL) in fwserial/fwserial.c
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
Signed-off-by Monam Agarwal <[email protected]>
--- drivers/staging/fwserial/fwserial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fwserial/fwserial.c +2 -2
@@ -1809,7 +1809,7 @@ static void fwserial_release_port(struct fwtty_port *port, bool reset) port->max_payload =link_speed_to_max_payload (SCODE_100 );dma_fifo_change_tx_limit (&port->tx_fifo, port->max_payload); -rcu_assign_pointer (port->peer,NULL ); +RCU_INIT_POINTER (port->peer,NULL );spin_unlock_bh (&port->lock);if (port->port.console && port->fwcon_ops->notify !=NULL )
@@ -2235,7 +2235,7 @@ static int fwserial_create(struct fw_unit *unit) port->max_payload =link_speed_to_max_payload (SCODE_100 );dma_fifo_init (&port->tx_fifo); -rcu_assign_pointer (port->peer,NULL ); +RCU_INIT_POINTER (port->peer,NULL ); serial->ports[i] = port;/* get unique bus addr region for port's status & recv fifo */
Signature · 1 line
1.7.9.5