Skip to contentSkip to conversation

fs: Use RCU_INIT_POINTER(x, NULL) in afs/inode.c

PATCH New Monam Agarwal 1 participant 1 message Mar 23, 2014 Afs filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: Use RCU_INIT_POINTER(x, NULL) in afs/inode.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

---
 fs/afs/inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/afs/inode.c +1 -1
index ce25d75..7c09dfe 100644
@@ -445,7 +445,7 @@ void afs_evict_inode(struct inode *inode)
 
 	mutex_lock(&vnode->permits_lock);
 	permits = vnode->permits;
-	rcu_assign_pointer(vnode->permits, NULL);
+	RCU_INIT_POINTER(vnode->permits, NULL);
 	mutex_unlock(&vnode->permits_lock);
 	if (permits)
 		call_rcu(&permits->rcu, afs_zap_permits);
Signature · 1 line
1.7.9.5