Skip to contentSkip to conversation

fs: Use RCU_INIT_POINTER(x, NULL) in proc/inode.c

PATCH New Monam Agarwal 1 participant 1 message Mar 23, 2014 Proc filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: Use RCU_INIT_POINTER(x, NULL) in proc/inode.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

---
 fs/proc/inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/proc/inode.c +1 -1
index 124fc43..28c21d9 100644
@@ -47,7 +47,7 @@ static void proc_evict_inode(struct inode *inode)
 		pde_put(de);
 	head = PROC_I(inode)->sysctl;
 	if (head) {
-		rcu_assign_pointer(PROC_I(inode)->sysctl, NULL);
+		RCU_INIT_POINTER(PROC_I(inode)->sysctl, NULL);
 		sysctl_head_put(head);
 	}
 	/* Release any associated namespace */
Signature · 1 line
1.7.9.5