Skip to contentSkip to conversation

kernel/events: Use RCU_INIT_POINTER(x, NULL) in callchain.c

PATCH New Monam Agarwal 1 participant 1 message Mar 23, 2014 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/events: Use RCU_INIT_POINTER(x, NULL) in callchain.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

---
 kernel/events/callchain.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/events/callchain.c +1 -1
index 97b67df..f2a88de 100644
@@ -52,7 +52,7 @@ static void release_callchain_buffers(void)
 	struct callchain_cpus_entries *entries;
 
 	entries = callchain_cpus_entries;
-	rcu_assign_pointer(callchain_cpus_entries, NULL);
+	RCU_INIT_POINTER(callchain_cpus_entries, NULL);
 	call_rcu(&entries->rcu_head, release_callchain_buffers_rcu);
 }
 
Signature · 1 line
1.7.9.5