Failure in license.bbclass

Hi,

Your recent (from November) change to license.bbclass in Yocto Dora release completely breaks COPY_LIC_DIRS.

Running the command manually for any package results in command line syntax error:
jussi@porkkala:/home/scratch/jussi/poky/build> oe-pkgdata-util lookup-recipe /home/scratch/jussi/poky/build/tmp/sysroots/cubox-i/pkgdata alsa-conf-base
syntax: oe-pkgdata-util glob [-d] <pkgdatadir> <vendor-os> <pkglist> "<globs>"
read-value [-d] <pkgdatadir> <vendor-os>
<value-name> "<package-name>_<package_architecture>"

Best regards,

- Jussi

It seems dora has some patches of oe-pkgdata-util not rebased from poky, such as:

commit 6ce287937e86a43d696e3615aa18d439928b7691

Author: Paul Eggleton <[email protected]>
Date:   Fri Oct 18 14:52:10 2013 +0100

scripts/oe-pkgdata-util: add ability to find a recipe from a target
package

//Hongxu

Quoted 22 lines · Jussi Laako

Hi,

Your recent (from November) change to license.bbclass in Yocto Dora release completely breaks COPY_LIC_DIRS.

Running the command manually for any package results in command line syntax error:
jussi@porkkala:/home/scratch/jussi/poky/build> oe-pkgdata-util lookup-recipe /home/scratch/jussi/poky/build/tmp/sysroots/cubox-i/pkgdata alsa-conf-base
syntax: oe-pkgdata-util glob [-d] <pkgdatadir> <vendor-os> <pkglist> "<globs>"

read-value [-d] <pkgdatadir> <vendor-os>

<value-name> "<package-name>_<package_architecture>"

Best regards,

- Jussi

Hi Hongxu,

The person you need to CC is Robert Yang since he maintains the dora branch. FWIW I hadn't anticipated this patch being backported, but I guess if functionality now in dora relies upon it we have no choice :(

Cheers,
Paul

Quoted 35 lines · On Tuesday 11 March 2014 17:16:05 Hongxu Jia wrote:

It seems dora has some patches of oe-pkgdata-util not rebased from poky, such as:

commit 6ce287937e86a43d696e3615aa18d439928b7691

Author: Paul Eggleton <[email protected]>
Date:   Fri Oct 18 14:52:10 2013 +0100

scripts/oe-pkgdata-util: add ability to find a recipe from a target
package

//Hongxu

Quoted 22 lines · Jussi Laako

Hi,

Your recent (from November) change to license.bbclass in Yocto Dora release completely breaks COPY_LIC_DIRS.

Running the command manually for any package results in command line syntax error:
jussi@porkkala:/home/scratch/jussi/poky/build> oe-pkgdata-util lookup-recipe /home/scratch/jussi/poky/build/tmp/sysroots/cubox-i/pkgdata alsa-conf-base
syntax: oe-pkgdata-util glob [-d] <pkgdatadir> <vendor-os> <pkglist> "<globs>"

read-value [-d] <pkgdatadir> <vendor-os>

<value-name> "<package-name>_<package_architecture>"

Best regards,

- Jussi

Hi,

Quoted 10 lines · Robert Yang

It is used for fixing this bug:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=5572

Enalbe COPY_LIC_MANIFEST and COPY_LIC_DIRS: No kernel license is installed in image

But it used the "oe-pkgdata-util lookup-recipe" which is only on master branch,
I think that we'd better:

Quoted 5 lines

1) Revert this commit, then it works with minor problems.

Or

2) Fix the "oe-pkgdata-util lookup-recipe" on dora.

With core-image-minimal spiced up with couple of packages, there were quite many license directories left empty, so it requires fair amount of manual work to rectify the situation. So it is far more than just the kernel.

For example any libraries coming from util-linux, plus any of the gcc runtimes (libgcc, etc). There are many packages where source name doesn't match with the produced packages.

Since BSPs tend to lag behind release schedule, option (2) could possibly help quite many...

Best regards,

- Jussi

Quoted 23 lines · Jussi Laako

Hi,

Quoted 10 lines · Robert Yang

It is used for fixing this bug:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=5572

Enalbe COPY_LIC_MANIFEST and COPY_LIC_DIRS: No kernel license is installed in image

But it used the "oe-pkgdata-util lookup-recipe" which is only on master branch,
I think that we'd better:

Quoted 5 lines

1) Revert this commit, then it works with minor problems.

Or

2) Fix the "oe-pkgdata-util lookup-recipe" on dora.

With core-image-minimal spiced up with couple of packages, there were quite many license directories left empty, so it requires fair amount of manual work to rectify the situation. So it is far more than just the kernel.

Quoted 7 lines

For example any libraries coming from util-linux, plus any of the gcc runtimes (libgcc, etc). There are many packages where source name doesn't match with the produced packages.

Since BSPs tend to lag behind release schedule, option (2) could possibly help quite many...

Thanks, I've talked Hongxu, he will fix it on dora without backport the 7 commits, and we need revert this one on dora:

commit e58a1499accd74d3e6fe4f899711d4c680ebc18f

Author: Hongxu Jia <[email protected]>
Date:   Wed Nov 20 18:35:39 2013 +0800

license.bbclass: fix copying license directories failed

Paul and RP, what's your opinion, please ?