USB: serial: ftdi_sio: add id for Brainboxes VX-001 ExpressCard
Subsystems (2)
PATCH 1/1 USB: serial: ftdi_sio: add id for Brainboxes VX-001 ExpressCard
Custom VID/PID for Brainboxes VX-001 ExpressCard RS232 as reported in
https://bugzilla.redhat.com/show_bug.cgi?id=1071914
--- drivers/usb/serial/ftdi_sio.c | 2 ++ drivers/usb/serial/ftdi_sio_ids.h | 7 +++++++ 2 files changed, 9 insertions(+)
drivers/usb/serial/ftdi_sio.c +2 -0
@@ -909,6 +909,8 @@ static const struct usb_device_id id_table_combined[] = { { USB_DEVICE(FTDI_VID, FTDI_Z3X_PID) },/* Cressi Devices */ { USB_DEVICE(FTDI_VID, FTDI_CRESSI_PID) }, +/* Brainbox Devices */ + { USB_DEVICE(BRAINBOXES_VID, BRAINBOXES_VX_001_PID) }, { } /* Terminating entry */ };
drivers/usb/serial/ftdi_sio_ids.h +7 -0
@@ -1326,3 +1326,10 @@* Manufacturer: Cressi */ #define FTDI_CRESSI_PID 0x87d0 + +/* +* Product: ExpressCard 1 Port RS2323 +* Manufacturer: Brainboxes +*/ +#define BRAINBOXES_VID 0x05d1 +#define BRAINBOXES_VX_001_PID 0x1001
Signature · 1 line
1.8.5.3
2014-03-25 20:00 GMT+01:00 Michele Baldessari:
Quoted 3 lines
Custom VID/PID for Brainboxes VX-001 ExpressCard RS232 as reported in
+ * Product: ExpressCard 1 Port RS2323
there is a stray trailing "3"
Signature · 1 line
Daniele Forsi
Quoted 2 lines · Michele Baldessari
Custom VID/PID for Brainboxes VX-001 ExpressCard RS232 as reported in
https://bugzilla.redhat.com/show_bug.cgi?id=1071914
Thanks for the patch.
How about including the other PIDs listed in the report (in the attached udev-rule) as well?
Quoted 24 lines
Signed-off-by Michele Baldessari <[email protected]>--- drivers/usb/serial/ftdi_sio.c | 2 ++ drivers/usb/serial/ftdi_sio_ids.h | 7 +++++++ 2 files changed, 9 insertions(+)drivers/usb/serial/ftdi_sio.c +2
-0@@ -909,6 +909,8 @@ static const struct usb_device_id id_table_combined[] = { { USB_DEVICE(FTDI_VID, FTDI_Z3X_PID) },/* Cressi Devices */ { USB_DEVICE(FTDI_VID, FTDI_CRESSI_PID) }, +/* Brainbox Devices */ + { USB_DEVICE(BRAINBOXES_VID, BRAINBOXES_VX_001_PID) }, { } /* Terminating entry */ };drivers/usb/serial/ftdi_sio_ids.h +0
-0
drivers/usb/serial/ftdi_sio_ids.h line 1333
Quoted 8 lines
drivers/usb/serial/ftdi_sio_ids.h +5
-0@@ -1326,3 +1326,10 @@* Manufacturer: Cressi */ #define FTDI_CRESSI_PID 0x87d0 + +/* +* Product: ExpressCard 1 Port RS2323 +* Manufacturer: Brainboxes +*/
Could you just make this a "Brainboxes devices"-header and then list any product in a comment following the PID instead? That would "scale" better when adding more Brainboxes PIDs.
drivers/usb/serial/ftdi_sio_ids.h line 1335
Quoted 2 lines
drivers/usb/serial/ftdi_sio_ids.h +2
-0+#define BRAINBOXES_VID 0x05d1 +#define BRAINBOXES_VX_001_PID 0x1001
That is, something like:
/*
* Brainboxes devices
*/
#define BRAINBOXES_VID 0x05d1
#define BRAINBOXES_VX_001_PID 0x1001 /* ExpressCard 1 Port RS2323 */
Thanks,
Johan